From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Lars-Peter Clausen <lars@metafoo.de>,
nuno.sa@analog.com, Shenghao Ding <shenghao-ding@ti.com>,
Kevin Lu <kevin-lu@ti.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
Steven Eckhoff <steven.eckhoff.opensource@gmail.com>,
Srinivas Kandagatla <srini@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Linus Walleij <linusw@kernel.org>,
u.kleine-koenig@baylibre.com,
Thorsten Blum <thorsten.blum@linux.dev>,
Kees Cook <kees@kernel.org>, Chen Ni <nichen@iscas.ac.cn>,
Bartosz Golaszewski <brgl@kernel.org>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v3 22/26] ASoC: codecs: wm8962: Use guard() for mutex locks
Date: Fri, 31 Jul 2026 10:06:44 +0700 [thread overview]
Message-ID: <20260731030648.8706-23-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260731030648.8706-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/codecs/wm8962.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
index 2db822fc1de7..8a9598161b35 100644
--- a/sound/soc/codecs/wm8962.c
+++ b/sound/soc/codecs/wm8962.c
@@ -10,6 +10,7 @@
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/init.h>
+#include <linux/cleanup.h>
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/pm.h>
@@ -1564,11 +1565,10 @@ static int wm8962_dsp2_ena_put(struct snd_kcontrol *kcontrol,
struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
struct wm8962_priv *wm8962 = snd_soc_component_get_drvdata(component);
int old = wm8962->dsp2_ena;
- int ret = 0;
int dsp2_running = snd_soc_component_read(component, WM8962_DSP2_POWER_MANAGEMENT) &
WM8962_DSP2_ENA;
- mutex_lock(&wm8962->dsp2_ena_lock);
+ guard(mutex)(&wm8962->dsp2_ena_lock);
if (ucontrol->value.integer.value[0])
wm8962->dsp2_ena |= 1 << shift;
@@ -1576,9 +1576,7 @@ static int wm8962_dsp2_ena_put(struct snd_kcontrol *kcontrol,
wm8962->dsp2_ena &= ~(1 << shift);
if (wm8962->dsp2_ena == old)
- goto out;
-
- ret = 1;
+ return 0;
if (dsp2_running) {
if (wm8962->dsp2_ena)
@@ -1587,10 +1585,7 @@ static int wm8962_dsp2_ena_put(struct snd_kcontrol *kcontrol,
wm8962_dsp2_stop(component);
}
-out:
- mutex_unlock(&wm8962->dsp2_ena_lock);
-
- return ret;
+ return 1;
}
/* The VU bits for the headphones are in a different register to the mute
--
2.43.0
next prev parent reply other threads:[~2026-07-31 3:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:06 [PATCH v3 00/26] ASoC: codecs: Use guard() for mutex & spin locks - part 3 phucduc.bui
2026-07-31 3:06 ` [PATCH v3 01/26] ASoC: codecs: sigmadsp: Use guard() for mutex locks phucduc.bui
2026-07-31 3:06 ` [PATCH v3 02/26] ASoC: codecs: sta350: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 03/26] ASoC: codecs: sta32x: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 04/26] ASoC: codecs: tas2781: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 05/26] ASoC: codecs: tas2783: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 06/26] ASoC: codecs: tas5805m: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 07/26] ASoC: codecs: tlv320dac33: Use guard() for mutex & spin locks phucduc.bui
2026-07-31 3:06 ` [PATCH v3 08/26] ASoC: codecs: tscs42xx: Use guard() for mutex locks phucduc.bui
2026-07-31 3:06 ` [PATCH v3 09/26] ASoC: codecs: tscs454: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 10/26] ASoC: codecs: twl6040: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 11/26] ASoC: codecs: wcd-mbhc: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 12/26] ASoC: codecs: wcd934x: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 13/26] ASoC: codecs: wcd937x: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 14/26] ASoC: codecs: wcd938x: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 15/26] ASoC: codecs: wcd939x: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 16/26] ASoC: codecs: wm0010: Use guard() for mutex & spin locks phucduc.bui
2026-07-31 3:06 ` [PATCH v3 17/26] ASoC: codecs: wm2000: Use guard() for mutex locks phucduc.bui
2026-07-31 3:06 ` [PATCH v3 18/26] ASoC: codecs: wm5102: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 19/26] ASoC: codecs: wm8731: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 20/26] ASoC: codecs: wm8903: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 21/26] ASoC: codecs: wm8958: " phucduc.bui
2026-07-31 3:06 ` phucduc.bui [this message]
2026-07-31 3:06 ` [PATCH v3 23/26] ASoC: codecs: wm8994: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 24/26] ASoC: codecs: wm971x: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 25/26] ASoC: codecs: wm_adsp: " phucduc.bui
2026-07-31 3:06 ` [PATCH v3 26/26] ASoC: codecs: wsa88xx: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731030648.8706-23-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=baojun.xu@ti.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=kees@kernel.org \
--cc=kevin-lu@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=nuno.sa@analog.com \
--cc=patches@opensource.cirrus.com \
--cc=pengpeng@iscas.ac.cn \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=shengjiu.wang@nxp.com \
--cc=srini@kernel.org \
--cc=steven.eckhoff.opensource@gmail.com \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.