From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51233C55167 for ; Fri, 31 Jul 2026 05:01:21 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8791E40DD0; Fri, 31 Jul 2026 07:00:07 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 40C0D40DCA for ; Fri, 31 Jul 2026 07:00:06 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2d004f135b1so6116115ad.3 for ; Thu, 30 Jul 2026 22:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1785474005; x=1786078805; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dgOfGdIrUWElVZ8RERrHIa5tu6DvybwadqOzpvd1HHM=; b=RPtOSjcC2vXnWaGzyWO+NTDyDmqUqgga10pv2fS+IBkFcTyohkWzbdmENTPqS/dne1 1BbCGdnNO4EuYZ92PM5FqRYBB7Hgb+ISbt0w3dQu2UJYdXF3eXNi3A8Nr5b3boMf8y4l 8xV4+40BeKWQIfCVGeE8heZdb3SPhBf/nvLQDtYeWyX7yrNepvGBjwSa8fn/lvIg4w6E rABAevC4+6Pg3d6qWx1grKkJqwjanMuWzdtT8H1izWnSvM6YdWr6DgeubGo97jbb2BQ2 XxkiOtMycfOuK6GJq391wGUWCknmIpM/1kgvZD+GbcvHGeNopvYgEO5yje+LHbeDQmH/ AOjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785474005; x=1786078805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dgOfGdIrUWElVZ8RERrHIa5tu6DvybwadqOzpvd1HHM=; b=m/bDZTjSzRY+XfnJi7iJ35pgDp0GnWTeMmMOeLMD4G9eeG9kK2jTYBVhiZZUN0hsX6 n0SsM6ULNsfst5S0HNGWsLy1oGexZfRR/8efi9y6FQWWtDbZ29JVfWSyGmkB49azCyWX ekLJeJDu5JZ/hetnImZMKke9jy90NIYC3WvbazQRm5Jvhpc8Mk+Ch4Vu2pFNN4eJCoHc LeWvITzlvMNWXe32JmRRT4Sb9OXNQZGnmlGYPK+Xf2zHt47OF9DSwG0DrPqdm1FYDs+i ZcFBBpxlhWHG2HbMa8sLm+pBLMCrlraSJsqCtTvTiJeCXChuFPPT27Q5wbJPgez3d9NI hYlQ== X-Gm-Message-State: AOJu0YwwSGuudEAdqLD9798SqiL8qejEborzAWHhPz/29NuBSnOvg+HW ojAjRUnNoY1MFCI54wrjFjcSvRuarR2jezl4AXReuIzotvkfy3cm9CJ6uevL+bx9i++DbSM8bNJ nmeQG X-Gm-Gg: AR+sD131a8UTuVXaIxXOh0EaoHBzn9pfcDSK8VrfeMYQPU3nrGFNjrJmGj4geRgQGIZ TGJrNfYzkbFIdu1uQ8q6I63BEVt93sc6lH/fkOdlFQpFBCtSLfLFOyow4aoJt++zGmOh/9FvHR1 SdhgYnKqicVieCSthrnCP81uy5yoN0/X9AYkPaS2306wNNwF1ZsKqgQQP+LAj4oqtiDgJQqX39s cJYw9OEUbN4itxqahmr89zM558qDhjl0gPnGWQT4yVyBAWfj7aZJImMSmo/nVL56F8fTwiDLySt +R//JtXWx6mJ/Z8cZz1aA8fT6aLmBK7t0fsrYZmWFlUny4QYDPH31FmUdX3CU3tkBqhdcLE5eAh +38VTB840jG/3X8Rr6wiAsqZytc2WjOoXbY2p0sQDfRRCgfpM1Wy8pzy516pljfpV+nzgUWAFgx aK7JVr6X3Qnlai+yrIv3N/3EMvDcCG6qCAoTHh164DJyn1jHXNKyCJ3kl+y1379x4rrVFUA6u07 13SnIWtc6isVAhWvtwoiYhwITc= X-Received: by 2002:a05:6a20:7485:b0:3c3:8d86:9856 with SMTP id adf61e73a8af0-3c91b0a96efmr476922637.14.1785474005244; Thu, 30 Jul 2026 22:00:05 -0700 (PDT) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e06f0f9sm823245eec.23.2026.07.30.22.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 22:00:04 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v6 13/24] event/sw: convert from rte_atomic32 to stdatomic Date: Thu, 30 Jul 2026 21:57:51 -0700 Message-ID: <20260731045948.769926-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260731045948.769926-1-stephen@networkplumber.org> References: <20260521042043.1590536-1-stephen@networkplumber.org> <20260731045948.769926-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use stdatomic to keep track of inflights. Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c | 8 +++++--- drivers/event/sw/sw_evdev.h | 4 ++-- drivers/event/sw/sw_evdev_worker.c | 16 +++++++++++----- 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 3ad82e94ac..a2f760a98d 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -153,7 +153,9 @@ sw_port_setup(struct rte_eventdev *dev, uint8_t port_id, * the sum to no leak credits */ int possible_inflights = p->inflight_credits + p->inflights; - rte_atomic32_sub(&sw->inflights, possible_inflights); + rte_atomic_fetch_sub_explicit(&sw->inflights, + possible_inflights, + rte_memory_order_release); } *p = (struct sw_port){0}; /* zero entire structure */ @@ -512,7 +514,7 @@ sw_dev_configure(const struct rte_eventdev *dev) sw->qid_count = conf->nb_event_queues; sw->port_count = conf->nb_event_ports; sw->nb_events_limit = conf->nb_events_limit; - rte_atomic32_set(&sw->inflights, 0); + sw->inflights = 0; /* Number of chunks sized for worst-case spread of events across IQs */ num_chunks = ((SW_INFLIGHT_EVENTS_TOTAL/SW_EVS_PER_Q_CHUNK)+1) + @@ -633,7 +635,7 @@ sw_dump(struct rte_eventdev *dev, FILE *f) fprintf(f, "\tsched cq/qid call: %"PRIu64"\n", sw->sched_cq_qid_called); fprintf(f, "\tsched no IQ enq: %"PRIu64"\n", sw->sched_no_iq_enqueues); fprintf(f, "\tsched no CQ enq: %"PRIu64"\n", sw->sched_no_cq_enqueues); - uint32_t inflights = rte_atomic32_read(&sw->inflights); + uint32_t inflights = rte_atomic_load_explicit(&sw->inflights, rte_memory_order_relaxed); uint32_t credits = sw->nb_events_limit - inflights; fprintf(f, "\tinflight %d, credits: %d\n", inflights, credits); diff --git a/drivers/event/sw/sw_evdev.h b/drivers/event/sw/sw_evdev.h index c159be21be..5e49b08030 100644 --- a/drivers/event/sw/sw_evdev.h +++ b/drivers/event/sw/sw_evdev.h @@ -8,7 +8,7 @@ #include "sw_evdev_log.h" #include #include -#include +#include #define SW_DEFAULT_CREDIT_QUANTA 32 #define SW_DEFAULT_SCHED_QUANTA 128 @@ -233,7 +233,7 @@ struct sw_evdev { /* Contains all ports - load balanced and directed */ alignas(RTE_CACHE_LINE_SIZE) struct sw_port ports[SW_PORTS_MAX]; - alignas(RTE_CACHE_LINE_SIZE) rte_atomic32_t inflights; + alignas(RTE_CACHE_LINE_SIZE) RTE_ATOMIC(uint32_t) inflights; /* * max events in this instance. Cached here for performance. diff --git a/drivers/event/sw/sw_evdev_worker.c b/drivers/event/sw/sw_evdev_worker.c index 4215726513..0755def367 100644 --- a/drivers/event/sw/sw_evdev_worker.c +++ b/drivers/event/sw/sw_evdev_worker.c @@ -56,7 +56,7 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num) uint8_t new_ops[PORT_ENQUEUE_MAX_BURST_SIZE]; struct sw_port *p = port; struct sw_evdev *sw = (void *)p->sw; - uint32_t sw_inflights = rte_atomic32_read(&sw->inflights); + uint32_t sw_inflights = rte_atomic_load_explicit(&sw->inflights, rte_memory_order_relaxed); uint32_t credit_update_quanta = sw->credit_update_quanta; int new = 0; @@ -74,8 +74,10 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num) if (sw_inflights + credit_update_quanta > sw->nb_events_limit) return 0; - rte_atomic32_add(&sw->inflights, credit_update_quanta); - p->inflight_credits += (credit_update_quanta); + rte_atomic_fetch_add_explicit(&sw->inflights, + credit_update_quanta, + rte_memory_order_acquire); + p->inflight_credits += credit_update_quanta; /* If there are fewer inflight credits than new events, limit * the number of enqueued events. @@ -124,7 +126,9 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num) /* Replenish credits if enough releases are performed */ if (p->inflight_credits >= credit_update_quanta * 2) { - rte_atomic32_sub(&sw->inflights, credit_update_quanta); + rte_atomic_fetch_sub_explicit(&sw->inflights, + credit_update_quanta, + rte_memory_order_release); p->inflight_credits -= credit_update_quanta; } @@ -150,7 +154,9 @@ sw_event_dequeue_burst(void *port, struct rte_event *ev, uint16_t num, /* Replenish credits if enough releases are performed */ if (p->inflight_credits >= credit_update_quanta * 2) { - rte_atomic32_sub(&sw->inflights, credit_update_quanta); + rte_atomic_fetch_sub_explicit(&sw->inflights, + credit_update_quanta, + rte_memory_order_release); p->inflight_credits -= credit_update_quanta; } } -- 2.53.0