Re: [PATCH v4 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The dt-bindings introduce the Kalambo SoC as a derivative of Mahua but omit the `qcom,mahua` fallback string, causing core driver initialization failures.
--

--- Patch [1]: [PATCH v4 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board ---
commit 0b31003941ba4b70a8690af4bfa949f21d29c3f3
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

dt-bindings: arm: qcom: Document Kalambo SoC and board

Qualcomm Kalambo is a derivative of the Mahua SoC with CPU cluster 0
removed, leaving it with just cluster 1. Document the compatible strings
for the Kalambo SoC and the Compute Reference Device (CRD) board based
on it.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index c7c9a92796846..b0c07a57bda69 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -174,6 +174,11 @@ properties:
>                - qcom,kaanapali-qrd
>            - const: qcom,kaanapali
>  
> +      - items:
> +          - enum:
> +              - qcom,kalambo-crd
> +          - const: qcom,kalambo
> +

[Severity: High]
Since Kalambo is a derivative of Mahua, should this binding include the
"qcom,mahua" fallback compatible string?

By forcing an exact two-item compatible list, it prohibits using "qcom,mahua"
as a fallback in the device tree. Because core drivers were not updated to
match the new "qcom,kalambo" strings in this series, they will fail to probe.

For example, qcom_pdm_domains in drivers/soc/qcom/qcom_pd_mapper.c requires:

	{ .compatible = "qcom,mahua", .data = glymur_domains, },

And qcom_ubwc_configs in drivers/soc/qcom/ubwc_config.c matches against:

	{ .compatible = "qcom,mahua", .data = &glymur_data },

Similarly, qcom_scm_qseecom_allowlist in drivers/firmware/qcom/qcom_scm.c:

	{ .compatible = "qcom,mahua-crd" },

Will these drivers fail to configure the hardware on this board without either
a fallback in the DT binding, or explicit updates to the respective drivers to
recognize the new Kalambo SoC strings?

>        - items:
>            - enum:
>                - qcom,mahua-crd

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-b4-kalambo-crd-v4-0-e458f8b08114@oss.qualcomm.com?part=1