From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f0.google.com (mail-pj2-f0.google.com [74.125.227.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 359C7367F21 for ; Fri, 31 Jul 2026 07:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481592; cv=none; b=mIIcSqHGwulPPmnFYO3Nj5ZC3YosvfCzIr0to5Qwx0uNDH326sUv52ZGPw5e9WEbh5X9Z/A9DpYBfCCcK7If8sYBXyFDNglAuA+/qZSqUWaAVLo1i7JE5hEBBPWRrTQHw/XRbRXrBQNOWy4rnzsnLS5VOZE04Ks4uMlQN5b2jTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785481592; c=relaxed/simple; bh=bmbAN0joM0QSQlBsr+1XRr4e0QuytSVMbBJ5jv9uc0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dnfAqVis++h+31dyieY8hpgMQoWBONuwAQsilKwIqyb+kIhLb5IRb2C9+s2iOe4zQn3u0ziET7i26ajsPPa8xwodD37vlqCjyCVpEw9ZU2trk+sVFIJ/rYQm21xLcldeyqigx1VK4phwvDxF+7q6XyD0kSRpFn13KH3MGoh0txQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bDswUyj1; arc=none smtp.client-ip=74.125.227.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bDswUyj1" Received: by mail-pj2-f0.google.com with SMTP id d9443c01a7336-2cc7a345f51so4592495ad.0 for ; Fri, 31 Jul 2026 00:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785481590; x=1786086390; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/2eeMe4bUYVoR8xJiruE/ZmrCkmBvcANozp9bXajUHw=; b=bDswUyj1YBTD7NhL8+nCF3U10WcOIBHgWqypjhbNUydx2mykMCAr4k/Ey8eoTwS/DQ 2YwaZr55t39c1aRwKFOPVXIZvKVUBP9NcYf2RlBmmIeaWCOZ4RdoW7jq7JXPEKAoSW+E HNT6gPrv1u7WQ2LZ+pBhZXZ7C+n0IXPNN4xMBm583YIZLxusgwtFCeYQb6ppfNM1hVQR TYTBy3tgiqSRA4R/cJEB94L+lWmJKc18rLor5oxqDMcxhv0R6VIVO5QXZ2Dn/Tx6PKiy hU1yzzELLfOVHach5LPXDdJd8xLIzdFZyFfXOqdbqNoIFiyj00nRPiJdR/RFHfCkV06l 1kDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785481590; x=1786086390; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/2eeMe4bUYVoR8xJiruE/ZmrCkmBvcANozp9bXajUHw=; b=FqOXAcQlBkENvZMyehZSz/d8GvNxikSKpQChvrZUbqExxt63soKnFFtgTWM/qubsTB 7H6MsG/tCXQbxrWuZtThYpu+Zl2KsHlo7zgYONwL/0c89NBxxFd1jPOSM9IG3lSHuU0v Qmj2mgXO27i7hWMg6DLl1UeHHet4EC/9Gh2+otjx9MBPcz444ADR289ZNB6/BpBfIEBb FBLZmDYL0kVSpd6qmTl957Hblfy4XWoTq2MOKnQRC9oInvzoA/7qTlbuoeqxaWOiA5wN D5TH5yrAVtISm4xpu4mlz205jxzBLTw0WE0QjBp68m6nMKPqhE0t6sD85IcSHciVCiV7 GvKw== X-Forwarded-Encrypted: i=1; AHgh+RoFili8FaKjbP0NOf/zSEuPMBd+b4CHLeFR4I7s9qcJiV7QY891nubbHj2I/QW+IcNbR8cUQm9V9t4cH3U=@vger.kernel.org X-Gm-Message-State: AOJu0YxQVtjR0XB+0qf/w8d2ERqTLIMt+dt3SI8KifOH08KbiuNUHdxd EKIfOIV2E7mjdYrw5iNWJzRndcLauIIR6rFQ9pGtG/KmQKAmLkuhy1HW X-Gm-Gg: AR+sD13DiakNPKlRISyB0sg1f85LzPmg05ipzQhuyovRdW4N99z0PpzFpYQRPh1TPRt CFG+3ukcXpiQsWOopDxxNwlN25mcs1nGgsX4OYMgVmc+EzQV2zBaK4kCuSMhfHsNF4/b3DyPCf3 ZI6BOLfSrNDh2SHJqF2kMarqc3up+dNbf900z0ux2KN+89pjS29jx9rg/Jk9cv0Jb3qrkbQsr/c 3AGXkU+wMS+HE/lldophm+W6QA2ghCqR8Vjhcin7GKBkaNlMIvlES4NgW+gw47Z03a5JusllsSZ mmI3XEP8zD3E8A//qzI0+ZLTykjvdiYvcPZa2eV5cA6be8tPGBL9GAjDs7VtFKnQ7DNzQ9PqRTm 2S604wEeQM2TBIT3m3YnzO4w/JFMitj1pGEsbiGjKzBoojOcHJPuBP5/3XtVKSBIB4AAIEYW+Q0 TrDn9AU3sBmBSFey1gzyki9/rrNrefFF0m2+6jkH9D+mIPwRSc1OR7VZIeEPd4E43GVWtprDDGX 8s20+d56iPdYeCRycC8 X-Received: by 2002:a05:6a21:730b:b0:3c3:a140:938a with SMTP id adf61e73a8af0-3c91b316892mr899765637.45.1785481590453; Fri, 31 Jul 2026 00:06:30 -0700 (PDT) Received: from localhost.localdomain ([76.86.179.124]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm2589587eec.7.2026.07.31.00.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 00:06:29 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/3] staging: rtl8723bs: convert mgmt xmit coalesce to errno Date: Fri, 31 Jul 2026 07:05:44 +0000 Message-ID: <20260731070546.20959-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731070546.20959-1-dennylin0707@gmail.com> References: <20260731070546.20959-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values. Return 0 on success and negative errno on failure, and update the declaration in rtw_xmit.h accordingly Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 ++++---- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 16e6c9567224..01512f438295 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1187,7 +1187,7 @@ int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct } /* broadcast or multicast management pkt use BIP, unicast management pkt use CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe) +int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start = NULL, *tmp_buf = NULL; u8 subtype; @@ -1210,7 +1210,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s BIP_AAD = kzalloc(ori_len, GFP_ATOMIC); if (!BIP_AAD) - return _FAIL; + return -ENOMEM; tmp_buf = BIP_AAD; subtype = GetFrameSubType(pframe); /* bit(7)~bit(2) */ @@ -1341,12 +1341,12 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s xmitframe_coalesce_success: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _SUCCESS; + return 0; xmitframe_coalesce_fail: spin_unlock_bh(&padapter->security_key_mutex); kfree(BIP_AAD); - return _FAIL; + return -EINVAL; } /* Logical Link Control(LLC) SubNetwork Attachment Point(SNAP) header diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging/rtl8723bs/include/rtw_xmit.h index 917e846e9ce2..31decc210e73 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -424,7 +424,7 @@ int rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitfram extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *pattrib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->attrib) extern int rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe); -extern s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe); +extern int rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe); s32 _rtw_init_hw_txqueue(struct hw_txqueue *phw_txqueue, u8 ac_tag); void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv); -- 2.43.0