From: sashiko-bot@kernel.org
To: "Thomas Richter" <tmricht@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH] s390/pai: Handle CPU hotplug add for PAI PMU
Date: Fri, 31 Jul 2026 08:47:56 +0000 [thread overview]
Message-ID: <20260731084757.188E21F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260731084011.2568310-1-tmricht@linux.ibm.com>
> The command 'perf stat -e pai_crypto/CRYPTO_ALL/ -- <command>
> crashes the kernel when CPUs are hotplug added during that run.
>
> Root cause is the allocation of struct pai_mapptr at first
> event initialization. The allocation is dynamic and the first
> event that has task context creates such a structure for
> each online CPU. This is not sufficient. CPUs may be offline
> during event creation and can be set online during the
> perf run time. For example commands
>
> # echo 0 > /sys/devices/system/cpu/cpu1/online
> # perf stat -e pai_crypto/CRYPTO_ALL/ -i -- stress-ng -t10s --matrix X
> # sleep 1
> # echo 1 > /sys/devices/system/cpu/cpu1/online
>
> [ ... ]
> possible CPUs, not just the ones currently online.
>
> Fixes: 92ea686840ac ("s390/pai_crypto: Enable per-task counting event")
> Cc: <Stable@vger.kernel.org> # v6.11+
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260731084011.2568310-1-tmricht@linux.ibm.com?part=1
prev parent reply other threads:[~2026-07-31 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 8:40 [PATCH] s390/pai: Handle CPU hotplug add for PAI PMU Thomas Richter
2026-07-31 8:47 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731084757.188E21F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.