Re: [PATCH v4 1/2] arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing default pin control assignments in the WSA SoundWire controller node.
--

--- Patch [1]: [PATCH v4 1/2] arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support ---
commit c45484edfd4a43a902de46310fa2b56061e83268
Author: Ravi Hothi <ravi.hothi@oss.qualcomm.com>

arm64: dts: qcom: eliza: Add LPASS macro and SoundWire support

This commit adds SoC-level LPASS WSA macro, VA macro, SoundWire controller,
and LPASS LPI pin controller nodes for the Eliza platform. The DMIC and
WSA SoundWire pinctrl states are defined inside the LPASS LPI pin controller.

> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> index 1830020f23b18..3957dae4524e1 100644
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
[ ... ]
> @@ -2064,6 +2065,77 @@ q6prmcc: clock-controller {
[ ... ]
> +		swr0: soundwire@6b10000 {
> +			compatible = "qcom,soundwire-v2.1.0",
> +				     "qcom,soundwire-v2.0.0";
> +			reg = <0x0 0x06b10000 0x0 0x10000>;
> +			interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			clocks = <&lpass_wsamacro>;
> +			clock-names = "iface";
> +
> +			label = "WSA";
> +

[Severity: Medium]
Is this node missing the default pin control assignments?

Without pinctrl-0 and pinctrl-names properties to bind the hardware pins
defined in the wsa_swr_active node, will the SoundWire controller pins 
(GPIO 10 and 11) fail to be multiplexed to their SoundWire functions when 
the controller is enabled by a board file?

> +			qcom,din-ports = <4>;
> +			qcom,dout-ports = <9>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731084032.3106477-1-ravi.hothi@oss.qualcomm.com?part=1