Re: [PATCH v8 5/5] watchdog: aaeon: Add watchdog driver for SRG-IMX8P MCU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Contradiction between driver code and DT binding regarding timeout-sec property
--

--- Patch [5]: [PATCH v8 5/5] watchdog: aaeon: Add watchdog driver for SRG-IMX8P MCU ---
commit fca789df9bd6f6279b387ae274aa7dc26fa4cecd
Author: Thomas Perrot (Schneider Electric) <thomas.perrot@bootlin.com>

watchdog: aaeon: Add watchdog driver for SRG-IMX8P MCU

Add watchdog driver for the Aaeon SRG-IMX8P embedded controller.
This driver provides system monitoring and recovery capabilities
through the MCU's watchdog timer.

> diff --git a/drivers/watchdog/aaeon_mcu_wdt.c b/drivers/watchdog/aaeon_mcu_wdt.c
> new file mode 100644
> index 0000000000000..661d14393c6ec
> --- /dev/null
> +++ b/drivers/watchdog/aaeon_mcu_wdt.c
[ ... ]
> +static int aaeon_mcu_wdt_probe(struct platform_device *pdev)
> +{
[ ... ]
> +	/*
> +	 * The MCU firmware has a fixed hardware timeout of 25 seconds that
> +	 * cannot be changed. The watchdog core handles automatic pinging to
> +	 * support software timeouts longer than the hardware limit. The default
> +	 * software timeout of 240 seconds can be overridden via the DT
> +	 * timeout-sec property or the watchdog_timeout kernel boot parameter.
> +	 */
> +	wdt->timeout = AAEON_MCU_WDT_TIMEOUT;
> +	wdt->min_timeout = AAEON_MCU_WDT_MIN_TIMEOUT;
> +	wdt->max_hw_heartbeat_ms = AAEON_MCU_WDT_HEARTBEAT_MS;
> +	watchdog_init_timeout(wdt, timeout, dev->parent);

[Severity: Medium]
Will this cause device tree validation failures when users specify the
timeout-sec property?

The driver code and comment indicate that the timeout can be overridden via
the DT timeout-sec property on the parent node. However, the DT schema for
the parent MFD (Documentation/devicetree/bindings/mfd/aaeon,srg-imx8p-mcu.yaml)
enforces additionalProperties: false and does not define the timeout-sec
property.

If a user follows the driver's instructions and adds the timeout-sec property
to the MFD parent node, dtbs_check will fail. Should the timeout-sec property
be added to the DT binding?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-dev-b4-aaeon-mcu-driver-v8-0-9ab00e80df2a@bootlin.com?part=5