Re: [PATCH v3 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message incorrectly conflates the BCM4334 chip with BCM43340/BCM43341, leading to a conflicting mismatch with the assigned `brcm,bcm43340-fmac` compatible string.
--

--- Patch [7]: [PATCH v3 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration ---
commit 3696d445e834823ddf2bb90d90ee281b49e3e4e6
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration

This commit fixes the WiFi and Bluetooth configuration for the Asus TF701T by
dropping the unsupported reset-gpio from the Bluetooth node and adding the
required LPO clock to both nodes. It also updates the WiFi primary compatible
string to brcm,bcm43340-fmac.

> The BCM4334 chip's Bluetooth part does not support reset-gpio. This was
> confirmed by testing on the TF701T, so drop reset-gpio from the Bluetooth
> node to comply with the existing schema. Additionally, the BCM4334
> supports an LPO clock, which is required for proper and stable operation
> of WiFi and Bluetooth, so add it to both nodes. Lastly, the BCM4334 chip's
> WiFi part has a dedicated compatible in the schema, so set
> 'brcm,bcm43340-fmac' as the primary compatible while 'brcm,bcm4329-fmac'
> remains as a fallback.

[Severity: Medium]
Is the description of the chip in the commit message accurate?

The commit title correctly references the "BCM43341", but the body of the
commit message repeatedly refers to the "BCM4334" chip. This creates some
confusion because the BCM4334 has its own distinct compatible string
("brcm,bcm4334-fmac").

Claiming "the BCM4334 chip's WiFi part has a dedicated compatible [...] so set
'brcm,bcm43340-fmac'" contradicts the actual compatible string being used,
which targets the 43340/43341 variants.

> diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
[ ... ]
> @@ -2382,9 +2382,12 @@ mmc@78000000 {
>  		vqmmc-supply = <&vdd_1v8_vio>;
>  
>  		wifi@1 {
> -			compatible = "brcm,bcm4329-fmac";
> +			compatible = "brcm,bcm43340-fmac", "brcm,bcm4329-fmac";

Could the commit message body be updated to consistently reference the
BCM43341 (or BCM43340) instead of BCM4334, to match the hardware and this new
compatible string in the wifi node?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731114106.169398-1-clamor95@gmail.com?part=7