All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avinash Duduskar <avinash.duduskar@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v2] datatype: accept a numeric cgroupsv2 id on input
Date: Fri, 31 Jul 2026 18:11:39 +0530	[thread overview]
Message-ID: <20260731124139.2127004-1-avinash.duduskar@gmail.com> (raw)
In-Reply-To: <amyM0DqEImxfc8gK@chamomile>

On Fri, Jul 31, 2026 at 01:53:52PM +0200, Pablo Neira Ayuso wrote:
> Any reason to ignore the error that integer_type_parse() provides?

No, it was left over from the strict parser that owned its own message.
Nothing follows the call, so it reduces to a direct return and the hunk
goes from ten added lines to two:

+	/* the listing prints a raw id once the path is gone */
 	if (stat(cgroupv2_path, &st) < 0)
-		return error(&sym->location, "cgroupv2 path fails: %s",
-			     strerror(errno));
+		return integer_type_parse(ctx, sym, res);

v3 to follow.

Avi

      reply	other threads:[~2026-07-31 12:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 17:37 [PATCH nft v2] datatype: accept a numeric cgroupsv2 id on input Avinash Duduskar
2026-07-31 11:53 ` Pablo Neira Ayuso
2026-07-31 12:41   ` Avinash Duduskar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260731124139.2127004-1-avinash.duduskar@gmail.com \
    --to=avinash.duduskar@gmail.com \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.