Re: [PATCH net-next v10 11/11] net: airoha: add phylink support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing Kconfig dependency for FWNODE_PCS causes GDM2/3/4 ports to permanently fail at runtime.
--

--- Patch [11]: [PATCH net-next v10 11/11] net: airoha: add phylink support ---
commit 1e7a014be0e15c64f532ea8b2276b6e883f1d63b
Author: Christian Marangi <ansuelsmth@gmail.com>

net: airoha: add phylink support

Add phylink support for each GDM port. For GDM1 add the internal interface
mode as the only supported mode. For GDM2/3/4 add the required
configuration of the PCS to make the external PHY or attached SFP cage
work.

> diff --git a/drivers/net/ethernet/airoha/Kconfig b/drivers/net/ethernet/airoha/Kconfig
> index 1f6640a15fc94..789906516bf8f 100644
> --- a/drivers/net/ethernet/airoha/Kconfig
> +++ b/drivers/net/ethernet/airoha/Kconfig
> @@ -20,6 +20,7 @@ config NET_AIROHA
>  	depends on NET_DSA || !NET_DSA
>  	select NET_AIROHA_NPU
>  	select PAGE_POOL
> +	select PHYLINK
>  	help

[Severity: High]
Does this also need to select FWNODE_PCS?

If the kernel is built with NET_AIROHA but without FWNODE_PCS, the GDM2/3/4
network ports will fail to link up at runtime.

> diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
> index dba7c52c08969..5065d6583b9f0 100644
> --- a/drivers/net/ethernet/airoha/airoha_eth.c
> +++ b/drivers/net/ethernet/airoha/airoha_eth.c
[ ... ]
> @@ -3409,6 +3441,155 @@ bool airoha_is_valid_gdm_dev(struct airoha_eth *eth,
[ ... ]
> +	} else {
> +		config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
> +					   MAC_10 | MAC_100 | MAC_1000 |
> +					   MAC_2500FD | MAC_5000FD | MAC_10000FD;
> +
> +		config->num_possible_pcs = fwnode_phylink_pcs_count(dev_fwnode(config->dev));
> +		config->fill_available_pcs = airoha_fill_available_pcs;

Without FWNODE_PCS in Kconfig, fwnode_phylink_pcs_count() and
fwnode_phylink_pcs_parse() will fall back to the inline stubs in
<linux/pcs/pcs.h> which return 0 and -EOPNOTSUPP.

This leaves config->num_possible_pcs at 0, resulting in an empty PCS list.
When phylink later attempts to configure the link in phylink_major_config(),
it will fail to find a required PCS for interfaces like SGMII and log that it
couldn't find a PCS, failing the configuration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730102444.1967900-1-ansuelsmth@gmail.com?part=11