From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 759B3C54F54 for ; Fri, 31 Jul 2026 15:43:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC0BC10F2DE; Fri, 31 Jul 2026 15:43:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="Z5wAXy8j"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20C1F10F2DE for ; Fri, 31 Jul 2026 15:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1785512580; bh=fBNNrhizjHBzG7I04S5mXQ6sypEEL2Rvl/kkpOsp+Pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5wAXy8jWu7E5yXKb17Cgaj0/z+gPDP9iV/HUGc7ZZzZAmpMkNwQLK13E5Vp1Rddx 0PyYrV9RtnwS2zcsC7deeEG1k2yLUcP/AuHCJGsNhQLBFDXNfMjRnU2WxxEMWnv5b0 dql4C0AhNK3qsqipuwrP52dhl/GM3nUOCZOcO5m19f4yrv0cfO3Oy/XP+uIFbaRQ8S EgoSTPEF6ibsQwUuL3MdUe12aaHVR2w3uNmgFDdw7ybou8OqQ2jACWgIEXwaKEWqfR 2IcUDGEsAsePXa1fexcZ0F6Dnk62LYkz05D/fi4gbNV453xW3mHKs/j0blHP+a0od+ Zlv5UcstP4UlQ== Received: from archlinux (unknown [100.64.1.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: leandrohrb) by bali.collaboradmins.com (Postfix) with ESMTPSA id 5522517E0700; Fri, 31 Jul 2026 17:42:56 +0200 (CEST) From: Leandro Ribeiro To: dri-devel@lists.freedesktop.org Cc: airlied@gmail.com, broonie@kernel.org, daniels@collabora.com, jani.nikula@linux.intel.com, maarten.lankhorst@linux.intel.com, miguel.ojeda.sandonis@gmail.com, mripard@kernel.org, pekka.paalanen@collabora.com, simona@ffwll.ch, penguin-kernel@I-love.SAKURA.ne.jp, tytso@mit.edu, tzimmermann@suse.de, ville.syrjala@linux.intel.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/1] drm: use drm_warn() in validate_blend_mode_for_alpha_formats() Date: Fri, 31 Jul 2026 12:42:32 -0300 Message-ID: <20260731154232.37020-2-leandro.ribeiro@collabora.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260731154232.37020-1-leandro.ribeiro@collabora.com> References: <20260731154232.37020-1-leandro.ribeiro@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Commit 860e748bddcc ("drm: ensure blend mode supported if pixel format with alpha exposed") introduced a WARN() to let driver developers know that a previously valid behavior should now be changed. But WARN() should not be used for that, as it's a kernel warning report mechanism for conditions that are not expected to happen. It also produces a stack trace. Instead, a simple warning-level log message should have been used, as drivers were expected to trigger the condition. This is causing problems for fuzzers, as they may stop when encountering a "BUG:" or "WARNING:" in the logs. Replace WARN() with drm_warn() in this function, avoiding these issues. Fixes: 860e748bddcc ("drm: ensure blend mode supported if pixel format with alpha exposed") Signed-off-by: Leandro Ribeiro --- drivers/gpu/drm/drm_mode_config.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c index 3bcc7bf0900c..cff347c723ef 100644 --- a/drivers/gpu/drm/drm_mode_config.c +++ b/drivers/gpu/drm/drm_mode_config.c @@ -869,8 +869,9 @@ static void validate_blend_mode_for_alpha_formats(struct drm_plane *plane) for (i = 0; i < plane->format_count; i++) { fmt = drm_format_info(plane->format_types[i]); if (fmt->has_alpha) { - WARN(1, "[PLANE:%d:%s] pixel format with alpha exposed but blend mode not setup", - plane->base.id, plane->name); + drm_warn(plane->dev, + "[PLANE:%d:%s] pixel format with alpha exposed but blend mode not setup. Please fix.", + plane->base.id, plane->name); break; } } -- 2.55.0