From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2EAD42BEBB for ; Fri, 31 Jul 2026 14:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785507093; cv=none; b=b8of8rW7P008FH3rxIHzhmovEd8md7WhUFxK9/ULZ0jXTY5/iJPBidiOxEUMSbJv9sxStGnJHe/agAEr3xhZkli8ilNMdEQ/KZfk+Aj4bD9YJHf7OJyRizmx7l4LLRhgNQjUXvqQHoVjaPJcJogeNL1aIqg2nw+tKoUj1SZm0i0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785507093; c=relaxed/simple; bh=QcfhcVT4fLpsSWuVJhNof9PQqGw8NjXiFiCRLj17V/4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q1ZHLW4tDz4D5pwM04D3aVBh49jrnbfRnFqsSwpJQ6kAcjyX+4fA0fmMw0zHu+QwNdHUcy4y1uxvHEqtp+qRCrK+97iNq7gMq2GnICKH6k80dXHv1rhir11nKeVD1vITyZBed1rJHBH35cH7FPuBE5XKH8TGlUSA7HmRTmgiO5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A0pgXi2O; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A0pgXi2O" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47f7872abb6so756492f8f.3 for ; Fri, 31 Jul 2026 07:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785507090; x=1786111890; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Mutstjg8Bx5ogWkUe9a0r8ZjMMf7n8vHq8hP7WaWrX0=; b=A0pgXi2O5Q6Kd2Ym1GOv6fMbBmYylneE7uE++/Dd4NyyWVbppYtUE22X100fBpx4+I NLLs/65S3uAg+I+wU2jn07qq1Dgw+25BJ1aLMd0dfVFo4nIaDkg/qEYi3QSwRyRStOKj 675kcmBkqNWDc8OPrzXV/eJf3Um76PlMc09oAtDNa0s+EQGgq7dQ1Rj5V/adYHioNHTX me4zdFBHtgV4zvQb25z4+lUDn4QWPZobC2CZqHEySRW4H+v6SSeKbnXCUev6mzetvjOY vzJ7I68MGRfMx7r2LUsHLeqTIcpNTpalJw6k5WW6y8J2qk2dZdYPX7ReQxbze27QDMwG ogCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785507090; x=1786111890; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Mutstjg8Bx5ogWkUe9a0r8ZjMMf7n8vHq8hP7WaWrX0=; b=e94dmceLzKt8yoVvpwL6z93dzOoClWQtad7t1zlMpzjJXNIK7KFwJjQAyYIyrCA1FZ FWvIBJ287br+o7WdWhUo7o0Y9rxPmqgO4aIyPmvIZIJM6+6En8XMnJ3S2OAHqyhl2CH+ ktEpRxfgVai26G+IWQHG00QpsRDfbkbhcCUmjdVmM6AqL3MUPhXbrZqG53rg8xdcg4ya oJx3qXznh93UnK65ckFHxEp0AUdoj0wPz9vh8+dNzJzkXNs2MCSR6ZANXG7iseek6VMd tqPEXWxPpBs/5RKENHkoOuJMtiJanoa07QCfG/lMImdiExYKeAdTfVZRh/ytNVsdbuO9 gJeg== X-Forwarded-Encrypted: i=1; AHgh+Rq2pxNCr9UpmQyMJkllDvXa8PzUi5VTskvrzMBa8CLb3yxslc1KBKIwrCgFaRdVlfEhHN80BAITil+jKnU=@vger.kernel.org X-Gm-Message-State: AOJu0YxMYS0USa6FTf5MyltqhnHVKuCjXpU5Vbzkl9O6t6moMY+nuJvz JyWufdr5zySDn/hPvDbym7UkklqhkYqrluvf/xJBRChqLgfXwfeC9kUL X-Gm-Gg: AR+sD11WrjRZPlqtMwG40WBvDz4q5k1ToV84Cts9c7aH4STv+ObNsGPF17Q5V16Hv/D sthL6sYuLtdiuR79M2gx05uuD/PT2jIQ7nCd0fO7gnI1Wio0l+yVlYLsD/UuEiwdfFV/xUCboBQ 4/9lsZpnfHwjNXHf5pS4BxnsxtD+WVgE9khHgaYOCQe0pdv/+OMXu0l1YUYsaNkhbdSoEhQmHfl hU8+lLArXjIdF2XFKGti3KPYZ3wOpawvjCZJDB7gRuUk4x9xUTYkIAEAuUG1bXen4bZn0it4fK6 Koef1GolWgtsqrmXMW3zXSKR5TXObDyFWMHqiB+ggVPgZRY75T253Mzt/qNyMurBq5HPPWsY7BF yhwtRGRMKcdC7Jfl1JFWyjqgmqEgy6vztINFJFyL4OJwQKhTeEccK84jWWc1xeTxufrU6ZpXoGs GapFFKqvax0McMsYbMP5wDakeJDjUxBx7UVD11zetei4dORs7QUAxqft7sycW7svdbPkEzCIjBH wXrK31hFqnLBJuCb7frv+9PlK+BbxsVmJ/R56i1IruS8BQUSDZycKegKKjrpW/PtIIA3vNnf5Mr 83qviYR/x+I+5BMS6evLlIKEPVdetjuk+emPIhyYFOKtpzFhUy7oX7NB9lX6EAn/wyuKxCgZQXb ouyk87BW4af9Gy4lPWdQ2JwZTj33vibCu+T7hloW9lSREHQE2m/nW5ufEKSDUZ8U90v4FG2g= X-Received: by 2002:a05:6000:2408:b0:47f:8cf9:a12b with SMTP id ffacd0b85a97d-47fd2ab99ebmr5275934f8f.6.1785507089949; Fri, 31 Jul 2026 07:11:29 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd4068fb7sm6050421f8f.0.2026.07.31.07.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 07:11:29 -0700 (PDT) Date: Fri, 31 Jul 2026 16:11:27 +0200 From: Joshua Crofts To: Giorgi Tchankvetadze Cc: Kevin Tsai , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: Re: [PATCH] iio: light: cm32181: return zero after writing calibscale Message-ID: <20260731161127.00001478@gmail.com> In-Reply-To: <20260731132048.199946-2-giorgitchankvetadze1997@gmail.com> References: <20260731132048.199946-2-giorgitchankvetadze1997@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 31 Jul 2026 17:20:48 +0400 Giorgi Tchankvetadze wrote: > From: Giorgi Tchankvetadze > > The write_raw callback is documented to return 0 on success or a > negative error code. However, the IIO_CHAN_INFO_CALIBSCALE case > returns 'val' (the user-supplied value) instead of 0. > > Fix it by returning 0 on success, matching the behavior of other > calibscale implementations in the subsystem. > > Fixes: 971672c0b3cc ("iio: add Capella CM32181 ambient light sensor driver.") > Signed-off-by: Giorgi Tchankvetadze > --- LGTM. Reviewed-by: Joshua Crofts -- Kind regards, Joshua Crofts