From: Jakub Kicinski <kuba@kernel.org>
To: Tung Nguyen <tung.quang.nguyen@est.tech>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jmaloy@redhat.com, horms@kernel.org,
tipc-discussion@lists.sourceforge.net, Xiang Mei <xmei5@asu.edu>,
Weiming Shi <bestswngs@gmail.com>
Subject: Re: [PATCH net v9] tipc: fix NULL deref in tipc_named_node_up() on empty publication list
Date: Fri, 31 Jul 2026 17:56:50 -0700 [thread overview]
Message-ID: <20260731175650.0ed418f6@kernel.org> (raw)
In-Reply-To: <20260730083407.14915-1-tung.quang.nguyen@est.tech>
On Thu, 30 Jul 2026 15:34:01 +0700 Tung Nguyen wrote:
> + * tipc_named_node_up - tell specified node about all publications by this node
> + * @net: the associated network namespace
> + * @dnode: destination node
> + * @capabilities: peer node's capabilities
> + */
> +int tipc_named_node_up(struct net *net, u32 dnode, u16 capabilities)
Sorry to nit pick but for new code we ask that kdoc -Wall is clean
which requires Return: statements:
Warning: net/tipc/name_distr.c:151 No description found for return value of 'named_distribute'
Warning: net/tipc/name_distr.c:208 No description found for return value of 'tipc_named_distribute'
Warning: net/tipc/name_distr.c:237 No description found for return value of 'tipc_named_node_up'
Warning: net/tipc/name_distr.c:270 No description found for return value of 'tipc_named_dist_cluster_scope'
Warning: net/tipc/name_distr.c:151 No description found for return value of 'named_distribute'
Warning: net/tipc/name_distr.c:208 No description found for return value of 'tipc_named_distribute'
Warning: net/tipc/name_distr.c:237 No description found for return value of 'tipc_named_node_up'
Warning: net/tipc/name_distr.c:270 No description found for return value of 'tipc_named_dist_cluster_scope'
next prev parent reply other threads:[~2026-08-01 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 8:34 [PATCH net v9] tipc: fix NULL deref in tipc_named_node_up() on empty publication list Tung Nguyen
2026-08-01 0:56 ` Jakub Kicinski [this message]
2026-08-01 1:14 ` Tung Quang Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731175650.0ed418f6@kernel.org \
--to=kuba@kernel.org \
--cc=bestswngs@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jmaloy@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.quang.nguyen@est.tech \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.