From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B063EC55173 for ; Fri, 31 Jul 2026 21:38:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E6E510F42E; Fri, 31 Jul 2026 21:38:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="MwLJnJch"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CEEE10F42E for ; Fri, 31 Jul 2026 21:38:05 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A668B600C3; Fri, 31 Jul 2026 21:38:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39BEE1F00AC4; Fri, 31 Jul 2026 21:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785533884; bh=pQVaPapWUaZaFghZZ/wIC3/WkZNCuTqvqmWih0XT0xM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=MwLJnJchstBmgowcK60RbHLi3o+QmPhvbu2YVoukFzNLnZxWEEOcPIL/ZgpPFj8Su lSVy03xHI9507iJ81DI4m7CjUcyEsrYDI69WmfHhPtUjAvpMdLDfvQU7keC5reuiTz C64oc6pYQduKMY9NkSv2M3teiMiKVPCxLwLH5+nAqcWxwYZVyhm0y5cC6tzzRSPiW0 SsAZJrhUQXbTulv570bTYGcGp6ITERf4mhBZK5qcaA9kITdb/UOUknnQin9MnVuEzH Lp86Zq+nQ2kDbcok8gFTZAgTmfz0KLAmg7sh3epnpv1aAl7zCrzaOGx+MJaXvv8kQa CZysaDjwvobjQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 1/5] PCI/TPH: treat reserved 0b10 completer encoding as unsupported To: "Zhiping Zhang" Cc: dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org In-Reply-To: <20260731211601.3033906-2-zhipingz@meta.com> References: <20260731211601.3033906-1-zhipingz@meta.com> <20260731211601.3033906-2-zhipingz@meta.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 31 Jul 2026 21:38:03 +0000 Message-Id: <20260731213804.39BEE1F00AC4@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > get_rp_completer_type() returns the Root Port's "TPH Completer > Supported" field (bits 13:12 of Device Capabilities 2) verbatim. The > 0b10 encoding is reserved, but pcie_enable_tph() feeds the raw value > into the requester type: >=20 > pdev->tph_req_type =3D min(pdev->tph_req_type, rp_req_type); >=20 > and later writes tph_req_type to the TPH Requester Enable field, which > only defines 0b00 (disable), 0b01 (TPH only) and 0b11 (extended TPH). >=20 > No known hardware presents the reserved 0b10 in this field, so this is > defensive hardening rather than a fix for observed silicon: fold the > reserved encoding into "not supported" so only the three architected > values can ever reach the Requester Enable field. >=20 > Signed-off-by: Zhiping Zhang Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260731211601.3033= 906-1-zhipingz@meta.com?part=3D1