From: sashiko-bot@kernel.org
To: "Bart Van Assche" <bvanassche@acm.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v4 6/6] scsi: core: Enable lock context analysis
Date: Fri, 31 Jul 2026 22:05:46 +0000 [thread overview]
Message-ID: <20260731220546.9368C1F00ACA@smtp.kernel.org> (raw)
In-Reply-To: <377b28286cab215eea4e6f0f35ba5a9c4eff3455.1785534722.git.bvanassche@acm.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Makefile variables intended to enable lock context analysis are incorrectly named due to missing 'scsi_' prefixes, failing to enable analysis for most intended SCSI core files.
--
--- Patch [6]: [PATCH v4 6/6] scsi: core: Enable lock context analysis ---
commit 72acfbb8a25ff6235de3b56d2113eb7681fd8184
Author: Bart Van Assche <bvanassche@acm.org>
scsi: core: Enable lock context analysis
Enable lock context analysis for those SCSI core files that build
without triggering any compiler warnings.
> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
> index 842c254bb2269..69ea80819f3ba 100644
> --- a/drivers/scsi/Makefile
> +++ b/drivers/scsi/Makefile
> @@ -14,6 +14,28 @@
> # satisfy certain initialization assumptions in the SCSI layer.
> # *!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!*!
>
> +CONTEXT_ANALYSIS_constants.o := y
> +CONTEXT_ANALYSIS_scsi.o := y
> +CONTEXT_ANALYSIS_scsicam.o := y
> +CONTEXT_ANALYSIS_common.o := y
> +CONTEXT_ANALYSIS_devinfo.o := y
> +CONTEXT_ANALYSIS_dh.o := y
> +CONTEXT_ANALYSIS_ioctl.o := y
> +CONTEXT_ANALYSIS_lib.o := y
> +CONTEXT_ANALYSIS_lib_dma.o := y
> +CONTEXT_ANALYSIS_error.o := y
> +CONTEXT_ANALYSIS_logging.o := y
> +CONTEXT_ANALYSIS_netlink.o := y
> +CONTEXT_ANALYSIS_pm.o := y
> +CONTEXT_ANALYSIS_scan.o := y
> +CONTEXT_ANALYSIS_sysfs.o := y
> +CONTEXT_ANALYSIS_trace.o := y
> +CONTEXT_ANALYSIS_sd.o := y
> +CONTEXT_ANALYSIS_sd_dif.o := y
> +CONTEXT_ANALYSIS_sd_zbc.o := y
> +CONTEXT_ANALYSIS_sr.o := y
> +CONTEXT_ANALYSIS_sr_ioctl.o := y
> +CONTEXT_ANALYSIS_proc.o := y
[Severity: Medium]
Do these Makefile variables need a "scsi_" prefix to match the actual
object files?
For example, drivers/scsi/scsi_ioctl.c generates scsi_ioctl.o, so Kbuild
expects CONTEXT_ANALYSIS_scsi_ioctl.o := y.
Since the target stems do not match the variables (like common, devinfo, dh,
ioctl, lib, lib_dma, error, logging, netlink, pm, scan, sysfs, trace, and
proc), Kbuild will silently ignore them and lock context analysis will not
be enabled for these files.
--
Sashiko AI review · https://sashiko.dev/#/patchset/68f3346cab2be570839350831f82b6c9233832ed.1785534721.git.bvanassche@acm.org?part=6
prev parent reply other threads:[~2026-07-31 22:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 21:52 [PATCH v4 0/6] Enable lock context analysis in the SCSI core and UFS driver Bart Van Assche
2026-07-31 21:52 ` [PATCH v4 1/6] ufs: core: Set task state before io_schedule_timeout() Bart Van Assche
2026-07-31 21:52 ` [PATCH v4 2/6] ufs: core: Enable lock context analysis Bart Van Assche
2026-07-31 21:52 ` [PATCH v4 3/6] scsi: core: Pass the SCSI host pointer directly Bart Van Assche
2026-07-31 21:52 ` [PATCH v4 4/6] scsi: core: Add lock context annotations Bart Van Assche
2026-07-31 22:07 ` sashiko-bot
2026-07-31 21:52 ` [PATCH v4 5/6] scsi: core: Protect host state changes with the host lock Bart Van Assche
2026-07-31 22:05 ` sashiko-bot
2026-07-31 21:52 ` [PATCH v4 6/6] scsi: core: Enable lock context analysis Bart Van Assche
2026-07-31 22:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731220546.9368C1F00ACA@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.