Re: [PATCH RESEND v1] vxcan: Support per-netns device unregistration.

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch calls a non-existent function `unregister_netdevice_queue_net()`, causing a build failure.
--

--- Patch [1]: [PATCH RESEND v1] vxcan: Support per-netns device unregistration. ---
commit aa743c4ffeab7ce1e07d36aa7e401187541f6f4f
Author: Kuniyuki Iwashima <kuniyu@google.com>

vxcan: Support per-netns device unregistration.

This commit modifies vxcan_dellink() to support concurrent per-netns device
unregistration by using xchg() to ensure each device is queued for
destruction only once. It drops the synchronous RTNL assumption for deleting
both the local and peer devices.

> diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c
> index e882250180ef6..b7efed1226d88 100644
> --- a/drivers/net/can/vxcan.c
> +++ b/drivers/net/can/vxcan.c
[ ... ]
> @@ -281,24 +284,25 @@ static int vxcan_newlink(struct net_device *dev,
>  
>  static void vxcan_dellink(struct net_device *dev, struct list_head *head)
>  {
[ ... ]
> -	if (peer) {
> -		priv = netdev_priv(peer);
> -		RCU_INIT_POINTER(priv->peer, NULL);
> -		unregister_netdevice_queue(peer, head);
> -	}
> +	priv = netdev_priv(peer);
> +	dev = unrcu_pointer(xchg(&priv->peer, NULL));
> +	if (dev)
> +		unregister_netdevice_queue_net(dev_net(dev), peer, head);

[Severity: Low]
Does unregister_netdevice_queue_net() exist in the source tree? It appears
this will cause a build failure due to an undefined function reference when
the driver is compiled.

> +
> +	netdev_put(peer, peer_tracker);
> +	netdev_put(dev, &priv->peer_tracker);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731231755.2474376-1-kuniyu@google.com?part=1