From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EB043E51C8 for ; Fri, 31 Jul 2026 12:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785500769; cv=none; b=Qom0o0lKIOeX4QxVvTbOzI9gUGugY+Cyk5nSV755OeCuQmqf+/2awf82w2Tv+Se6uOTIsKs/335OC4ugX4s2k63EcVypBelwgEubAbP4si1JUOUI5Q6kwyPyjRfbAatGD3U2uasUG+LnqpUmtrAo3h57EI3RLepPlHzYyca4wWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785500769; c=relaxed/simple; bh=wiuwdDujyKDBXY13LH7cJIwqFVrjRZZ0DzOD9zYOrno=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I9DV8baFJpLWdJTnRx0ILn9U3i6YzIE/vBNUBKsFg6V8n6YFvCrNieDNZZO3smcDeK/0Dcg2pdjjKnY+4Mkm6OX7fsDhjKptLBID2OGINSPnpD6vI92O/PCXhpl+DaOZdlHpIw954R60NwFFWCggoZNPnkujUqB2QQvkAIiC3Rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xiAnbb1A; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xiAnbb1A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B3081F000E9; Fri, 31 Jul 2026 12:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785500768; bh=06oX6uealxQ15xunGM0r5p5AdJU1+SRvgsqv9zJQOMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=xiAnbb1AtFR2A4ezAQETNOwYkuqV4LyflfMJREtCcyUmAT9jutyCBmuj5TaJtpp99 0F9yTGMgnRKhsvotu+glcMajyNdtHFqfETXso+R75MNKEZw6evCRaXkII8rL7KcXs+ sDBAOzVMNIJ54gpjO0TD0QyFMuH2+E5bUOe84IwQ= Date: Fri, 31 Jul 2026 14:25:52 +0200 From: Greg KH To: Eli Billauer Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, corbet@lwn.net Subject: Re: [PATCH v3 2/7] char: xillybus: Remove duplicate error path code Message-ID: <2026073157-wasp-amid-2729@gregkh> References: <20260724094302.50761-1-eli.billauer@gmail.com> <20260724094302.50761-3-eli.billauer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260724094302.50761-3-eli.billauer@gmail.com> On Fri, Jul 24, 2026 at 11:42:57AM +0200, Eli Billauer wrote: > No need for dedicated code for the error path. The removed dedicated > error path code differs only in when the mutex is released, and that > makes no difference in this context. > > Assisted-by: Deepseek:v4-pro Kimi:K2.6 ChatGPT:GPT-5.5 Claude:Sonnet-4.6 > Signed-off-by: Eli Billauer > --- > > Notes: > Changes v2->v3: > -- Add Assisted-by tag to description > > No change on v1->v2. > > drivers/char/xillybus/xillyusb.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/char/xillybus/xillyusb.c b/drivers/char/xillybus/xillyusb.c > index a28e6416cb01..ab5f9159aa17 100644 > --- a/drivers/char/xillybus/xillyusb.c > +++ b/drivers/char/xillybus/xillyusb.c > @@ -1419,16 +1419,12 @@ static int xillyusb_open(struct inode *inode, struct file *filp) > if (filp->f_mode & FMODE_WRITE) > chan->open_for_write = 0; > > +unmutex_fail: > mutex_unlock(&chan->lock); > > kref_put(&xdev->kref, cleanup_dev); > > return rc; > - > -unmutex_fail: > - kref_put(&xdev->kref, cleanup_dev); > - mutex_unlock(&chan->lock); > - return rc; > } > > static ssize_t xillyusb_read(struct file *filp, char __user *userbuf, > -- > 2.34.1 > Again, some sashiko comments seem like this might not be the correct changelog text: https://sashiko.dev/#/patchset/20260724094302.50761-1-eli.billauer@gmail.com Can you verify that the other comments in that review for this series isn't also valid (or not?) thanks, greg k-h