From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2DE5374E40 for ; Sat, 1 Aug 2026 06:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785567440; cv=none; b=jiOFGDulMq9UkqxqZspQBcs49Q1jUSkG4uji41yI7O+Wi8eEkwMR+Y8qBDMtTZpuX1d1nb++Z7lFj3SjLUb3qAbfhpaMzahMoBXsvlm5FmtuwDDuvzba3YrlmDmIKNIs01MBvmXPWAiktvUQOgzD4M9q8jbdJcmsRWUoKf/6Nk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785567440; c=relaxed/simple; bh=J6l//22lfe6VaitbfG5t+W+LsoGh3SZrvhf291APJJs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=EP4WmdxVSdze8pni5DIremsw2NkWXmwCdAwjPQa3kDDCSkVeYH3KrM3Y+b8NyWbWSpKUoOYatRyjWlzMm/FPOzx5waazo03KlAo1g870OvSws1TOAA5VWM/74uYM374fh62Pok0UknvVLUHaEN6d9YaJhxi3ApLczgt1xaHiywA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g/WxoIMm; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g/WxoIMm" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cc891373e0so18389765ad.2 for ; Fri, 31 Jul 2026 23:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785567438; x=1786172238; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=eX0Ogtu+yr7SwyEN2U3st9d3s1j8WEIsbSfxpUKZtik=; b=g/WxoIMmnPT3LgszSVvVkz+8bIbTI2mO7V58oWKbh3Q3ziyhSU5uVYDLXlaX2Po0Fs YcM5o5K0IB/4q6L0ayPt5MWAtiXJxp7J9/Qr9MZEpq/WZEIh0ZtNdqh7ODfiYCFi7Fsl t3JBNqtqww7UZzRYQF5orMPHQGbLCgg245dLR+UNcvnu3kr7K8lfrqxXkW9SZAdXqTMg VSy6N9rG79osR2a7EtcTvcX7eEE8+W6CnrRtOMGj/0Xek2PfBCaJFboF0BRdzaqYyyj5 /tp0Rf0KCn+J+yq6RD0b0e8Mp5FQaFOR5z3c7EEEl9jpMEeN3UWYHF9FKaJdwOCBVTTN 5z7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785567438; x=1786172238; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eX0Ogtu+yr7SwyEN2U3st9d3s1j8WEIsbSfxpUKZtik=; b=jahsRf3OTh8NNKVzIr3Ma+QPZecAYscri5Nd4JegIDkWk0GApHjlv1lzULQ1uStcGE 8HSJnDeaTzrKqBIaeP7FNwhPHFBrZX0Z2oMvoA0JgW8BPzsqDNMi4qPi9yQWPu+n0Hrw e1mOcFUfz9PjK1PcXqLr2cHZIRHrGg6OEQti4BlHpIFtCFe2v8ycahg5pq7qgR8VpFMn vmNzobcQYvpxpJnb++AlSRU9X30rENxsulY0NZTK+8i66Jma9wyacDlJiSCnKtkYBez7 l/W3TrzXC2UORwymBPNMtpSk7S39/Uz+JikCvJK4jE4mbjy3GwUk+Xr+LHN4NngNXoQ+ EV+g== X-Forwarded-Encrypted: i=1; AHgh+RpF3pQQhpR0U5QUZ1H58G7GEpp7g8D367L4jLJgAPKqpreKv4MdvAGqQ8R0ILGJ9gfGmdUsDTprKFFbY6w=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk4RheoKxahpABpI7xLqX+2Lkz5CLiB99vDj1qbWKH+TitJ04z sYCK7TI/SvX4zjMOykVQ5YLreMmXh/QQqdC1etwcF7bXOka4KaOluHR6 X-Gm-Gg: AR+sD11Ld8hOUtEI4T7cW3WGf2HhEWMztuv4lK3M6kHCUJtplrvzhZVWDc40xnCLHfP fVcxY/Nkdh/gQ/5SrO4UYKZ7wEexsIRWL26Qzf4KyACtfopkg+mpvrthWJSk+gRW7fm9Gh91joO O+c2SWF0GE7NuHLzsKLwnvLPA2d3uspUXCK3jb14N3G9PjG6q4GHuL1Rjl+lNhAVElSI90Vhn0z cSO38cpgSFCZDpWpRM6SCJ2Vode6Uu/l7EOsBlB7erN6INyMJJ1PiZZ8ghnJ7A/8N+9HF49MyDa UnqrvbqMWhJOXJTxMANNnCfngix4m6aAJ0NZzegUJSJ0EBrKAqyeMKu6fipwdRO0XbKEIVxovG4 euGTDKjBJmZPV0q6ejRsscmTrVSvJVPEC7ZREwlFUIoZjVP2/BLGwT6mHUra052+MjQ++eljxGu q3i3NLNrz9B667TSUrvMtpUNSKyMaxzbhAUoIAefntZ9Axbre0vUuBOG42sXa1SDNVjC4pU543V G6MGzD/fDfxGWu79hHAqgyk2mw= X-Received: by 2002:a17:902:c40b:b0:2cc:f7c6:8353 with SMTP id d9443c01a7336-2d052437b14mr24479315ad.41.1785567438061; Fri, 31 Jul 2026 23:57:18 -0700 (PDT) Received: from localhost.localdomain ([152.59.182.249]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd4e666sm19494177eec.4.2026.07.31.23.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 23:57:17 -0700 (PDT) From: Krishan Singh To: linux@armlinux.org.uk Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krishan Singh Subject: [PATCH] net: sfp: fix hwmon_name leak on hwmon registration failure Date: Sat, 1 Aug 2026 12:27:03 +0530 Message-Id: <20260801065703.43896-1-krishanmohan298@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When hwmon_device_register_with_info() fails in sfp_hwmon_probe(), the string allocated by hwmon_sanitize_name() is not freed, leaking memory on repeated hotplug/probe attempts. Also, sfp_hwmon_remove() only freed hwmon_name inside the IS_ERR_OR_NULL(hwmon_dev) block, so a partial-init failure could leave the name allocation behind. Fix by freeing hwmon_name and clearing both pointers on registration failure, and by freeing hwmon_name unconditionally in remove while still only unregistering hwmon_dev when it is valid. Fixes: 3f118c449c8e ("net: sfp: use hwmon_sanitize_name()") Signed-off-by: Krishan Singh --- drivers/net/phy/sfp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index f52020673..f605fb399 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1895,9 +1895,13 @@ static void sfp_hwmon_probe(struct work_struct *work) sfp->hwmon_name, sfp, &sfp_hwmon_chip_info, NULL); - if (IS_ERR(sfp->hwmon_dev)) + if (IS_ERR(sfp->hwmon_dev)) { dev_err(sfp->dev, "failed to register hwmon device: %ld\n", PTR_ERR(sfp->hwmon_dev)); + kfree(sfp->hwmon_name); + sfp->hwmon_name = NULL; + sfp->hwmon_dev = NULL; + } } static int sfp_hwmon_insert(struct sfp *sfp) -- 2.34.1