From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3EE1C54FCD for ; Sat, 1 Aug 2026 08:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XNgyD4SOWKFNe9Izm+Nzxp4NQgOd4T3wYTp8t2mLDNM=; b=efI2i7f59fVpI0T9Qp0D9+YJ3x Ze0hQPr6EgCAKCfigREoahG/Ckbllm5fGyKguYDwXWAnImeeE6mRNRYTFqHZtmphgHrVktZw2z4ni QZPfKGzcEka9XsypNntKCxKWWRbKqJRHTxKiFM7XsjOaO6+/dtbjLOA5XaPLr0GEVL4/yxF659qqv Al3XNE8wDascG7a/X2HimQEvM6sHZmmE8KJilCmavOqcGuV3Q2xRGR8YU7ByGTThqUB+nWnmDQCJU 7C9NE0ypqsIifrZPa7AU6xG15bbpZlkxHwi2az2Z6Mxt+UKSQcKiCKSYUmwD0N/fRZ2pAlUawZ/3h 5Zm1STLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wq5PI-0000000E4m5-0ATa; Sat, 01 Aug 2026 08:49:24 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wq5PG-0000000E4lW-0IgX for kexec@lists.infradead.org; Sat, 01 Aug 2026 08:49:22 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id CC4AE452B5; Sat, 1 Aug 2026 08:49:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CC5D1F00ACF; Sat, 1 Aug 2026 08:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785574149; bh=XNgyD4SOWKFNe9Izm+Nzxp4NQgOd4T3wYTp8t2mLDNM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lIthDNSy0aXfb6XajVGZ/pNVTaDscF9eSGuWw+2YxyfporzOSHAp+NcDsWeWQQsMV vS0sqCTwPq1zJ7Wsj0UTGoPecmOVIqAd1ZQyjs83LAiy/rldf3nIgkwEwkvJ2+TygU EsvGeR+Hzt16AO7rAyyOJHe4P7VoIOYXVqnonOpYKBwEy65Wq7LA4WGiARaz1ALjp3 AgP96sGbaSobbJiwIGvFcIrTKvBRUW86MdBKs+JjJF/UCpRVyIzyepVhm/RFeu5xQq 1kFeFANT6mc/brEa6Z4RuX4+oD3D38OXABBZPSUy33vvo09bnfqNsyRaNixcLkotmx fuLUQSdl4heFw== From: Pratyush Yadav To: Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , Jork Loeser Cc: kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 07/22] kho: add a struct for radix callbacks Date: Sat, 1 Aug 2026 10:48:16 +0200 Message-ID: <20260801084833.1897543-8-pratyush@kernel.org> X-Mailer: git-send-email 2.55.0.571.g244d577d93-goog In-Reply-To: <20260801084833.1897543-1-pratyush@kernel.org> References: <20260801084833.1897543-1-pratyush@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org From: "Pratyush Yadav (Google)" A future commit will add more callbacks for the KHO radix tree. Add a struct for collecting the callbacks. Signed-off-by: Pratyush Yadav (Google) --- include/linux/kho_radix_tree.h | 15 ++++++++++++--- kernel/liveupdate/kexec_handover.c | 27 +++++++++++++++------------ 2 files changed, 27 insertions(+), 15 deletions(-) diff --git a/include/linux/kho_radix_tree.h b/include/linux/kho_radix_tree.h index 9157fe08f9ce..486e193d58f4 100644 --- a/include/linux/kho_radix_tree.h +++ b/include/linux/kho_radix_tree.h @@ -38,14 +38,23 @@ struct kho_radix_tree { struct mutex lock; /* protects the tree's structure and root pointer */ }; -typedef int (*kho_radix_tree_walk_callback_t)(unsigned long key); +/** + * struct kho_radix_walk_cb - Callbacks for KHO radix tree walk. + * @leaf: Called on each present key in the radix tree. + * + * For each callback, a return value of 0 continues the walk and a non-zero + * return value is directly returned to the caller. + */ +struct kho_radix_walk_cb { + int (*leaf)(unsigned long key); +}; #ifdef CONFIG_KEXEC_HANDOVER int kho_radix_add_key(struct kho_radix_tree *tree, unsigned long key); void kho_radix_del_key(struct kho_radix_tree *tree, unsigned long key); int kho_radix_walk_tree(struct kho_radix_tree *tree, - kho_radix_tree_walk_callback_t cb); + const struct kho_radix_walk_cb *cb); #else /* #ifdef CONFIG_KEXEC_HANDOVER */ @@ -58,7 +67,7 @@ static inline void kho_radix_del_key(struct kho_radix_tree *tree, unsigned long key) { } static inline int kho_radix_walk_tree(struct kho_radix_tree *tree, - kho_radix_tree_walk_callback_t cb) + const struct kho_radix_walk_cb *cb) { return -EOPNOTSUPP; } diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c index e3408e1844dc..9fb07c0ef18e 100644 --- a/kernel/liveupdate/kexec_handover.c +++ b/kernel/liveupdate/kexec_handover.c @@ -281,16 +281,18 @@ void kho_radix_del_key(struct kho_radix_tree *tree, unsigned long key) } EXPORT_SYMBOL_GPL(kho_radix_del_key); -static int kho_radix_walk_leaf(struct kho_radix_leaf *leaf, - unsigned long key, - kho_radix_tree_walk_callback_t cb) +static int kho_radix_walk_leaf(struct kho_radix_leaf *leaf, unsigned long key, + const struct kho_radix_walk_cb *cb) { unsigned long *bitmap = (unsigned long *)leaf; unsigned int i; int err; + if (!cb->leaf) + return 0; + for_each_set_bit(i, bitmap, PAGE_SIZE * BITS_PER_BYTE) { - err = cb(key | i); + err = cb->leaf(key | i); if (err) return err; } @@ -300,7 +302,7 @@ static int kho_radix_walk_leaf(struct kho_radix_leaf *leaf, static int __kho_radix_walk_tree(struct kho_radix_node *root, unsigned int level, unsigned long start, - kho_radix_tree_walk_callback_t cb) + const struct kho_radix_walk_cb *cb) { struct kho_radix_node *node; struct kho_radix_leaf *leaf; @@ -340,18 +342,16 @@ static int __kho_radix_walk_tree(struct kho_radix_node *root, /** * kho_radix_walk_tree - Traverses the radix tree and calls a callback for each key. * @tree: A pointer to the KHO radix tree to walk. - * @cb: A callback function of type kho_radix_tree_walk_callback_t that will be - * invoked for each key in the tree. + * @cb: Set of callbacks to be invoked during the tree walk. * - * This function walks the radix tree, searching from the specified top level - * down to the lowest level (level 0). For each key found, it invokes the - * provided callback. + * This function walks the radix tree, searching from the top level down to the + * lowest level (level 0), invoking the appropriate callbacks. * * Return: 0 if the walk completed the specified tree, or the non-zero return * value from the callback that stopped the walk. */ int kho_radix_walk_tree(struct kho_radix_tree *tree, - kho_radix_tree_walk_callback_t cb) + const struct kho_radix_walk_cb *cb) { if (WARN_ON_ONCE(!tree->root)) return -EINVAL; @@ -1417,6 +1417,9 @@ EXPORT_SYMBOL_GPL(kho_retrieve_subtree); static void __init kho_mem_retrieve(void) { + const struct kho_radix_walk_cb cb = { + .leaf = kho_preserved_memory_reserve, + }; const void *fdt = kho_get_fdt(); int err; @@ -1430,7 +1433,7 @@ static void __init kho_mem_retrieve(void) kho_in.radix_tree.root = kho_get_mem_map(fdt); mutex_init(&kho_in.radix_tree.lock); - err = kho_radix_walk_tree(&kho_in.radix_tree, kho_preserved_memory_reserve); + err = kho_radix_walk_tree(&kho_in.radix_tree, &cb); if (err) { /* * Failed to initialize preserved memory. Clear FDT and radix -- 2.55.0.571.g244d577d93-goog