From: mdshahid03@gmail.com
To: Jonathan Cameron <jic23@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Joshua Crofts" <joshua.crofts@broadcom.com>,
"Broadcom internal kernel list"
<bcm-kernel-feedback-list@broadcom.com>,
"David Lechner" <dlechner@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Mohammad Shahid" <mdshahid03@gmail.com>
Subject: [PATCH v4 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages
Date: Sat, 1 Aug 2026 14:39:51 +0530 [thread overview]
Message-ID: <20260801090953.61603-2-mdshahid03@gmail.com> (raw)
In-Reply-To: <20260801090953.61603-1-mdshahid03@gmail.com>
From: Mohammad Shahid <mdshahid03@gmail.com>
devm_request_threaded_irq() already logs an error when the request
fails, making the explicit dev_err() redundant.
Similarly, iproc_adc_enable() already reports failures, making the
additional dev_err() in the probe path redundant.
Remove both duplicate messages.
Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
---
drivers/iio/adc/bcm_iproc_adc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index cf4738b16e62..7c2e2770cd61 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
iproc_adc_interrupt_handler,
iproc_adc_interrupt_thread,
IRQF_SHARED, "iproc-adc", indio_dev);
- if (ret) {
- dev_err(&pdev->dev, "request_irq error %d\n", ret);
+ if (ret)
return ret;
- }
ret = clk_prepare_enable(adc_priv->adc_clk);
if (ret) {
@@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
}
ret = iproc_adc_enable(indio_dev);
- if (ret) {
- dev_err(&pdev->dev, "failed to enable adc %d\n", ret);
+ if (ret)
goto err_adc_enable;
- }
indio_dev->name = "iproc-static-adc";
indio_dev->info = &iproc_adc_iio_info;
--
2.43.0
next prev parent reply other threads:[~2026-08-01 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 9:09 [PATCH v4 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling mdshahid03
2026-08-01 9:09 ` mdshahid03 [this message]
2026-08-03 12:19 ` [PATCH v4 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages Joshua Crofts
2026-08-01 9:09 ` [PATCH v4 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer mdshahid03
2026-08-01 14:49 ` David Lechner
2026-08-03 12:44 ` Markus Elfring
2026-08-01 9:09 ` [PATCH v4 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() mdshahid03
2026-08-01 14:51 ` David Lechner
2026-08-03 13:01 ` Markus Elfring
2026-08-02 2:06 ` [PATCH v4 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801090953.61603-2-mdshahid03@gmail.com \
--to=mdshahid03@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.