From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B451361979 for ; Sat, 1 Aug 2026 09:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575441; cv=none; b=OLCivs3OPrVN+2e0LkI6ZnZvov4Fo/YTC0rTxILX9KZnZRTV56jo4snKU49RHY+x9ULodND/8dHufpYLI4322olHRo7iw9FGCFxq+qEXlnqWHn2wjVO3I2s4v9KtAT+8Fe+XtTH0mFl15OK1X7mWRlY/AdMRjvCYDGNYG+X7CPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785575441; c=relaxed/simple; bh=mBvzCrJqfjVnlWATRpHn3lgMmeSiDO2rsv8lorvrc+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G9xNlyMc9QMIo8904pmoAGmVUO5cMP1h4ERgQ6bsTHsd1qCBgt2OSEv8CQIlYuhxe9/Tlt25fFeiAV/19JsX1NJFpIjTF3u/N394F10hEeDkyqvxsuWqQRf7Pb6Co49jAcUPDynPzdBHIU24f9VKjH0Xm4HIoNg5NQzL2QdzVAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P0IlD/dK; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P0IlD/dK" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ca80d708489so1084949a12.1 for ; Sat, 01 Aug 2026 02:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785575439; x=1786180239; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4sMBazdEJYTe6pzd45qpWokzuIgSbldBJhe0jeEanG8=; b=P0IlD/dKxh2lhAKurckYAbamScw/wmAZLullJmvdvcb7MNwnjHkPKjzWtib1i/O1gI zZzp6egVFVuthBai63Yw86suRyd2oD//0LxZR1UHc9VBgvF5KAHgYVHw5mFjx7mt3RcU 81XfOQkI03iSjCk4acXSEwIUlqjOQr/HsSllC55HWKZEWb6Wkmmi+C9HXPckcjsIyJQz T6zvqAxXhMwHLOaXBjcYB7MLYi1DugrkP6s3YGAHZfzP/rdnr0OLERfweC20F905nitT VB72sphDEKluD9zpyqYjvzNhHvmOqWFsfqfeaUBlRELH1XnWbmk9s8RAP0O1P6lxSQOg /O+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785575439; x=1786180239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4sMBazdEJYTe6pzd45qpWokzuIgSbldBJhe0jeEanG8=; b=Lo6mDoX1CQtsGah2SS/Tgeg5NI5R8Nx3OsuDhnq2P6V5F1f/KJj3W2ghDsQmGhsi2V VCI2XulAAyDC+fln3bE4hdhrJpuYgLmU1AcHpfgRI16nuTgXB7B7PLJzVAlrxhbflTsR D0wBFzhXD0CwSRubkkNdWAfx53/a09LmlTjqMXDO/wc7LYYT+oK3T6CpHXti2+5YEgo4 heaJ4ezZAS3WYMyhlDMhyhe6Iyc4eealrQLaTuJ0gTBXPxhudCuEo6oGkQ8XaaDyT6KC UaeQdWqzAqbWSUB0qLubK+hVnvgK4WfY3aMnOwvxHj0trvKiQ3icCZMpkjV66D295URn 5A/w== X-Forwarded-Encrypted: i=1; AHgh+RoZNFsC402LlehoMYUsAPFYZc9LdfMmhWOoIoImRZODEg5ry02T2OE9hBKn0L/+dciPN4BtxoOZsopxKzo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz2NSccpCz0HVFyREweVVP+Lgx0sy+msQKIIAT2wOuKjL21QCe vCVoJRMhjEMW0WeR5w6KjTbn97TiWiEoyUOjb7rmH3Osdy665n32YSNh X-Gm-Gg: AR+sD13YC2C7s5SyvgASoRkFroVaXcGFubBmrDWlaU05SzmXzXlThExVkjjdKnijZOm 2vghUeMFJnWnA7VXW6P759LrcqUHDuKwzn+NT8LwQ+oBqggpsWWz14OeDwV//HyVuNwhfRG6Cnu RGqm2ae3E3pVBvLiFB+8r2L9XgvRCulY8iFCy2uKuvH1dtrkx+Rk1kadU2IV/fdAnm8XukRAYG9 Y+RvIDRaIXhjg6ckRb2xhJc1P9FFtJD8dsyzqQ6JmexMbPP7DYEgXIdkp2NWSlzeZJmf/bNj6s6 5ypvaIGuTFkIQNIaFYLR1XFwUgfg/72bW6DWfph9bXhZY2dpel0eQ9li1Levuwf99WUZy/cDIr1 Y8CJbTAgdgXizxqq0EprVqmiY4KQza6RfAE9PAixvhVbrVGKhDT52betgSAQ1fUWCbfRc83+3iD H4As4EjZJxKdXg57twdjb6zc9H6Ipj9xVpHnFtS/JyVcck26HU9rckagJS/w== X-Received: by 2002:a05:6a21:e598:b0:3c6:6f25:594 with SMTP id adf61e73a8af0-3c91aa0a4f5mr5101134637.38.1785575439377; Sat, 01 Aug 2026 02:10:39 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:36ae:7de2:5cca:938]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c96asm15432431eec.7.2026.08.01.02.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 02:10:38 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v4 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer Date: Sat, 1 Aug 2026 14:39:52 +0530 Message-ID: <20260801090953.61603-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260801090953.61603-1-mdshahid03@gmail.com> References: <20260801090953.61603-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid Introduce a local 'struct device *dev' variable in iproc_adc_probe() and use it instead of repeatedly referencing '&pdev->dev'. This simplifies the code and makes subsequent error handling changes less verbose. No functional change intended. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index 7c2e2770cd61..4acd9c3f089b 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -506,9 +506,10 @@ static int iproc_adc_probe(struct platform_device *pdev) { struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev = NULL; + struct device *dev = &pdev->dev; int ret; - indio_dev = devm_iio_device_alloc(&pdev->dev, + indio_dev = devm_iio_device_alloc(dev, sizeof(*adc_priv)); if (!indio_dev) return -ENOMEM; @@ -523,14 +524,14 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); + dev_err(dev, "failed to get handle for tsc syscon\n"); ret = PTR_ERR(adc_priv->regmap); return ret; } - adc_priv->adc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); + adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, + dev_err(dev, "failed getting clock tsc_clk\n"); ret = PTR_ERR(adc_priv->adc_clk); return ret; @@ -543,11 +544,11 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); + dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); return ret; } - ret = devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, + ret = devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); @@ -556,7 +557,7 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = clk_prepare_enable(adc_priv->adc_clk); if (ret) { - dev_err(&pdev->dev, + dev_err(dev, "clk_prepare_enable failed %d\n", ret); return ret; } @@ -573,7 +574,7 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = iio_device_register(indio_dev); if (ret) { - dev_err(&pdev->dev, "iio_device_register failed:err %d\n", ret); + dev_err(dev, "iio_device_register failed:err %d\n", ret); goto err_clk; } -- 2.43.0