From: sashiko-bot@kernel.org
To: "Taniya Das" <taniya.das@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 3/6] dt-bindings: clock: qcom: Add video clock controller on Nord SoC
Date: Sat, 01 Aug 2026 14:21:52 +0000 [thread overview]
Message-ID: <20260801142152.AD6021F00AC4@smtp.kernel.org> (raw)
In-Reply-To: <20260801-nord_videocc_camcc-v2-3-674d7718e41f@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch references a missing header file `include/dt-bindings/clock/qcom,nord-videocc.h` in the device tree binding, but fails to include the file in the commit or patch series.
--
--- Patch [3]: [PATCH v2 3/6] dt-bindings: clock: qcom: Add video clock controller on Nord SoC ---
commit f2d65d3dfab04afd16d30573dc1a05f462740b53
Author: Taniya Das <taniya.das@oss.qualcomm.com>
dt-bindings: clock: qcom: Add video clock controller on Nord SoC
This commit adds the compatible string and bindings for the Nord video clock
controller.
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index 1e1fec1cd7ce9..65620a656600f 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> @@ -18,6 +18,7 @@ description: |
> include/dt-bindings/clock/qcom,glymur-videocc.h
> include/dt-bindings/clock/qcom,hawi-videocc.h
> include/dt-bindings/clock/qcom,kaanapali-videocc.h
> + include/dt-bindings/clock/qcom,nord-videocc.h
[Severity: Medium]
Is this patch missing the header file it references? The newly added device
tree binding references include/dt-bindings/clock/qcom,nord-videocc.h, but
the file is missing from the commit.
Any future device tree source or clock driver attempting to use the
qcom,nord-videocc binding will fail to compile due to the missing macro
definitions.
> include/dt-bindings/clock/qcom,sm8450-videocc.h
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260801-nord_videocc_camcc-v2-0-674d7718e41f@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-08-01 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 14:13 [PATCH v2 0/6] clk: qcom: Add video and camera clock controller support for Nord Taniya Das
2026-08-01 14:13 ` [PATCH v2 1/6] dt-bindings: clock: qcom: Add GCC video axi reset clocks " Taniya Das
2026-08-01 14:20 ` sashiko-bot
2026-08-01 14:13 ` [PATCH v2 2/6] clk: qcom: nwgcc-nord: Add video axi clock resets " Taniya Das
2026-08-01 14:13 ` [PATCH v2 3/6] dt-bindings: clock: qcom: Add video clock controller on Nord SoC Taniya Das
2026-08-01 14:21 ` sashiko-bot [this message]
2026-08-01 14:13 ` [PATCH v2 4/6] dt-bindings: clock: qcom: Add support for Camera Clock Controller for Nord Taniya Das
2026-08-01 14:13 ` [PATCH v2 5/6] clk: qcom: videocc-glymur: Add video clock controller support " Taniya Das
2026-08-01 14:13 ` [PATCH v2 6/6] clk: qcom: camcc: Add support for camera clock controller " Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801142152.AD6021F00AC4@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.