From: Felix Fietkau <nbd@nbd.name>
To: linux-wireless@vger.kernel.org
Subject: [PATCH 03/10] wifi: mt76: mt7996: handle UNI PS sync events
Date: Sat, 1 Aug 2026 14:53:27 +0000 [thread overview]
Message-ID: <20260801145334.1166751-3-nbd@nbd.name> (raw)
In-Reply-To: <20260801145334.1166751-1-nbd@nbd.name>
Enable MT_DRV_HW_PS_BUFFERING and handle MCU_UNI_EVENT_PS_SYNC with
all three TLV formats (single client, multi-client packed entries,
and bitmap).
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
.../net/wireless/mediatek/mt76/mt7996/mcu.c | 86 +++++++++++++++++++
.../net/wireless/mediatek/mt76/mt7996/mcu.h | 33 +++++++
.../net/wireless/mediatek/mt76/mt7996/mmio.c | 3 +-
3 files changed, 121 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
index 8aab91810135..cd7587ce5b8a 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
@@ -826,6 +826,89 @@ mt7996_mcu_wed_rro_event(struct mt7996_dev *dev, struct sk_buff *skb)
}
}
+static void
+mt7996_mcu_ps_transition(struct mt7996_dev *dev, u16 wcid_idx, bool ps)
+{
+ struct mt76_wcid *wcid;
+
+ wcid = mt76_wcid_ptr(dev, wcid_idx);
+ if (!wcid || !wcid_to_sta(wcid))
+ return;
+
+ mt76_sta_ps_transition(&dev->mt76, wcid, ps);
+}
+
+static void
+mt7996_mcu_rx_ps_sync(struct mt7996_dev *dev, struct sk_buff *skb)
+{
+ struct mt7996_mcu_ps_sync_event *event = (void *)skb->data;
+ struct tlv *tlv;
+ int len;
+
+ if (skb->len < sizeof(*event))
+ return;
+
+ skb_pull(skb, sizeof(*event));
+
+ len = skb->len;
+ while (len >= sizeof(*tlv)) {
+ u16 tag, tag_len;
+
+ tlv = (struct tlv *)skb->data;
+ tag = le16_to_cpu(tlv->tag);
+ tag_len = le16_to_cpu(tlv->len);
+ /* a tag_len below the header size would not advance the buffer */
+ if (tag_len < sizeof(*tlv) || tag_len > len)
+ break;
+
+ switch (tag) {
+ case UNI_PS_CLIENT_INFO: {
+ struct mt7996_mcu_ps_client_info *info = (void *)tlv;
+
+ if (tag_len < sizeof(*info))
+ break;
+
+ mt7996_mcu_ps_transition(dev,
+ le16_to_cpu(info->wlan_idx),
+ info->ps_bit);
+ break;
+ }
+ case UNI_PS_MULTI_CLIENT_INFO: {
+ struct mt7996_mcu_ps_multi_client_info *info = (void *)tlv;
+ u16 cnt;
+ int i;
+
+ if (tag_len < sizeof(*info))
+ break;
+
+ cnt = min_t(u16, le16_to_cpu(info->sta_cnt),
+ (tag_len - sizeof(*info)) / sizeof(info->sta_ps_info[0]));
+ for (i = 0; i < cnt; i++) {
+ u16 entry = le16_to_cpu(info->sta_ps_info[i]);
+
+ mt7996_mcu_ps_transition(dev,
+ FIELD_GET(MT7996_PS_MULTI_WCID, entry),
+ !!(entry & MT7996_PS_MULTI_PS_BIT));
+ }
+ break;
+ }
+ case UNI_PS_MULTI_CLIENT_INFO_BITMAP: {
+ u8 *bitmap = tlv->data;
+ int bitmap_len = tag_len - sizeof(*tlv);
+ int i;
+
+ for (i = 0; i < bitmap_len * 8; i++)
+ mt7996_mcu_ps_transition(dev, i,
+ !!(bitmap[i / 8] & BIT(i % 8)));
+ break;
+ }
+ }
+
+ skb_pull(skb, tag_len);
+ len -= tag_len;
+ }
+}
+
static void
mt7996_mcu_uni_rx_unsolicited_event(struct mt7996_dev *dev, struct sk_buff *skb)
{
@@ -847,6 +930,9 @@ mt7996_mcu_uni_rx_unsolicited_event(struct mt7996_dev *dev, struct sk_buff *skb)
case MCU_UNI_EVENT_WED_RRO:
mt7996_mcu_wed_rro_event(dev, skb);
break;
+ case MCU_UNI_EVENT_PS_SYNC:
+ mt7996_mcu_rx_ps_sync(dev, skb);
+ break;
default:
break;
}
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h
index 1487d33a8dbb..74b70fb6da3d 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h
@@ -293,6 +293,39 @@ enum {
UNI_WED_RRO_BA_SESSION_DELETE,
};
+struct mt7996_mcu_ps_sync_event {
+ struct mt7996_mcu_rxd rxd;
+
+ u8 bss_idx;
+ u8 __rsv[3];
+} __packed;
+
+struct mt7996_mcu_ps_client_info {
+ __le16 tag;
+ __le16 len;
+ u8 ps_bit;
+ u8 __rsv;
+ __le16 wlan_idx;
+ u8 buffer_size;
+ u8 __rsv2[3];
+} __packed;
+
+struct mt7996_mcu_ps_multi_client_info {
+ __le16 tag;
+ __le16 len;
+ __le16 sta_cnt;
+ __le16 sta_ps_info[];
+} __packed;
+
+#define MT7996_PS_MULTI_WCID GENMASK(10, 0)
+#define MT7996_PS_MULTI_PS_BIT BIT(15)
+
+enum {
+ UNI_PS_CLIENT_INFO = 0,
+ UNI_PS_MULTI_CLIENT_INFO = 1,
+ UNI_PS_MULTI_CLIENT_INFO_BITMAP = 2,
+};
+
struct mt7996_mcu_thermal_notify {
struct mt7996_mcu_rxd rxd;
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c b/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
index ac81be5fe023..fbfbb96a742f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
@@ -838,7 +838,8 @@ struct mt7996_dev *mt7996_mmio_probe(struct device *pdev,
.link_data_size = sizeof(struct mt7996_vif_link),
.drv_flags = MT_DRV_TXWI_NO_FREE |
MT_DRV_AMSDU_OFFLOAD |
- MT_DRV_HW_MGMT_TXQ,
+ MT_DRV_HW_MGMT_TXQ |
+ MT_DRV_HW_PS_BUFFERING,
.survey_flags = SURVEY_INFO_TIME_TX |
SURVEY_INFO_TIME_RX |
SURVEY_INFO_TIME_BSS_RX,
--
2.53.0
next prev parent reply other threads:[~2026-08-01 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 14:53 [PATCH 01/10] wifi: mt76: add PS buffering support for HW-managed TIM drivers Felix Fietkau
2026-08-01 14:53 ` [PATCH 02/10] wifi: mt76: mt7915: handle MCU PS sync events Felix Fietkau
2026-08-01 14:53 ` Felix Fietkau [this message]
2026-08-01 14:53 ` [PATCH 04/10] wifi: mt76: set the EOSP bit in the QoS header of the last released frame Felix Fietkau
2026-08-01 14:53 ` [PATCH 05/10] wifi: mt76: mt7603: fix U-APSD service period termination Felix Fietkau
2026-08-01 14:53 ` [PATCH 06/10] wifi: mt76: mt7603: tell mac80211 when the PS queue has run empty Felix Fietkau
2026-08-01 14:53 ` [PATCH 07/10] wifi: mt76: mt7603: restore hardware PS buffering after a service period Felix Fietkau
2026-08-01 14:53 ` [PATCH 08/10] wifi: mt76: mt7603: file buffered frames under the TID reported to mac80211 Felix Fietkau
2026-08-01 14:53 ` [PATCH 09/10] wifi: mt76: reject out-of-range link ids in mt76_vif_link() Felix Fietkau
2026-08-01 14:53 ` [PATCH 10/10] wifi: mt76: mt7996: fix out-of-bounds link array access in mt7996_tx() Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801145334.1166751-3-nbd@nbd.name \
--to=nbd@nbd.name \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.