Re: [PATCH v3 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding example includes a nonexistent header and uses undefined parameterized macros, breaking schema validation.
--

--- Patch [1]: [PATCH v3 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345 ---
commit 260bc940f745039b1b740f5fca09f58549473355
Author: Aleksandrs Vinarskis <alex@vinarskis.com>

dt-bindings: platform: introduce EC for Dell XPS 13 9345

Add bindings for Embedded Controller (EC) in Dell XPS 13 9345 (platform
codename 'tributo'). It may be partially or fully compatible with EC
found in Snapdragon-based Dell Latitude, Inspiron ('thena').

> diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <arm64/qcom/qcom-adc5-gen3.h>
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Low]
Does this header exist in the source tree? It appears to be missing, which
would cause a fatal preprocessor error during schema validation when running
make dt_binding_check.

> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        embedded-controller@3b {
> +            compatible = "dell,xps13-9345-ec";
> +            reg = <0x3b>;
> +            interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> +
> +            io-channels = <&pmk8550_vadc ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>,
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Low]
Are these macros defined anywhere? They appear to be undefined and used
incorrectly as parameterized macros, which would further contribute to
preprocessor and schema check errors.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260801-dell-xps-9345-ec-v3-0-9f4bdb5a5dad@vinarskis.com?part=1