From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: ti: Correct white-space style
Date: Sat, 01 Aug 2026 21:06:40 +0000 [thread overview]
Message-ID: <20260801210640.7879C1F00AC4@smtp.kernel.org> (raw)
In-Reply-To: <20260801210404.383925-3-krzysztof.kozlowski@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing space between the node label and node name. The commit aims to fix whitespace issues, but inadvertently removes all spacing between the `uart1:` label and `serial@2531000` node name, resulting in `uart1:serial@2531000 {` instead of the conventional `uart1: serial@2531000 {`.
--
--- Patch [1]: [PATCH 1/2] ARM: dts: ti: Correct white-space style ---
commit 10cfc1fb15e4def453f73e2d4191b76cdd9e2e46
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
ARM: dts: ti: Correct white-space style
This commit aims to correct whitespace formatting issues in TI device tree
files, such as missing spaces before brackets or spurious spaces, to resolve
warnings flagged by dt-check-style.
> diff --git a/arch/arm/boot/dts/ti/keystone/keystone.dtsi b/arch/arm/boot/dts/ti/keystone/keystone.dtsi
> index ff16428860a9b..22c8b8b04340d 100644
> --- a/arch/arm/boot/dts/ti/keystone/keystone.dtsi
> +++ b/arch/arm/boot/dts/ti/keystone/keystone.dtsi
[ ... ]
> @@ -123,7 +123,7 @@ uart0: serial@2530c00 {
> interrupts = <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>;
> };
>
> - uart1: serial@2531000 {
> + uart1:serial@2531000 {
[Severity: Low]
This isn't a bug, but does this unintentionally remove the space between the
uart1 label and the node name entirely?
> compatible = "ti,da830-uart", "ns16550a";
> current-speed = <115200>;
> reg-shift = <2>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260801210404.383925-3-krzysztof.kozlowski@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-08-01 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 21:04 [PATCH 1/2] ARM: dts: ti: Correct white-space style Krzysztof Kozlowski
2026-08-01 21:04 ` [PATCH 2/2] arm64: " Krzysztof Kozlowski
2026-08-01 21:06 ` sashiko-bot [this message]
2026-08-01 21:09 ` [PATCH 1/2] ARM: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801210640.7879C1F00AC4@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.