From: Julian Braha <julianbraha@gmail.com>
To: florian.fainelli@broadcom.com, rjui@broadcom.com,
sbranden@broadcom.com, linux@armlinux.org.uk, tglx@kernel.org,
Frank.Li@nxp.com, s.hauer@pengutronix.de
Cc: bcm-kernel-feedback-list@broadcom.com, radu@rendec.net,
kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev, arnd@arndb.de,
Julian Braha <julianbraha@gmail.com>
Subject: [PATCH] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW
Date: Sat, 1 Aug 2026 22:22:35 +0100 [thread overview]
Message-ID: <20260801212235.2692694-1-julianbraha@gmail.com> (raw)
ARM_GIC_V3 selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its
dependency, ARM_PSCI_FW is met. However, ARM_PSCI_FW should be
selected by the system type, so ARM_GIC_V3 should depend on ARM_PSCI_FW.
Additionally, the systems that select ARM_GIC_V3 (ARCH_BRCMSTB and
SOC_IMX8M) need to select its dependency, ARM_PSCI_FW, too.
This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.
Fixes: 35727af2b15d ("irqchip/gicv3: Workaround for NVIDIA erratum T241-FABRIC-4")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
arch/arm/mach-bcm/Kconfig | 1 +
drivers/irqchip/Kconfig | 1 +
drivers/soc/imx/Kconfig | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 24bc6e18d806..ff7c161df1f1 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -184,6 +184,7 @@ config ARCH_BRCMSTB
depends on ARCH_MULTI_V7
select ARCH_HAS_RESET_CONTROLLER
select ARM_AMBA
+ select ARM_PSCI_FW
select ARM_GIC
select ARM_GIC_V3
select ARM_ERRATA_798181 if SMP
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 20b77fbc51ee..726804295545 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -35,6 +35,7 @@ config GIC_NON_BANKED
config ARM_GIC_V3
bool
+ depends on ARM_PSCI_FW
select IRQ_DOMAIN_HIERARCHY
select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
select HAVE_ARM_SMCCC_DISCOVERY
diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 2a90ddd20104..9f0be8b66c4f 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -6,6 +6,7 @@ config SOC_IMX8M
depends on ARCH_MXC || COMPILE_TEST
default ARCH_MXC && ARM64
select SOC_BUS
+ select ARM_PSCI_FW if ARCH_MXC && ARCH_MULTI_V7
select ARM_GIC_V3 if ARCH_MXC && ARCH_MULTI_V7
help
If you say yes here you get support for the NXP i.MX8M family
--
2.55.0
next reply other threads:[~2026-08-01 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 21:22 Julian Braha [this message]
2026-08-19 19:05 ` [PATCH] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW Thomas Gleixner
2026-08-20 8:22 ` Marc Zyngier
2026-08-21 23:11 ` Julian Braha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801212235.2692694-1-julianbraha@gmail.com \
--to=julianbraha@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=radu@rendec.net \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.