Re: [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding `CONFIG_NET_DEVMEM=y` to the config fragment is ineffective because `NET_DEVMEM` is a hidden symbol with no prompt.
--

--- Patch [1]: [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config ---
commit 07d433d344dd104ff54b719b50d995dfb8a6b2be
Author: Bobby Eshleman <bobbyeshleman@meta.com>

selftests: drv-net: enable devmem TCP in the test config

This commit updates the selftests network hardware config fragment to enable 
CONFIG_SYNC_FILE to satisfy dependencies for DMA_SHARED_BUFFER, and explicitly 
adds CONFIG_NET_DEVMEM.

> diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
> index ed8642b68094f..d89a9ba176558 100644
> --- a/tools/testing/selftests/drivers/net/hw/config
> +++ b/tools/testing/selftests/drivers/net/hw/config
> @@ -15,11 +15,13 @@ CONFIG_IPV6_SIT=y
>  CONFIG_IPV6_TUNNEL=y
>  CONFIG_NET_CLS_ACT=y
>  CONFIG_NET_CLS_BPF=y
> +CONFIG_NET_DEVMEM=y

[Severity: Low]
Is this assignment effective? Since NET_DEVMEM is a hidden config symbol 
(defined with def_bool y and no prompt string in net/Kconfig), Kconfig 
silently ignores manual assignments in config fragments.

It should be automatically enabled when its dependencies are satisfied 
(which the addition of CONFIG_SYNC_FILE helps achieve), making this 
explicit entry redundant.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260731-selftests-devmem-config-v1-1-098014348d9d@meta.com?part=1