All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [chenxing:mstar_v6_5_reorder 356/700] drivers/net/ethernet/cadence/macb_main.c:4708:12: warning: 'msc313_init' defined but not used
Date: Sun, 02 Aug 2026 04:21:54 +0800	[thread overview]
Message-ID: <202608020455.QLUczTAO-lkp@intel.com> (raw)

tree:   https://github.com/linux-chenxing/linux.git mstar_v6_5_reorder
head:   1a5c60e65ea399670a5384b869c4958338af2799
commit: 3eff6bbbe433f0cb27875c6395a2db83a68744f0 [356/700] macb: don't rely on u-boot to fix the rx descriptors
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260802/202608020455.QLUczTAO-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260802/202608020455.QLUczTAO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608020455.QLUczTAO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/cadence/macb_main.c:4708:12: warning: 'msc313_init' defined but not used [-Wunused-function]
    4708 | static int msc313_init(struct platform_device *pdev)
         |            ^~~~~~~~~~~


vim +/msc313_init +4708 drivers/net/ethernet/cadence/macb_main.c

  4707	
> 4708	static int msc313_init(struct platform_device *pdev)
  4709	{
  4710		struct net_device *dev = platform_get_drvdata(pdev);
  4711		struct macb *bp = netdev_priv(dev);
  4712		struct device_node *phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
  4713	
  4714		/** Note to self: Check if the julian registers are visible over XIU on msc313 */
  4715	
  4716		/*
  4717		 * This switches to "software rx descriptors".
  4718		 * Without this rx doesn't work like this driver
  4719		 * thinks it should work and the controller
  4720		 * corrupts the memory. So a must have.
  4721		 */
  4722		macb_writel(bp, MSC313_13A, 0x100);
  4723		macb_writel(bp, MSC313_JULIAN_104, 1);
  4724	
  4725		/*
  4726		 * We need a few magic numbers to get the PHY to work.
  4727		 * Most versions of these chips have an integrated PHY,
  4728		 * some have one interface with an integrated PHY and RMII
  4729		 * external, some only have RMII. There are various magic
  4730		 * numbers in the vendor code for this.
  4731		 */
  4732		if (!phy_node)
  4733			goto no_phy;
  4734	
  4735		if (of_property_read_bool(phy_node, "phy-is-integrated")) {
  4736			/* noop for now */
  4737		}
  4738		else {
  4739			/* valid for the ssd20xd */
  4740			macb_writel(bp, MSC313_JULIAN_100, 0xf017);
  4741		}
  4742	
  4743		of_node_put(phy_node);
  4744	
  4745	no_phy:
  4746		return at91ether_init(pdev);
  4747	}
  4748	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-08-01 20:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608020455.QLUczTAO-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=daniel@0x0f.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.