Re: [PATCH v2 08/11] dtc: dt-check-style: Introduce 'stricter' mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The selftest runner `scripts/dtc/dt-style-selftest/run.sh` was not updated to test `good/` fixtures against the newly added `stricter` mode.
--

--- Patch [8]: [PATCH v2 08/11] dtc: dt-check-style: Introduce 'stricter' mode ---
commit 9aebf208f76b608e7a3091f58903f2279782a0e4
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Introduce 'stricter' mode

Two rules, which are enabled in 'strict' mode make little sense for DTS:

1. line-length, limiting length of line to 80 characters: DTS often has
   a bit longer lines, especially for interconnects or heavily nested
   opp-level.  Checkpatch already does not warn for exceeding 80
   characters.

2. unused-labels, discouraging unused labels in DTS or YAML (not DTSI or
   DTSO): while not harming this leads to many false positives, e.g.
   unused PMIC regulators in DTS.

Introduce another 'mode' of running beside existing relaxed and strict:
a 'stricter' one where these two rules are moved for DTS.  Intention is
to have in-tree DTS passing 'strict' mode.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 54e96ce04b209..56d8d0c217f20 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -5,12 +5,14 @@
>  # .dts/.dtsi/.dtso source files. Enforces rules from
>  # Documentation/devicetree/bindings/dts-coding-style.rst.
>  #
> -# Two modes:
> +# Three modes:
>  #   --mode=relaxed (default)
>  #     Only rules that produce zero warnings on the current tree.
>  #     Suitable for dt_binding_check.
>  #   --mode=strict
> -#     All rules. Required for new submissions.
> +#     Most of the rules. Required for new submissions.
> +#   --mode=stricter
> +#     All rules, including ones having false positives.

[Severity: Medium]
Should the selftest runner be updated to cover this newly added mode?

Looking at scripts/dtc/dt-style-selftest/run.sh, the loop for testing good
fixtures still only iterates over relaxed and strict modes:

scripts/dtc/dt-style-selftest/run.sh:
    # good/ -- must exit 0 and produce no output in both modes
    for f in "$here"/good/*; do
        [ -e "$f" ] || continue
        for mode in relaxed strict; do
            out=$(run "$f" "$mode")

This leaves the newly added stricter mode untested against valid fixtures,
and leaves the script comment referring to "both modes" out of date.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-n-dts-style-checker-continued-v2-0-6c5dbd1ccfe4@oss.qualcomm.com?part=8