Re: [PATCH V2 1/2] dt-bindings: leds-group-multicolor: Enable default-intensity

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The scalar `default-intensity` property is structurally misapplied to the top-level multi-color parent node instead of the individual monochromatic sub-LED nodes.
--

--- Patch [1]: [PATCH V2 1/2] dt-bindings: leds-group-multicolor: Enable default-intensity ---
commit bf29f5ac49b0a3cb58ee37092ceaf9652d2451d0
Author: Stefan Wahren <wahrenst@gmx.net>

dt-bindings: leds-group-multicolor: Enable default-intensity

This commit updates the leds-group-multicolor binding to allow the
default-intensity property on the top-level multicolor LED node.

> diff --git a/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
> index 5c9cfa39396b0..1f308cdb71c86 100644
> --- a/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
> @@ -19,6 +19,8 @@ properties:
>  
>    leds: true
>  
> +  default-intensity: true
> +

[Severity: Medium]
Does this misapply the scalar default-intensity property to the top-level
multicolor parent node?

Because default-intensity is defined as a scalar uint32 type in common.yaml,
placing it on a multicolor aggregate node prevents it from conveying the
per-color-component intensity values required to define a default color mix.
If a developer attempts to define a mix using an array (e.g. <255 128 0>),
schema validation will fail due to the scalar type constraint.

Would it be more appropriate to apply this property exclusively to the
referenced monochromatic sub-LED nodes (e.g. gpio-leds), which already
inherit this property, rather than the parent group?

>  required:
>    - leds

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802115727.50411-1-wahrenst@gmx.net?part=1