From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD777C55175 for ; Sun, 2 Aug 2026 14:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1lavWz3z3aaTydn/+Z1VxPG7QGl7laeI5EnbBB1xQBs=; b=dmkzJVTv1ceggm HOnEaX6tG5XOMdE5S8gYhJjCUdFGuo88LXcsk7ahNtN8gpFT1a99E2mZBe40TfeLZu1wRlNCli501 FggIGyAiehp8FIkuh/Rbue2kzotogGsKcs12Bz2afuwlKET9IMUmZ9zIQzXXYoBE5xHglQRgQY/2z 7Bwi6aebE1u3dURaDTRo2mc1x1F+BBHhhS5VTkNYjf987djHlL7cbDilP8TXoUkoMgyBDcYrp2nYN YynbSPQSfhh+c7c/bGdclZ2OlQRxbGNPmeCeW6ww3yZTIWPMjMWtKD8vgbeEeB8bojRTq//bukTdO MgZ/dv3OcwQOiKDzalDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqX8N-0000000FiDl-1Pfx; Sun, 02 Aug 2026 14:25:47 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqX8L-0000000FiD7-2h0r for linux-phy@lists.infradead.org; Sun, 02 Aug 2026 14:25:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1BE6360DD8; Sun, 2 Aug 2026 14:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B61F1F000E9; Sun, 2 Aug 2026 14:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785680744; bh=cl53CQ7ODMQtZ2fnkPnRVoAG6vvhuGOqM5Qi0fvSgec=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DJnwVJF+4yIVAChXeWaic97jZAF/u7hjs7GhlTFROgdPwMqQVYzMyjtD/HXUZfUJk estbUiJZ0XzLUOg1rW/Ak4UMzxqBcuRBd7XM+92CRlT8FvD5BQD0OE/DcCO19k4JYJ uoB9iOv0EN+9OuLWK8Zyyc6qyalBtCgkMS3ndAIkKi7/gpOiceURLBTaV10TYxStfg 44/djKEfT89b19tFDinTn/cTNkLfu/u7/eEr2yxE44zvpiA2Ce04Z3b+tEwOdLAAo2 lzClh/kQFxa/3SSFMhV51nHikLXMDTZPpxWB38XIzsrbRNEGJL35/WeL7UQykZ4+ua VIoPPorU+yDxA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 09/10] arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port To: "Coia Prant" Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org, wsa+renesas@sang-engineering.com, olteanv@gmail.com, linux-phy@lists.infradead.org, robh@kernel.org, vkoul@kernel.org In-Reply-To: <20260801142244.679437-11-coiaprant@gmail.com> References: <20260801142244.679437-2-coiaprant@gmail.com> <20260801142244.679437-11-coiaprant@gmail.com> Date: Sun, 02 Aug 2026 14:25:43 +0000 Message-Id: <20260802142544.1B61F1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIFlUODUyMVNDIFBI WSBub2RlIHNwZWNpZmllcyAxMEcgRW5lcmd5IEVmZmljaWVudCBFdGhlcm5ldCAoRUVFKSBlcnJh dGEgcHJvcGVydGllcyAoYGVlZS1icm9rZW4tMTBndGAsIGBlZWUtYnJva2VuLTEwZ2t4NGAsIGBl ZWUtYnJva2VuLTEwZ2tyYCkgZGVzcGl0ZSBiZWluZyBhIEdpZ2FiaXQgUEhZLgotLQoKLS0tIFBh dGNoIFs5XTogW1BBVENIIHYyIDA5LzEwXSBhcm02NDogZHRzOiByb2NrY2hpcDogcmszNTY4LXBo b3RvbmljYXQ6IGVuYWJsZSBTR01JSSBMQU4gcG9ydCAtLS0KY29tbWl0IDA4ZWU0YmY4N2Y2MmFh YTU5M2I2MmZmYjBhMzdmOGY4NjE4YTZhMmEKQXV0aG9yOiBDb2lhIFByYW50IDxjb2lhcHJhbnRA Z21haWwuY29tPgoKYXJtNjQ6IGR0czogcm9ja2NoaXA6IHJrMzU2OC1waG90b25pY2F0OiBlbmFi bGUgU0dNSUkgTEFOIHBvcnQKClRoaXMgY29tbWl0IGVuYWJsZXMgdGhlIFNHTUlJIExBTiBwb3J0 IG9uIHRoZSBBcmlhYm9hcmQgUGhvdG9uaWNhdCwKYWRkaW5nIHRoZSBuZWNlc3NhcnkgWFBDUywg R01BQzAsIGFuZCBNRElPMCBub2RlcyB0byBtYWtlIHRoZSBNb3RvcmNvbW0KWVQ4NTIxU0MgR2ln YWJpdCBFdGhlcm5ldCBQSFkgZnVuY3Rpb25hbC4KCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQv Ym9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LXBob3RvbmljYXQuZHRzIGIvYXJjaC9hcm02NC9ib290 L2R0cy9yb2NrY2hpcC9yazM1NjgtcGhvdG9uaWNhdC5kdHMKPiAtLS0gYS9hcmNoL2FybTY0L2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzU2OC1waG90b25pY2F0LmR0cwo+ICsrKyBiL2FyY2gvYXJtNjQv Ym9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LXBob3RvbmljYXQuZHRzClsgLi4uIF0KPiBAQCAtMzQx LDYgKzM1MiwzOSBAQCAmaTJzMF84Y2ggewo+ICAJc3RhdHVzID0gIm9rYXkiOwo+ICB9Owo+ICAK PiArJm1kaW8wIHsKPiArCXNnbWlpX3BoeTogZXRoZXJuZXQtcGh5QDMgewo+ICsJCWNvbXBhdGli bGUgPSAiZXRoZXJuZXQtcGh5LWlkMDAwMC4wMTFhIjsKPiArCQlyZWcgPSA8MHgzPjsKPiArCQlt YXgtc3BlZWQgPSA8MTAwMD47Cj4gKwkJZWVlLWJyb2tlbi0xMGd0Owo+ICsJCWVlZS1icm9rZW4t MTBna3g0Owo+ICsJCWVlZS1icm9rZW4tMTBna3I7CgpbU2V2ZXJpdHk6IExvd10KQXJlIHRoZXNl IDEwRyBFbmVyZ3kgRWZmaWNpZW50IEV0aGVybmV0IChFRUUpIGVycmF0YSBwcm9wZXJ0aWVzIGlu dGVuZGVkIGZvcgp0aGlzIEdpZ2FiaXQgUEhZPyBTaW5jZSBtYXgtc3BlZWQgaXMgbGltaXRlZCB0 byAxMDAwLCB0aGVzZSAxMEctc3BlY2lmaWMKcHJvcGVydGllcyBhcHBlYXIgdG8gYmUgaW5hcHBs aWNhYmxlIHRvIHRoaXMgZGV2aWNlLgoKPiArCQlyZXNldC1hc3NlcnQtdXMgPSA8MjAwMDA+Owo+ ICsJCXJlc2V0LWRlYXNzZXJ0LXVzID0gPDEwMDAwMD47CgotLSAKU2FzaGlrbyBBSSByZXZpZXcg wrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwODAxMTQyMjQ0LjY3OTQzNy0y LWNvaWFwcmFudEBnbWFpbC5jb20/cGFydD05CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdAps aW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE7E03B19AF for ; Sun, 2 Aug 2026 14:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785680745; cv=none; b=QCOnlQOUznN9udEMVugm00zN9QflG7c4NSNG2bHa4V4ygjhE1xuINvYXRQ78lV9gASgT0eRGuIXOlIJTtsidnF7hqCm6uzj6Pb8qoDjo7z+R+KSa114pRnmkzw61+24gDSe8f9/amVM7F72OAyxz1lxXyjNQ/zIAEJ+m9WtyFh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785680745; c=relaxed/simple; bh=TATG5OB500C4xYEJSWcC1r1occnACIYVnUyC1YniIOc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=lIWqmWH3kWTr6RIhz6RvjIfU3Bss7P7JzvBjCyzxS/EH75xc9Kv2zlqi2XkKxngiNsvTSuoBVKKi+dE1W8GHFX0BYXchGeO6KtzgDH+W5K+Olr2smaKRUt5fhRs3/JZ+frIJQRGekrccPD6cHvVNuu2UsMHl0DV1mlpoOAiRQfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DJnwVJF+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DJnwVJF+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B61F1F000E9; Sun, 2 Aug 2026 14:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785680744; bh=cl53CQ7ODMQtZ2fnkPnRVoAG6vvhuGOqM5Qi0fvSgec=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DJnwVJF+4yIVAChXeWaic97jZAF/u7hjs7GhlTFROgdPwMqQVYzMyjtD/HXUZfUJk estbUiJZ0XzLUOg1rW/Ak4UMzxqBcuRBd7XM+92CRlT8FvD5BQD0OE/DcCO19k4JYJ uoB9iOv0EN+9OuLWK8Zyyc6qyalBtCgkMS3ndAIkKi7/gpOiceURLBTaV10TYxStfg 44/djKEfT89b19tFDinTn/cTNkLfu/u7/eEr2yxE44zvpiA2Ce04Z3b+tEwOdLAAo2 lzClh/kQFxa/3SSFMhV51nHikLXMDTZPpxWB38XIzsrbRNEGJL35/WeL7UQykZ4+ua VIoPPorU+yDxA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 09/10] arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port Reply-To: sashiko-reviews@lists.linux.dev To: "Coia Prant" Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org, wsa+renesas@sang-engineering.com, olteanv@gmail.com, linux-phy@lists.infradead.org, robh@kernel.org, vkoul@kernel.org In-Reply-To: <20260801142244.679437-11-coiaprant@gmail.com> References: <20260801142244.679437-2-coiaprant@gmail.com> <20260801142244.679437-11-coiaprant@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 02 Aug 2026 14:25:43 +0000 Message-Id: <20260802142544.1B61F1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The YT8521SC PHY node specifies 10G Energy Efficient Ethernet (EEE)= errata properties (`eee-broken-10gt`, `eee-broken-10gkx4`, `eee-broken-10g= kr`) despite being a Gigabit PHY. -- --- Patch [9]: [PATCH v2 09/10] arm64: dts: rockchip: rk3568-photonicat: en= able SGMII LAN port --- commit 08ee4bf87f62aaa593b62ffb0a37f8f8618a6a2a Author: Coia Prant arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port This commit enables the SGMII LAN port on the Ariaboard Photonicat, adding the necessary XPCS, GMAC0, and MDIO0 nodes to make the Motorcomm YT8521SC Gigabit Ethernet PHY functional. > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts b/arch/ar= m64/boot/dts/rockchip/rk3568-photonicat.dts > --- a/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts [ ... ] > @@ -341,6 +352,39 @@ &i2s0_8ch { > status =3D "okay"; > }; > =20 > +&mdio0 { > + sgmii_phy: ethernet-phy@3 { > + compatible =3D "ethernet-phy-id0000.011a"; > + reg =3D <0x3>; > + max-speed =3D <1000>; > + eee-broken-10gt; > + eee-broken-10gkx4; > + eee-broken-10gkr; [Severity: Low] Are these 10G Energy Efficient Ethernet (EEE) errata properties intended for this Gigabit PHY? Since max-speed is limited to 1000, these 10G-specific properties appear to be inapplicable to this device. > + reset-assert-us =3D <20000>; > + reset-deassert-us =3D <100000>; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260801142244.6794= 37-2-coiaprant@gmail.com?part=3D9