All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Leon Romanovsky" <leon@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 06/13] PCI: Account for ACS egress control in isolation checks
Date: Sun, 02 Aug 2026 15:50:51 +0000	[thread overview]
Message-ID: <20260802155051.B07E01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260802-fix-p2p-acs-v1-6-a7c5eb64fff6@nvidia.com>

> From: Leon Romanovsky <leonro@nvidia.com>
> 
> pci_acs_enabled() treats P2P Request Redirect as effective whenever its
> control bit is set. PCIe r7.0, sec 6.12.3, table 6-11 lets an enabled
> Egress Control Vector override it: a clear vector bit routes the request
> directly.
> 
> IOMMU grouping uses this check to prove peer requests cannot bypass the
> IOMMU, but cannot know every applicable vector bit, so Request Redirect
> gives no such guarantee while Egress Control is enabled.
> 
> Report Request Redirect as ineffective there, merging the devices into
> one IOMMU group, and report no isolation when the register cannot be
> read. Apply the same rule to the Intel SPT PCH quirk.
> 
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260802-fix-p2p-acs-v1-0-a7c5eb64fff6@nvidia.com?part=6


  reply	other threads:[~2026-08-02 15:50 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-02 15:09 [PATCH 00/13] PCI/P2PDMA: Fix ACS egress control handling Leon Romanovsky
2026-08-02 15:09 ` [PATCH 01/13] PCI/P2PDMA: Safely terminate ACS redirect lists Leon Romanovsky
2026-08-02 15:26   ` sashiko-bot
2026-08-04 19:49   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 02/13] PCI/P2PDMA: Report ACS ports when the paths share no upstream bridge Leon Romanovsky
2026-08-02 15:34   ` sashiko-bot
2026-08-04 19:52   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 03/13] PCI/P2PDMA: Document the Address Type assumption Leon Romanovsky
2026-08-02 15:26   ` sashiko-bot
2026-08-04 19:55   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 04/13] PCI: Account for Direct Translated P2P in ACS isolation checks Leon Romanovsky
2026-08-02 15:45   ` sashiko-bot
2026-08-04 20:03   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 05/13] PCI: Add ACS egress control vector accessor Leon Romanovsky
2026-08-02 15:39   ` sashiko-bot
2026-08-04 21:55   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 06/13] PCI: Account for ACS egress control in isolation checks Leon Romanovsky
2026-08-02 15:50   ` sashiko-bot [this message]
2026-08-04 21:55   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 07/13] PCI/P2PDMA: Derive peer-to-peer routing from ACS control bits Leon Romanovsky
2026-08-02 15:50   ` sashiko-bot
2026-08-04 21:55   ` Logan Gunthorpe
2026-08-04 21:58     ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 08/13] PCI/P2PDMA: Honor ACS egress control vectors Leon Romanovsky
2026-08-02 15:57   ` sashiko-bot
2026-08-04 21:56   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 09/13] PCI/P2PDMA: Document ACS egress control handling Leon Romanovsky
2026-08-02 15:51   ` sashiko-bot
2026-08-04 22:01   ` Logan Gunthorpe
2026-08-05  9:02     ` Leon Romanovsky
2026-08-02 15:09 ` [PATCH 10/13] PCI/P2PDMA: Extract pure ACS routing decision helpers Leon Romanovsky
2026-08-02 15:55   ` sashiko-bot
2026-08-04 22:07   ` Logan Gunthorpe
2026-08-05  9:06     ` Leon Romanovsky
2026-08-02 15:09 ` [PATCH 11/13] PCI/P2PDMA: Add KUnit tests for ACS routing decisions Leon Romanovsky
2026-08-02 16:02   ` sashiko-bot
2026-08-04 22:37   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 12/13] PCI/P2PDMA: Add KUnit coverage for the ACS P2P routing walk Leon Romanovsky
2026-08-02 16:07   ` sashiko-bot
2026-08-04 22:37   ` Logan Gunthorpe
2026-08-02 15:09 ` [PATCH 13/13] PCI: Add KUnit coverage for ACS isolation checks Leon Romanovsky
2026-08-02 16:07   ` sashiko-bot
2026-08-04 22:38   ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260802155051.B07E01F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.