From: Nguyen Dinh Phi <phind.uet@gmail.com>
To: pbonzini@redhat.com, qemu-devel@nongnu.org
Cc: qemu-rust@nongnu.org, Nguyen Dinh Phi <phind.uet@gmail.com>
Subject: [PATCH 2/2] rust/bits: Use checked_ilog2() in Binary::format to avoid panic
Date: Mon, 3 Aug 2026 01:03:45 +0800 [thread overview]
Message-ID: <20260802170346.3493821-3-phind.uet@gmail.com> (raw)
In-Reply-To: <20260802170346.3493821-1-phind.uet@gmail.com>
ilog2() panics when VALID__ is 0 on empty bits. Switch to checked_ilog2()
to handle zero safely.
Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
---
rust/bits/src/lib.rs | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/rust/bits/src/lib.rs b/rust/bits/src/lib.rs
index 60b63f969d..5769bc761a 100644
--- a/rust/bits/src/lib.rs
+++ b/rust/bits/src/lib.rs
@@ -215,7 +215,9 @@ pub const fn invert(self) -> Self {
impl ::std::fmt::Binary for $struct_name {
fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
// If no width, use the highest valid bit
- let width = f.width().unwrap_or((Self::VALID__.ilog2() + 1) as usize);
+ let width = f
+ .width()
+ .unwrap_or(Self::VALID__.checked_ilog2().map_or(1, |bit| (bit + 1) as usize));
write!(f, "{:0>width$.precision$b}", self.0,
width = width,
precision = f.precision().unwrap_or(width))
@@ -412,6 +414,12 @@ pub struct InterruptMask(u32) {
}
}
+ bits! {
+ pub struct EmptyMask(u32) {
+ NONE = 0,
+ }
+ }
+
#[test]
pub fn test_not() {
assert_eq!(
@@ -450,4 +458,9 @@ pub fn test_sub_assign() {
op1 -= InterruptMask::RI;
assert_eq!(op1, InterruptMask::E - InterruptMask::RI);
}
+
+ #[test]
+ pub fn test_bit_display_empty() {
+ assert_eq!(format!("{:b}", EmptyMask::NONE), "0");
+ }
}
--
2.53.0
prev parent reply other threads:[~2026-08-02 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 17:03 [PATCH 0/2] rust/bits: Fix minor bugs in bits crate Nguyen Dinh Phi
2026-08-02 17:03 ` [PATCH 1/2] rust/bits: Align SubAssign behavior with Sub Nguyen Dinh Phi
2026-08-02 17:03 ` Nguyen Dinh Phi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802170346.3493821-3-phind.uet@gmail.com \
--to=phind.uet@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.