All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Clément MATHIEU--DRIF" <clement.mathieu--drif@bull.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"peterx@redhat.com" <peterx@redhat.com>,
	"jasowangio@gmail.com" <jasowangio@gmail.com>,
	"zhenzhong.duan@intel.com" <zhenzhong.duan@intel.com>,
	"kevin.tian@intel.com" <kevin.tian@intel.com>,
	"yi.l.liu@intel.com" <yi.l.liu@intel.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v1] intel_iommu: Expose SMPWC when SVM is enabled
Date: Mon, 3 Aug 2026 02:05:33 -0400	[thread overview]
Message-ID: <20260803020520-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <36e03eda2384213c5766e5940e2376aa6c50e6e5.camel@bull.com>

On Mon, Aug 03, 2026 at 05:40:06AM +0000, Clément MATHIEU--DRIF wrote:
> 
> 
> On Sun, 2026-08-02 at 14:53 -0400, Michael S. Tsirkin wrote:
> > Caution: External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe.
> > 
> > 
> > On Sun, Aug 02, 2026 at 04:05:08PM +0000, Clément MATHIEU--DRIF wrote:
> > 
> > > SVM in Linux requires SMPWC as of 780dfed68862.
> > 
> > 
> > And what is 780dfed68862?
> 
> A commit in the linux tree, is there a dedicated tag for that?
> 
> Maybe "Link: link_to_github"?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=780dfed68862


> > 
> > 
> > > This is free in the
> > > current implementation as it is already in line with the expected
> > > behaviour.
> > > 
> > > Signed-off-by: Clement Mathieu--Drif <[clement.mathieu--drif@bull.com](mailto:clement.mathieu--drif@bull.com)>
> > > ---
> > >  hw/i386/intel_iommu.c          | 3 ++-
> > >  hw/i386/intel_iommu_internal.h | 1 +
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> > > index 8245452d89..9f21622a4f 100644
> > > --- a/hw/i386/intel_iommu.c
> > > +++ b/hw/i386/intel_iommu.c
> > > @@ -5108,7 +5108,8 @@ static void vtd_init(IntelIOMMUState *s)
> > >      }
> > > 
> > >      if (s->svm) {
> > > -        s->ecap |= VTD_ECAP_PRS | VTD_ECAP_PDS | VTD_ECAP_NWFS;
> > > +        s->ecap |= VTD_ECAP_PRS | VTD_ECAP_PDS | VTD_ECAP_NWFS |
> > > +                   VTD_ECAP_SMPWCS;
> > >      }
> > > 
> > >      vtd_reset_caches(s);
> > > diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
> > > index 924e91cb8a..df7a0efa6e 100644
> > > --- a/hw/i386/intel_iommu_internal.h
> > > +++ b/hw/i386/intel_iommu_internal.h
> > > @@ -202,6 +202,7 @@
> > >  #define VTD_ECAP_SMTS               (1ULL << 43)
> > >  #define VTD_ECAP_SSTS               (1ULL << 46)
> > >  #define VTD_ECAP_FSTS               (1ULL << 47)
> > > +#define VTD_ECAP_SMPWCS             (1ULL << 48)
> > > 
> > >  /* CAP_REG */
> > >  /* (offset >> 4) << 24 */
> > > --
> > > 2.54.0
> > 
> > 



  reply	other threads:[~2026-08-03  6:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-02 16:05 [PATCH v1] intel_iommu: Expose SMPWC when SVM is enabled Clément MATHIEU--DRIF
2026-08-02 16:47 ` Michael S. Tsirkin
2026-08-04  8:51   ` Yi Liu
2026-08-04 11:09     ` Clément MATHIEU--DRIF
2026-08-02 18:53 ` Michael S. Tsirkin
2026-08-03  5:40   ` Clément MATHIEU--DRIF
2026-08-03  6:05     ` Michael S. Tsirkin [this message]
2026-08-03  7:26 ` Duan, Zhenzhong
2026-08-04  8:39   ` Yi Liu
2026-08-04 11:12     ` Clément MATHIEU--DRIF
2026-08-04  8:48 ` Yi Liu
2026-08-04 11:11   ` Clément MATHIEU--DRIF

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803020520-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=clement.mathieu--drif@bull.com \
    --cc=jasowangio@gmail.com \
    --cc=kevin.tian@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yi.l.liu@intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.