Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Moving `qcom,glymur-dwc3` to a different conditional block enforces a strict interrupt order that breaks schema validation for existing device tree nodes.
--

--- Patch [1]: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers ---
commit 8b1e476813d3e646db74155c4e3c7dfd5ec0b74b
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>

dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

Glymur DRD capable controllers have HS Phy interrupt. Fix the binding to
indicate the same.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index d410aeaf92fb6..100a287ea46c9 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> @@ -524,7 +524,6 @@ allOf:
>          compatible:
>            contains:
>              enum:
> -              - qcom,glymur-dwc3
>                - qcom,milos-dwc3
>                - qcom,x1e80100-dwc3
>      then:
> @@ -547,6 +546,7 @@ allOf:
>            contains:
>              enum:
>                - qcom,eliza-dwc3
> +              - qcom,glymur-dwc3

[Severity: Medium]
Will this break dtbs_check for existing in-tree device trees?

Moving qcom,glymur-dwc3 to this block enforces a strict interrupt array
structure where "hs_phy_irq" is required at index 2 (the 3rd item). However,
looking at existing nodes like usb_0 in arch/arm64/boot/dts/qcom/glymur.dtsi:

			interrupt-names = "dwc_usb3",
					  "pwr_event",
					  "dp_hs_phy_irq",
					  "dm_hs_phy_irq",
					  "ss_phy_irq";

This node provides "dp_hs_phy_irq" at index 2 instead.

Additionally, the usb_hs node provides "hs_phy_irq" at the wrong index (4
instead of 2):

			interrupt-names = "dwc_usb3",
					  "pwr_event",
					  "dp_hs_phy_irq",
					  "dm_hs_phy_irq",
					  "hs_phy_irq";

Could we use a oneOf construction or similar to remain backward compatible and
avoid validation regressions for existing nodes?

>                - qcom,ipq4019-dwc3
>                - qcom,ipq8064-dwc3
>                - qcom,kaanapali-dwc3

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com?part=1