From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5312D38330F for ; Mon, 3 Aug 2026 12:19:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785759558; cv=none; b=F+dkNs2GvIuIRJELlUn87tYvwxJbFVYoawRUpoPsMiN02ysczr0m8stBduoluAgeVlYxE3zhZvsp+B4W+/bM86vD5jO2//Qk7DNAzGcqsSnmGkD0b5fDqa2+WnT98ec/HW8aYH4aUuU9BO30MDe6y7Z1B/Bx1WpS3XYZ8S+TEYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785759558; c=relaxed/simple; bh=wc83a5AMCwuTWCZVLQMaWatrwp89sO6/4LMd25upCRQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UZnyJqlurNkve8hDDDFT/EtuoLWyapdOnXAncdINe6toqIwr13LeAm2Sj+f5/vSbow37vFdOjOF1VPnYTS435cEv+y5s77Qvmm0D9xKMZnVG7PMs48z1UQXueKR+peGNDq6SgR2OU+X5CCjScQFIGT4tLSYb8Dg2/qtBe5e/uD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dG1E5de1; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dG1E5de1" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4954f5e8020so9704705e9.2 for ; Mon, 03 Aug 2026 05:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785759555; x=1786364355; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=He2QS3aqruPkEmo3ml3RnizkSIK2y54nrSWG7gf9bV8=; b=dG1E5de1mVEiPC6ViZjDcBxHWwbWv1vk4SezPqaUMvYe/R2VtKEpGr6jSLRGp+P1Fs lHuDELzp8F/0pcde3l7Mba9JshxvOk5X7lQ2iKngLjzVV1OiXg/7v4yy00W74yrKCO+v nvWj0m0AmbZ6CqXPeyweQx25siCvtAvzQ4KkBZ9hcZPZD0AuhnYvELTxni0SppWs8NSp rmv34xpCPKr+y+2NTGaM9NCod4vH1xg6BRESvogsnjnM3m85L7qdvMUxP93tbOmYKPVc 789za6SpX++wPQW83jM9CR21AaUb5hRZHqKF/xpg8JOCi4aO5b8GMqGW9K0IFbXTDzz7 HXYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785759555; x=1786364355; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=He2QS3aqruPkEmo3ml3RnizkSIK2y54nrSWG7gf9bV8=; b=o+N2bo0bhWsw3ObMAaLO9+6Kel0s8jx+LrPA800kkNjS29AtrUOyZXYYyb45R5KkBS W2TC4ElDC0Hof5T/5Ap7yHUrkz4ONSlpkt4A+GkP5q9VLbQVQGTqVu7q0sJ265ArMb2B MdCQImMoIFqMd28PdwXKeIDDxGG8oM4BPRaYbWAuhXtItMXrn6iblFM9Nk7CMeY6F62p TUwDAP9hJzeAa2Ypy5peHCE9LVMYWP+JBMqx94lutvKSNVpnwRdWmz2e/vwHGl0y2KnJ 8TRSgJqlvypvtsCH+QpYFArXEmawDWvwCpYO6regdSZSGa+yEg8XC9Q/ot30Ms9lfBGB h2eQ== X-Forwarded-Encrypted: i=1; AHgh+RpfRU9/RPa7RAAQBtvMOe+e7ov2YpY2W7lkTFqduJwa0VUq6roTyuYbALw4p8cAMBxKGe2w8SbWzxotL74=@vger.kernel.org X-Gm-Message-State: AOJu0YwsdEoJEAhykix1CM+Ktd02C0f6cM22EQOFj6eEzqkXPXyRqPt8 q3j9pDmKfWpKPfjwICUTrW6nDJidhsSoTkd4ZQg/Qg9MXhCyKbd7n3D5 X-Gm-Gg: AR+sD118H09nrBDnGflPG9S5k1JbNR8JXgLLvoBGeQC3KQduOr7s4uBBqAw+31a4X66 2ltNoKBdP8zvnWaPyyTHseQML7SkO5rvUzu+uSs9ZXBaeymZW4Tt/NVbX2h5IXVfXrcO2sVPb38 iJeW4LzjNL8YQ2pHGPVofnMDF13QMrlL6xJKPHEGWM1H3pYyWCwapVQ3tPsrowMKWaumx5b0U0Q ZQHXTro4GT8VR1Gj0EQY7A2klfUKiiLj8gjXbfuYf8BfIwCxZtf8kRUFpkfEeDRl3/69ApYVYqI MUwwZ8JTrshMjhVKMXVZxzcZyxTZztTXr2bHOfVMXwY9sAwbQy0+gJk6Jp1zePDbDdbXtZjTdQy MmVWmzKF5CE3cpT2SV9rrt8mkPjVQnCb7te/y+ARgIcSjjv8raUSVeb/60XNbBUTRrOvvkDIzn/ IoHR23pOq2SBownTouHcLN7jmj1bk+3stiqDfgrM3UWdghqsiz+m65Z1kdp6fRcfVqLmV07fyyO chRbWEr/1FhiVTQtZK8AfH+Ax03mC0Yy+Spn0iqhqP40MOKp8SI0Wg+DQg3xJR/6VdOd9xDV4s9 5nNLJR6wbGoPI6vLJRCVf8964btVVANe+hFZ/t8EEqyt1avBL+JLIVSQKNPuwrXnwVgsaLPfnM8 Wg9qji1NGmDY6nlRpilP0poHXwym5JvVaGLESfFqEkVh5Q4R+yAZwV13LT8uEGm9YNdK6CHE= X-Received: by 2002:a05:600c:4454:b0:493:bd2a:93bb with SMTP id 5b1f17b1804b1-4980c64b6cdmr223317955e9.3.1785759555358; Mon, 03 Aug 2026 05:19:15 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b7afe6sm213206215e9.0.2026.08.03.05.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 05:19:15 -0700 (PDT) Date: Mon, 3 Aug 2026 14:19:10 +0200 From: Joshua Crofts To: mdshahid03@gmail.com Cc: Jonathan Cameron , Andy Shevchenko , Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nuno =?ISO-8859-1?Q?S=E1?= , Ray Jui , Scott Branden Subject: Re: [PATCH v4 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages Message-ID: <20260803141910.00000263@gmail.com> In-Reply-To: <20260801090953.61603-2-mdshahid03@gmail.com> References: <20260801090953.61603-1-mdshahid03@gmail.com> <20260801090953.61603-2-mdshahid03@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 1 Aug 2026 14:39:51 +0530 mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > devm_request_threaded_irq() already logs an error when the request > fails, making the explicit dev_err() redundant. > > Similarly, iproc_adc_enable() already reports failures, making the > additional dev_err() in the probe path redundant. > > Remove both duplicate messages. > > Signed-off-by: Mohammad Shahid > --- > drivers/iio/adc/bcm_iproc_adc.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c > index cf4738b16e62..7c2e2770cd61 100644 > --- a/drivers/iio/adc/bcm_iproc_adc.c > +++ b/drivers/iio/adc/bcm_iproc_adc.c > @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pdev) > iproc_adc_interrupt_handler, > iproc_adc_interrupt_thread, > IRQF_SHARED, "iproc-adc", indio_dev); > - if (ret) { > - dev_err(&pdev->dev, "request_irq error %d\n", ret); > + if (ret) > return ret; > - } > > ret = clk_prepare_enable(adc_priv->adc_clk); > if (ret) { > @@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pdev) > } > > ret = iproc_adc_enable(indio_dev); > - if (ret) { > - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); > + if (ret) > goto err_adc_enable; > - } > > indio_dev->name = "iproc-static-adc"; > indio_dev->info = &iproc_adc_iio_info; This is good. Side note - I noticed that you added the email joshua.crofts@broadcom.com to the Cc list, however I don't work at Broadcom - there must've been a mixup when you were Ccing people as I only use the address this meesage is sent from. Thanks. -- Kind regards, Joshua Crofts