From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27EE14137A4 for ; Mon, 3 Aug 2026 14:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767514; cv=none; b=bsaG+OrLz8pzJFHsyx6ih/P7llPsurLiMXJdwred/+LZLHCQyIxWsQ8Es+PfdjXDah8BtAlbz5BcKH+/30knb3dmDQN5CiRpkGfb3AgIm0tVbLStb+n8iwTbcJsX3pCzjymJ1lF9PyBivGeIulSKJQKHSVTWqIpYXPvpU9X/nrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767514; c=relaxed/simple; bh=mbTl1m4q/B0mmfJqUSHx3puQD1k3DIBxLZfuWKkL4MA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LLyeFPIkxjWjudbgB6Q84HCqYonkmRZvAnwmjx7EEqB5Lwy74OryulAbzJ4JY2d7jgOCRaqofbYdLvskPHaRaOeo8ZWpF4ss5WlFiXerJIxLcJPA6/DiSUedx3id301mEfzyDfAyP/D0nf8rb0J1JPVvRZEFLnNKjNLzR2UmWpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=auX57uo2; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="auX57uo2" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-496b7622a83so14267675e9.2 for ; Mon, 03 Aug 2026 07:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785767510; x=1786372310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zNxBi0gHfRrbC33pAvz30lhxp0rXTHoZRpmh1XXR2eM=; b=auX57uo2tZFgjzyG2o2uCFwKPBWj/Je1Q7mb+togKe4a4TyYapFV/ggNh4GHgVTiXz UA221y9Smrx8IqN/Wo9VTodGwh4v+KBB92H2rO4SdD/ODjrBFZEZjGjHV7zCXme1GE/t RGjRLiG5EYK8JkEK26yNl1ernN/8NAvxUlV/SEGGZC+PcsishP5wipoKnrJ+4kGD1BLR RX8n52PvkYebHk3gqUDC7Fu6a0JNNsNY0rTF/BNxv9nn7a/BN65NvAF8nQhZdibHWvAA f3SmoM7/Mih8Njr4iPg7atEYuq0ZUi1WI129gzyc+bo/wP6rwXloPCiUwrE8t4zeYs3y WGrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785767510; x=1786372310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zNxBi0gHfRrbC33pAvz30lhxp0rXTHoZRpmh1XXR2eM=; b=bUPYl+RClEQ6t80wCHm16mhTDeW2fLGYeRTyMrkGdNjtyEpB0vkw7+/4ddQzBeaLQa 8ynCz2FsCkt92couUwVFZXU94RcoEHa+1CsoweRGPgGCNQhzS9qpfZs0rfSXVfv7Pkkd om+U6+EbTk7N9Z27kfHWNhqZhIoJ+b09vuPmne1LhFKn914eMzgnhkejx6MtCOOYTOuT MZaE1bgbb2fhWTw4UuEWVbgvMKyTCkLbjL+u0J4ZXVr7gXUm2bX8tPyzO7U0CbWh1jOS nvsDKuAe+S30IYq9PP3fB5zjWsWck4t+GC5rVQdglXsok9rYN2FB1phYszibKi+dI/GC VDZA== X-Forwarded-Encrypted: i=1; AHgh+RodbcYEgEk1CwLO9+SzQr6CyznLKe2CVYn3+THrwqe55p2luMPbFAglkZ02XNRQ89BV6XaSNQLrDtJ+VNU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywyygj1MXcxH560Ec/DND2ANsGuoPfqD69mNvBRRqWb0olzepKR 1aSVmx9Cb7tuQ2q6GYdLqyWJ7EcGKge02yUOGY08ZJEYTfC5OPVMbBny X-Gm-Gg: AR+sD108P0tFUPECxpXIWDLuBlQJV0XNTmsCWrrhxPanDuQ+eHfsIJOkl/lMzQ+HrWv aAgq1JcAuZNSNxcEnD92Trg4m9LKuC0xC2cgSCOEBSwGye5b77hY16nyukj8B1EzfvMJIr0ZqQx q8LJtp3RTz4qy35YWnZa7oD9d7foRxA6LCdaDiXKKb4JfsvB+eS2BH2b3Kks7f2c7eJW0UGCbaf t606vMpxFM1B1OVSi8O8EBDijNsflfei3tTabbu+cPeSVkvPu/MdmDgotR1lZXqa99WCFRZDpuK +N2HShYG/P3CTHKyLmwAEdO9erNGn75M2vHRURagnSiMjcQJ8LqIECSORN3BBv3LhrbXMIDuML+ le1zGPIdVoOZi9mXCeLMpdTezWgL9MEDHHJRuGzZJPRl8wGWsG0Xiq5hnp8skaOGOXhm5GD6wh8 j3PPZPTZFT/k8TIHGL4mUpMu7SnLEWOISeJbc4T30SKRPoMkcGyFK8enWo7Bvyuvy84P1jOv8iW BMm/bjMhjbt2dd/P8FHcgEmauQ+sIk40wjBRa0WBHoo/LBuAxhK X-Received: by 2002:a05:600c:1d1a:b0:499:49c6:bfb7 with SMTP id 5b1f17b1804b1-49949c6bfd8mr2265555e9.7.1785767482896; Mon, 03 Aug 2026 07:31:22 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b98284sm236575295e9.12.2026.08.03.07.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:31:22 -0700 (PDT) From: Muhammad Bilal To: platform-driver-x86@vger.kernel.org Cc: jorge.lopez2@hp.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@weissschuh.net, linux-kernel@vger.kernel.org, meatuni001@gmail.com, stable@vger.kernel.org Subject: [PATCH 11/13] platform/x86: hp-bioscfg: advance elem past consumed array elements in string-attributes Date: Mon, 3 Aug 2026 19:30:34 +0500 Message-ID: <20260803143037.93105-12-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803143037.93105-1-meatuni001@gmail.com> References: <20260803143037.93105-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Same defect as the companion fix to enum-attributes.c in this series: the PREREQUISITES case consumes "size" consecutive ACPI package elements via elem + reqs, but the outer loop only advances "elem" by one per iteration, causing the next iteration to misread a leftover prerequisite entry as the next property and abort the parse with -EIO on the resulting type mismatch. Fix by advancing "elem" by (size - 1) after the loop. Fixes: e6c7b3e15559 ("platform/x86: hp-bioscfg: string-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/platform/x86/hp/hp-bioscfg/string-attributes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/hp/hp-bioscfg/string-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/string-attributes.c index fe5a9a3a4ef1..5abec8995911 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/string-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/string-attributes.c @@ -233,6 +233,8 @@ static int hp_populate_string_elements_from_package(union acpi_object *string_ob kfree(str_value); str_value = NULL; } + if (size) + elem += size - 1; break; case SECURITY_LEVEL: -- 2.55.0