All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Avadhut Naik <avanaik92@gmail.com>
Subject: Re: [PATCH v9 1/7] RAS/AMD/ATL: Always build PRM address translation support
Date: Mon, 3 Aug 2026 11:24:40 -0400	[thread overview]
Message-ID: <20260803152440.GA923@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260731235523.GOam0163w6pfMOm9oU@fat_crate.local>

On Fri, Jul 31, 2026 at 04:55:23PM -0700, Borislav Petkov wrote:
> On Thu, Jul 30, 2026 at 03:48:28PM -0400, Yazen Ghannam wrote:
> > PRM (Platform Runtime Mechanism) is the only address translation method for
> > current and future AMD systems. The library should therefore always include
> > it.
> > 
> > The PRM helpers in <linux/prmt.h> already provide stubs that return an
> > error when CONFIG_ACPI_PRMT is disabled. This lets prm.c build and link
> > in all configurations. The library then falls back to native translation
> > at runtime when no PRM handler is available.
> > 
> > Drop the CONFIG_AMD_ATL_PRM option. Build prm.o unconditionally and remove
> > the now-unneeded stub for prm_umc_norm_to_sys_addr().
> > 
> > Add -EOPNOTSUPP as "PRM not available". The acpi_call_prm_handler() stub
> > returns this when CONFIG_ACPI_PRMT=n.
> 
> Please tell AI to NOT write what the patch does. :-)

Ha, I try, but I make the same mistake myself. :P

That's probably obvious, because I reviewed the commit message and
signed off on it. :)

> 
> New commit message:
> 
> "RAS/AMD/ATL: Make PRM address translation support builtin
> 
> PRM (Platform Runtime Mechanism) is the only address translation method for
> current and future AMD systems. The library should therefore always include
> it.
> 
> The PRM helpers in <linux/prmt.h> already provide stubs that return an error
> when CONFIG_ACPI_PRMT is disabled. Make prm.c builtin. The library then falls
> back to native translation at runtime when no PRM handler is available."
> 

Looks good to me.

> Yah, looking at prm.c, I'm wondering why we even Kconfigged it. Oh well...

IIRC, it was to be more modular for custom kernel builds. Of course, now
we probably should put the 'native' translation code behind a config
option. There's a lot more of that, and it's only used for legacy
systems.

Thanks,
Yazen

  reply	other threads:[~2026-08-03 15:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 19:48 [PATCH v9 0/7] Incorporate DRAM address in EDAC messages Yazen Ghannam
2026-07-30 19:48 ` [PATCH v9 1/7] RAS/AMD/ATL: Always build PRM address translation support Yazen Ghannam
2026-07-31 23:55   ` Borislav Petkov
2026-08-03 15:24     ` Yazen Ghannam [this message]
2026-08-05  4:51       ` Borislav Petkov
2026-07-30 19:48 ` [PATCH v9 2/7] RAS/AMD/ATL: Refactor PRM address translation into a common helper Yazen Ghannam
2026-08-05  5:19   ` Borislav Petkov
2026-08-05 13:52     ` Yazen Ghannam
2026-07-30 19:48 ` [PATCH v9 3/7] RAS/AMD/ATL: Add unified UMC address translation interface Yazen Ghannam
2026-07-30 19:48 ` [PATCH v9 4/7] RAS/AMD, EDAC/amd64: Use unified interface for SPA translation Yazen Ghannam
2026-07-30 19:48 ` [PATCH v9 5/7] RAS/AMD/ATL: Remove the standalone SPA translation interface Yazen Ghannam
2026-07-30 19:48 ` [PATCH v9 6/7] RAS/AMD/ATL: Add DRAM address translation via PRM Yazen Ghannam
2026-07-30 19:48 ` [PATCH v9 7/7] EDAC/amd64: Include DRAM address in output Yazen Ghannam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803152440.GA923@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=avanaik92@gmail.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.