From: Jakub Kicinski <kuba@kernel.org>
To: Can Peng <pengcan@kylinos.cn>
Cc: manishc@marvell.com, rahulv@marvell.com,
GR-Linux-NIC-Dev@marvell.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] qlcnic: move notifier error cleanup under CONFIG_INET
Date: Mon, 3 Aug 2026 16:22:16 -0700 [thread overview]
Message-ID: <20260803162216.57bc2515@kernel.org> (raw)
In-Reply-To: <20260728032046.121631-3-pengcan@kylinos.cn>
On Tue, 28 Jul 2026 11:20:46 +0800 Can Peng wrote:
> qlcnic_init_module() registers the netdevice and inetaddr notifiers only
> when CONFIG_INET is enabled, but the pci_register_driver() error handling
> block is outside that guard.
>
> Move the error check under CONFIG_INET together with the cleanup it
> protects. This avoids an empty if statement when CONFIG_INET is disabled
> and keeps the cleanup code structured like the guarded registration path.
Waste of time. Like a lot of patches from @kylinos.cn patches, sadly.
next prev parent reply other threads:[~2026-08-03 23:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 3:20 [PATCH 0/2] qlogic: fix and tidy notifier cleanup paths Can Peng
2026-07-28 3:20 ` [PATCH 1/2] netxen: unregister notifiers if PCI registration fails Can Peng
2026-07-29 23:06 ` Jacob Keller
2026-07-28 3:20 ` [PATCH 2/2] qlcnic: move notifier error cleanup under CONFIG_INET Can Peng
2026-07-29 23:38 ` Jacob Keller
2026-08-03 23:22 ` Jakub Kicinski [this message]
2026-08-03 23:30 ` [PATCH 0/2] qlogic: fix and tidy notifier cleanup paths patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803162216.57bc2515@kernel.org \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengcan@kylinos.cn \
--cc=rahulv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.