From: sashiko-bot@kernel.org
To: "Heiko Carstens" <hca@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH 1/4] s390/sysinfo: Add context analysis attributes
Date: Mon, 03 Aug 2026 17:33:28 +0000 [thread overview]
Message-ID: <20260803173329.3D30B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260803172144.827049-2-hca@linux.ibm.com>
> Add context analysis attributes to service_level_start() and
> service_level_stop() to specify that those functions only
> acquire or release a lock.
>
> Addresses the following warnings:
>
> arch/s390/kernel/sysinfo.c:331:1: warning: rw_semaphore 'service_level_sem' is still held at the end of function
> arch/s390/kernel/sysinfo.c:329:2: note: rw_semaphore acquired here
> 329 | down_read(&service_level_sem);
> arch/s390/kernel/sysinfo.c:340:2: warning: releasing rw_semaphore 'service_level_sem' that was not held
> 340 | up_read(&service_level_sem);
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803172144.827049-1-hca@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-08-03 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 17:21 [PATCH 0/4] s390: Enable CONTEXT_ANALYSIS for various directories Heiko Carstens
2026-08-03 17:21 ` [PATCH 1/4] s390/sysinfo: Add context analysis attributes Heiko Carstens
2026-08-03 17:33 ` sashiko-bot [this message]
2026-08-03 17:21 ` [PATCH 2/4] s390/mm: Add __context_unsafe() attribute to do_secure_storage_access() Heiko Carstens
2026-08-03 17:39 ` sashiko-bot
2026-08-03 17:21 ` [PATCH 3/4] s390/mm: Add __context_unsafe() attribute to gmap helper functions Heiko Carstens
2026-08-03 17:33 ` sashiko-bot
2026-08-04 10:30 ` Claudio Imbrenda
2026-08-03 17:21 ` [PATCH 4/4] s390: Enable CONTEXT_ANALYSIS for various directories Heiko Carstens
2026-08-03 17:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803173329.3D30B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.