From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: Jia Jia <physicalmtea@gmail.com>,
jasowangio@gmail.com, pbonzoni@redhat.com, stefanha@redhat.com,
eperezma@redhat.com, virtualization@lists.linux.dev,
kvm@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] vhost-scsi: flush backend after device ioctls
Date: Mon, 3 Aug 2026 23:39:40 -0400 [thread overview]
Message-ID: <20260803233841-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <45a33302-0b28-4d00-8724-c3af6e1783f6@oracle.com>
On Mon, Aug 03, 2026 at 07:02:43PM -0500, Mike Christie wrote:
> On 7/23/26 5:54 AM, Jia Jia wrote:
> > The owner must keep the old mappings valid until the ioctl returns.
> > Remapping or dropping them from another userspace thread before then is
> > outside the lifetime assumption of this transition barrier.
>
> Ok I get it now. For some reason I thought that was valid.
>
> For the patch we don't want to flush if vhost_dev_ioctl fails
> and there's no reason to flush for operations like
> VHOST_GET_FORK_FROM_OWNER or VHOST_SET_OWNER.
>
> Could vhost_dev_ioctl return when a flush is needed?
I agree but also this is consistent with all other vhost
devices.
So I'm taking v2 of this, and we can iterate to optimize
all devices with patches on top.
--
MST
next prev parent reply other threads:[~2026-08-04 3:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 7:36 [PATCH] vhost-scsi: flush backend after device ioctls Jia Jia
2026-07-22 17:17 ` Mike Christie
2026-07-23 10:54 ` Jia Jia
2026-08-04 0:02 ` Mike Christie
2026-08-04 3:39 ` Michael S. Tsirkin [this message]
2026-08-04 5:46 ` Jia Jia
2026-07-24 6:09 ` [PATCH v2] " Jia Jia
2026-08-04 3:22 ` Michael S. Tsirkin
2026-08-04 4:06 ` Jia Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803233841-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowangio@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzoni@redhat.com \
--cc=physicalmtea@gmail.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.