From: SJ Park <sj@kernel.org>
To: pratmal@google.com
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
Sarthak Sharma <sarthak.sharma@arm.com>,
Yosry Ahmed <yosry@kernel.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Liam R. Howlett" <liam@infradead.org>
Subject: Re: [PATCH v4 1/2] selftests/mm: rename local_config.h to local_config.h_gen
Date: Mon, 3 Aug 2026 16:57:42 -0700 [thread overview]
Message-ID: <20260803235743.87939-1-sj@kernel.org> (raw)
In-Reply-To: <20260803221732.3651981-2-pratmal@google.com>
Hell Pratyush,
My recipients checker found you are using the old email address of Liam, so
added Liam's updated email to the recipients list.
On Mon, 3 Aug 2026 22:17:31 +0000 pratmal@google.com wrote:
> From: Pratyush Mallick <pratmal@google.com>
>
> Because local_config.h is a generated build artifact, un-ignoring all
> .h files in .gitignore causes it to incorrectly show up as an untracked
> file in git status.
>
> Rename it to local_config.h_gen so it no longer matches the !*.h
> inclusion rule, preparing for a subsequent patch that switches
> .gitignore to a pattern-matching approach.
>
> Update Makefile, check_config.sh, and affected test sources (cow.c,
> gup_longterm.c) accordingly.
Looks good to me. Thank you for accepting my humble suggestion or reordering.
I found this patch cannot cleanly 'git am'-ed on mm-new, mm-unstable and even
mm-stable. Maybe rebasing will be nice?
>
> Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>
> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> Suggested-by: David Hildenbrand <david@kernel.org>
> Signed-off-by: Pratyush Mallick <pratmal@google.com>
Reviewed-by: SJ Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-08-03 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 22:17 [PATCH v4 0/2] selftests/mm: use pattern matching in .gitignore pratmal
2026-08-03 22:17 ` [PATCH v4 1/2] selftests/mm: rename local_config.h to local_config.h_gen pratmal
2026-08-03 23:57 ` SJ Park [this message]
2026-08-04 0:02 ` SJ Park
2026-08-03 22:17 ` [PATCH v4 2/2] selftests/mm: use pattern matching in .gitignore pratmal
2026-08-04 0:01 ` SJ Park
2026-08-04 9:12 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803235743.87939-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=pratmal@google.com \
--cc=rppt@kernel.org \
--cc=sarthak.sharma@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.