All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Myeonghun Pak <mhun512@gmail.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH 1/2] tty: moxa: unwind tty driver if PCI registration fails
Date: Mon, 3 Aug 2026 14:41:16 +0200	[thread overview]
Message-ID: <2026080347-diaper-uncloak-ced0@gregkh> (raw)
In-Reply-To: <908e828b-1fbc-4a44-8718-f0e7459b6ed1@kernel.org>

On Mon, Aug 03, 2026 at 08:06:58AM +0200, Jiri Slaby wrote:
> On 31. 07. 26, 18:18, Myeonghun Pak wrote:
> > moxa_init() registers the tty driver before registering the PCI driver.
> > If pci_register_driver() fails, module initialization returns without
> > unregistering the tty driver or dropping its reference. moxa_exit() is
> > not called after a failed module initialization.
> > 
> > Unregister the tty driver and drop its reference before returning the
> > PCI registration error.
> I think, we should remove the whole driver instead:
> https://lore.kernel.org/all/2da84e36-7ac6-407d-8e08-edca82f4cbce@kernel.org/

I agree, I'll submit a patch to just drop it.

thanks,

greg k-h

  reply	other threads:[~2026-08-03 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 16:18 [PATCH 1/2] tty: moxa: unwind tty driver if PCI registration fails Myeonghun Pak
2026-07-31 16:18 ` [PATCH 2/2] tty: moxa: use pcim_enable_device() Myeonghun Pak
2026-08-03  6:06 ` [PATCH 1/2] tty: moxa: unwind tty driver if PCI registration fails Jiri Slaby
2026-08-03 12:41   ` Greg Kroah-Hartman [this message]
2026-08-04 13:55     ` Myeonghun Pak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026080347-diaper-uncloak-ced0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ae878000@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mhun512@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.