From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A8D7C88E72 for ; Mon, 14 Sep 2026 18:50:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x6BkY-0003gT-QW; Mon, 14 Sep 2026 14:49:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6BkW-0003Up-6e for qemu-devel@nongnu.org; Mon, 14 Sep 2026 14:49:52 -0400 Received: from mgamail.intel.com ([192.198.163.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6BkU-0006OL-L2 for qemu-devel@nongnu.org; Mon, 14 Sep 2026 14:49:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789411790; x=1820947790; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=SZpfHlP6xQku4fQ4MaTTQ8HneJmBIg0CwYEL2gVmYJ8=; b=h2WB7XiexhGMRFeuaQT+zg86XHBmnh5kVMROpKCDeE+wMhtO48XGByGT Wu34Lzk8CZMLkPLmaDUOfIY+/36s987CKZN6dqF5CGQLngUaS5o4ffKsH fCSqlUOSDorlj9apCQjDpAbtj7DHyteAPuwzFmccqJMUqaRnBBMnp4bcv /nbyXbtTXNglXbApVAHsH8BmuV5Ss3muIcKv0BGwiFKA0AWvxSGgdxmlp sgJHax92JTpkkrJaMZDZ80+1d5DBtdENewDGis32Gp7a4aemRwKCCkrCR YvRe6yR+rXUWPSTW2j4rncpDWRjMgJSz/obxm6CJ/kd+86P1ocC4RU0XI w==; X-CSE-ConnectionGUID: IJLYuNAaT2y5HbVGxnXc3A== X-CSE-MsgGUID: mEpl+oxfRdm7reAahOcxrQ== X-IronPort-AV: E=McAfee;i="6800,10657,11905"; a="88908983" X-IronPort-AV: E=Sophos;i="6.27,103,1787036400"; d="scan'208";a="88908983" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2026 11:49:45 -0700 X-CSE-ConnectionGUID: PpEVPaAHTUCPulrylKxUFA== X-CSE-MsgGUID: GER5UBY8TBSV5Q0h5W/klw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,103,1787036400"; d="scan'208";a="310994085" Received: from dongwonk-z390-aorus-ultra.fm.intel.com ([10.80.113.172]) by orviesa001.jf.intel.com with ESMTP; 14 Sep 2026 11:49:45 -0700 From: dongwon.kim@intel.com To: qemu-devel@nongnu.org Subject: [PATCH 2/2] ui/gtk: register "Grab Input" shortcut to accel_group Date: Tue, 4 Aug 2026 02:08:47 -0700 Message-Id: <20260804090847.18871-2-dongwon.kim@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260804090847.18871-1-dongwon.kim@intel.com> References: <20260804090847.18871-1-dongwon.kim@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=192.198.163.18; envelope-from=dongwon.kim@intel.com; helo=mgamail.intel.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_96_XX=3.405, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Dongwon Kim The "Grab Input" shortcut key currently fails to trigger when the window is in fullscreen mode because the menubar is hidden, which disables GtkAccelMap-based shortcuts associated with it. To ensure the accelerator remains active in fullscreen, connect it directly to s->accel_group and explicitly set the hotkey display on the menu item label. Cc: Marc-André Lureau Signed-off-by: Dongwon Kim --- ui/gtk.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 3c9720a330..2f83c557d8 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1878,6 +1878,12 @@ static void gd_menu_grab_input(GtkMenuItem *item, void *opaque) gd_update_cursor(vc); } +static void gd_accel_grab_input(void *opaque) +{ + GtkDisplayState *s = opaque; + gtk_menu_item_activate(GTK_MENU_ITEM(s->grab_item)); +} + static void gd_change_page(GtkNotebook *nb, gpointer arg1, guint arg2, gpointer data) { @@ -2557,6 +2563,7 @@ static void gd_create_menu_view(GtkDisplayState *s, DisplayOptions *opts) { GtkWidget *view_menu; GtkWidget *separator; + GtkWidget *child; QemuConsole *con; bool zoom_to_fit = false; int vc, i; @@ -2615,12 +2622,15 @@ static void gd_create_menu_view(GtkDisplayState *s, DisplayOptions *opts) gtk_menu_shell_append(GTK_MENU_SHELL(view_menu), s->grab_on_hover_item); s->grab_item = gtk_check_menu_item_new_with_mnemonic(_("_Grab Input")); - gtk_menu_item_set_accel_path(GTK_MENU_ITEM(s->grab_item), - "/View/Grab Input"); - gtk_accel_map_add_entry("/View/Grab Input", GDK_KEY_g, - HOTKEY_MODIFIERS); gtk_menu_shell_append(GTK_MENU_SHELL(view_menu), s->grab_item); - + gtk_accel_group_connect(s->accel_group, GDK_KEY_g, HOTKEY_MODIFIERS, 0, + g_cclosure_new_swap(G_CALLBACK(gd_accel_grab_input), + s, NULL)); + child = gtk_bin_get_child(GTK_BIN(s->grab_item)); + if (GTK_IS_ACCEL_LABEL(child)) { + gtk_accel_label_set_accel(GTK_ACCEL_LABEL(child), + GDK_KEY_g, HOTKEY_MODIFIERS); + } separator = gtk_separator_menu_item_new(); gtk_menu_shell_append(GTK_MENU_SHELL(view_menu), separator); -- 2.43.0