From: Christoph Hellwig <hch@lst.de>
To: Tal Zussman <tz2294@columbia.edu>
Cc: Jens Axboe <axboe@kernel.dk>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Luis Chamberlain <mcgrof@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH 1/2] block: use iomap_dirty_folio for block devices
Date: Tue, 4 Aug 2026 16:01:02 +0200 [thread overview]
Message-ID: <20260804140102.GA8894@lst.de> (raw)
In-Reply-To: <20260802-blkdev-fixes-v1-1-a82fc549fd74@columbia.edu>
On Sun, Aug 02, 2026 at 07:14:26AM -0400, Tal Zussman wrote:
> To reproduce, on a device with a sub-page block size, write a known
> pattern with O_DIRECT, mmap the same range, store to it, msync() and
> fsync(), then read it back with O_DIRECT. A reproducer is available at
Heh, shared mmap writes to block devices..
> [1].
>
> [1] https://gist.github.com/tzussman/18ab05cba4b3fdc79cce0a69d1fd05b4
Can you submit this to blktests?
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-08-04 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 11:14 [PATCH 0/2] block device write path fixes Tal Zussman
2026-08-02 11:14 ` [PATCH 1/2] block: use iomap_dirty_folio for block devices Tal Zussman
2026-08-04 14:01 ` Christoph Hellwig [this message]
2026-08-05 22:44 ` Tal Zussman
2026-08-02 11:14 ` [PATCH 2/2] block: take i_rwsem for the direct I/O write fallback Tal Zussman
2026-08-02 17:11 ` Tal Zussman
2026-08-04 14:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804140102.GA8894@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.