From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7191DC55184 for ; Tue, 4 Aug 2026 12:09:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrDxC-0000Jq-Dw; Tue, 04 Aug 2026 08:09:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrDx1-0000Ii-6t for qemu-devel@nongnu.org; Tue, 04 Aug 2026 08:08:57 -0400 Received: from rev.ng ([94.130.142.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrDwz-0007SI-EO for qemu-devel@nongnu.org; Tue, 04 Aug 2026 08:08:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=mCM3Yi2tl2uJV0DS1ZeOpTd7HKpYYZL5wrYWMN2EIiU=; b=IL+V8scGMP52Ydx gO5J7O4E2ioEAwNfHAv4mAFnlqzAtkklcHk1Cmod3xHeC/Dj1hjC/O281xg9RqL1UsdldzbEXKK5R ukweqCtZfZ/785hDjMRRMj684x8Z5IeIFsLoUpxZKyecyqNXj2kqfbuROK5jYjGRnWkqCMumWDDEv Bk=; Date: Tue, 4 Aug 2026 14:08:29 +0200 To: Anton Johansson via qemu development Cc: Anton Johansson , brian.cain@oss.qualcomm.com, pierrick.bouvier@oss.qualcomm.com, philmd@mailo.com Subject: Re: [PATCH v2 50/50] target/hexagon: Use helper-to-tcg Message-ID: <20260804140829.4a8c082d@spawn> In-Reply-To: <20260730031025.12926-51-anjo@rev.ng> References: <20260730031025.12926-1-anjo@rev.ng> <20260730031025.12926-51-anjo@rev.ng> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=94.130.142.21; envelope-from=ale@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Alessandro Di Federico From: Alessandro Di Federico via qemu development Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 30 Jul 2026 05:10:24 +0200 Anton Johansson via qemu development wrote: > + ll = custom_target('to-ll', > + input: helper_to_tcg_input_files, > + output:'helper-to-tcg-input.ll', > + depends: [helper_funcs_generated, helper_protos_generated, libqemuutil], > + command: helper_to_tcg_get_llvm_ir_cmd + ['-o', '@OUTPUT@', '@INPUT@', '--target-path', 'target/hexagon'] > + ) Currently we're not tracking dependencies correctly. For instance, if you change `target/hexagon/macros.h` and run `ninja target/hexagon/helper-to-tcg-input.ll`, the target is not rebuilt. This can be fixed in `get-llvm-ir.py` by passing `-MD -MF output.ll.d` to clang, merging all the `.d` files you get into a single one and then passing it as `depfile:` in the `custom_target` invocation. We should also depend on meson.current_build_dir() / 'compile_commands.json' -- Alessandro Di Federico rev.ng Labs