From: Jason Gunthorpe <jgg@nvidia.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Ankit Agrawal <ankita@nvidia.com>,
"jai.luthra@ideasonboard.com" <jai.luthra@ideasonboard.com>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
"W_Armin@gmx.de" <W_Armin@gmx.de>,
"alex@shazbot.org" <alex@shazbot.org>,
Vikram Sethi <vsethi@nvidia.com>,
Manish Honap <mhonap@nvidia.com>, Matt Ochs <mochs@nvidia.com>,
"clg@redhat.com" <clg@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] Introduce nvgrace-egm driver for Extended GPU Memory
Date: Tue, 4 Aug 2026 11:14:04 -0300 [thread overview]
Message-ID: <20260804141404.GA27883@nvidia.com> (raw)
In-Reply-To: <2026080425-dock-booting-82c2@gregkh>
On Tue, Aug 04, 2026 at 09:24:47AM +0200, gregkh@linuxfoundation.org wrote:
> On Mon, Aug 03, 2026 at 04:43:38PM +0000, Ankit Agrawal wrote:
> > Hi
> >
> > Gentle ping on this series. Happy to respin to address the feedbacks
> > or concerns if needed.
>
> There is no context here :(
>
> Also, you are adding custom ioctls for memory and drm things, why is the
> mm and drm people not part of the review here as this seems to interact
> / go around those subsystems?
The cover letter does explain this, the memory is CPU DRAM, so there
is nothing related to DRM. It is reserved by FW so it doesn't get a
struct page or zone, so there is no direct mm connection.
We don't want to waste system memory on a useless struct page here,
this could be 100GB's of memory potentially.
The call to register_pfn_address_space() follows how vfio was done and
this was all gone over with mm a while ago.
The single ioctl is not "memory and drm things", it is reporting a
table from the BIOS indicating portions of the FW reserved memory that
has been recorded as unreliable that should be avoided.
> And where is the userspace code that will be using this new api?
The cover letter hints at this, it is usable via existing qemu
features using the "-object memory-backend-file" or similar. Ankit
you could probably make that section a bit more specific if you
respin.
Jason
next prev parent reply other threads:[~2026-08-04 14:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 19:25 [PATCH 0/4] Introduce nvgrace-egm driver for Extended GPU Memory Ankit Agrawal
2026-07-02 19:25 ` [PATCH 1/4] platform/nvidia: Introduce nvgrace-egm driver and enumerate EGM regions Ankit Agrawal
2026-07-02 22:22 ` Armin Wolf
2026-07-03 13:59 ` Jason Gunthorpe
2026-08-05 23:18 ` Alex Williamson
2026-08-06 20:39 ` Jason Gunthorpe
2026-07-02 19:25 ` [PATCH 2/4] platform/nvidia: Implement mmap and memory scrubbing for EGM chardev Ankit Agrawal
2026-08-05 23:18 ` Alex Williamson
2026-08-06 20:39 ` Jason Gunthorpe
2026-07-02 19:25 ` [PATCH 3/4] platform/nvidia: Handle retired ECC pages and expose via ioctl Ankit Agrawal
2026-08-05 23:18 ` Alex Williamson
2026-08-06 20:39 ` Jason Gunthorpe
2026-07-02 19:25 ` [PATCH 4/4] platform/nvidia: Register EGM PFNMAP range with memory_failure Ankit Agrawal
2026-08-03 16:43 ` [PATCH 0/4] Introduce nvgrace-egm driver for Extended GPU Memory Ankit Agrawal
2026-08-04 7:24 ` gregkh
2026-08-04 14:14 ` Jason Gunthorpe [this message]
2026-08-04 14:50 ` Ankit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804141404.GA27883@nvidia.com \
--to=jgg@nvidia.com \
--cc=W_Armin@gmx.de \
--cc=alex@shazbot.org \
--cc=ankita@nvidia.com \
--cc=clg@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jai.luthra@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhonap@nvidia.com \
--cc=mochs@nvidia.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.