From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75094C5518F for ; Tue, 4 Aug 2026 14:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eVhxz8IdHSStBhf2vFsnIw/m1JPf6VHvhrLwLOrBU3M=; b=Lcu3rCkDaYWDvX s4s1j266S2iEONBN98AYvwRa6IWKvVV8otNrNFH6JbnTjr91A3o8x2x3WBhc/xz/ktrfQGpqPbGFe Z/S5QDBxhmvplq2kF2wOj8XEFxO3DKuNas9SX2e38OvQXCb7w1j596vdoARwhgZBl7sSxIG8hSH4D lexSJzXCeHF132NLhqn5lZAcjmUXFsJgMAAIbWnSqgG6mlv9n70CqRdlcDH/Zd4hYhr9RlVS72Owu FowQSQRswDItpwlaHpefbTZpWpv0NUxqryN612tcUL5b0i1kwohQq3c8H+MMuaY2D3FUOidqqJU5l 7bKmVZEEJ6kE5mLPdn/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrGKD-000000026cq-3ifs; Tue, 04 Aug 2026 14:41:02 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrGKC-000000026cR-1RLI for linux-i3c@lists.infradead.org; Tue, 04 Aug 2026 14:41:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B0F65405E6; Tue, 4 Aug 2026 14:40:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 474C71F000E9; Tue, 4 Aug 2026 14:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785854459; bh=lz697MiEZejSdiaZFCI3xzVFWQtMSBeoXw2TNQ2kOqc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=RrbJM0hdYT9FMNrXwVid1N72nfxHkqKOYFW+x9vaE2qFMMd5MMfq0YtWrLBYcOswH lJPB30QeOs0iaU359R+Drpi/GOygrbp4hxhRDv3nQ4fNlPTqE5pQ9JotRnJsCP5J66 wTujUZJhoJ4nU9XaofXAvNcluk0U2BOR2aOvWQmsRIN1PiAqaHGdqyOmcxSTFpkg7c TA0Gquq+gJAuLWN6qAv+UJGE5xcWFrB906afdR97ROvu1c+3AXTljblazDG3bnp2Ad j3bYoIpWB9FE6bgbEVOEZ/IETa8FQ0XX1XG3djfR+bHoEGrZ4+5OH917p9pcvh4ntO eIIWjYaYH4p8g== From: sashiko-bot@kernel.org Subject: Re: [PATCH V3 13/14] i3c: mipi-i3c-hci: Factor out i3c_hci_sysdev() To: "Adrian Hunter" Cc: Frank.Li@kernel.org, linux-i3c@lists.infradead.org, linux-pci@vger.kernel.org, "Alexandre Belloni" In-Reply-To: <20260804133810.184905-14-adrian.hunter@intel.com> References: <20260804133810.184905-1-adrian.hunter@intel.com> <20260804133810.184905-14-adrian.hunter@intel.com> Date: Tue, 04 Aug 2026 14:40:58 +0000 Message-Id: <20260804144059.474C71F000E9@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org PiBUaGUgTUlQSSBJM0MgSENJIGRyaXZlciBuZWVkcyB0byBpZGVudGlmeSB0aGUgdW5kZXJseWlu ZyBzeXN0ZW0gZGV2aWNlCj4gdXNlZCBmb3IgRE1BIG1hcHBpbmcgYW5kIFBNIG9wZXJhdGlvbnMu IFRoZSBsb2dpYyBmb3IgZGV0ZXJtaW5pbmcgdGhhdAo+IGRldmljZSBpcyBjdXJyZW50bHkgZW1i ZWRkZWQgaW4gdGhlIERNQSBpbXBsZW1lbnRhdGlvbi4KPiAKPiBGYWN0b3IgdGhpcyBjb2RlIG91 dCBpbnRvIGkzY19oY2lfc3lzZGV2KCkgc28gaXQgY2FuIGJlIHNoYXJlZCBieSBvdGhlcgo+IHBh cnRzIG9mIHRoZSBkcml2ZXIgYW5kIGtlZXAgdGhlIGRldmljZS1zZWxlY3Rpb24gbG9naWMgaW4g b25lIHBsYWNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFkcmlhbiBIdW50ZXIgPGFkcmlhbi5odW50 ZXJAaW50ZWwuY29tPgoKU2FzaGlrbyBoYXMgcmV2aWV3ZWQgdGhpcyBwYXRjaCBhbmQgZm91bmQg bm8gaXNzdWVzLiBJdCBsb29rcyBncmVhdCEKCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRw czovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4MDQxMzM4MTAuMTg0OTA1LTEtYWRyaWFu Lmh1bnRlckBpbnRlbC5jb20/cGFydD0xMwoKCi0tIApsaW51eC1pM2MgbWFpbGluZyBsaXN0Cmxp bnV4LWkzY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtaTNjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D442393DC7 for ; Tue, 4 Aug 2026 14:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785854461; cv=none; b=T8rJkDy466qXwj25e9T11gy4OxwgHkTcLbmYrlGN+GGe5+btgK8fyiYz46Vw3KWMmLRiTDiScJ/2Yp1RPx31OytdYKBomXl9rVBK+lTs4/4wDI+f7Ry/Eb7snj3wivtPDrs4Z922yQamgu6Src57r0GJkcnaBEo/uSkuB78fbAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785854461; c=relaxed/simple; bh=lz697MiEZejSdiaZFCI3xzVFWQtMSBeoXw2TNQ2kOqc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=rbsPN98ldVEIiJXUiK5XteRsPly6zjB8VxPCQHw+2W35oGzi6bpg4tzIr0UouDPIXh8WMoMYywUxfBe4jN/5Ur/ZV/jsXh1uK2uv7nxIGewKmNnuWyvPTSQVedqoZWo/LBM0HQQPdVKk7sSZCMhtgT+LuC/PzcnRcz9NTMeaSrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RrbJM0hd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RrbJM0hd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 474C71F000E9; Tue, 4 Aug 2026 14:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785854459; bh=lz697MiEZejSdiaZFCI3xzVFWQtMSBeoXw2TNQ2kOqc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=RrbJM0hdYT9FMNrXwVid1N72nfxHkqKOYFW+x9vaE2qFMMd5MMfq0YtWrLBYcOswH lJPB30QeOs0iaU359R+Drpi/GOygrbp4hxhRDv3nQ4fNlPTqE5pQ9JotRnJsCP5J66 wTujUZJhoJ4nU9XaofXAvNcluk0U2BOR2aOvWQmsRIN1PiAqaHGdqyOmcxSTFpkg7c TA0Gquq+gJAuLWN6qAv+UJGE5xcWFrB906afdR97ROvu1c+3AXTljblazDG3bnp2Ad j3bYoIpWB9FE6bgbEVOEZ/IETa8FQ0XX1XG3djfR+bHoEGrZ4+5OH917p9pcvh4ntO eIIWjYaYH4p8g== From: sashiko-bot@kernel.org Subject: Re: [PATCH V3 13/14] i3c: mipi-i3c-hci: Factor out i3c_hci_sysdev() Reply-To: sashiko-reviews@lists.linux.dev To: "Adrian Hunter" Cc: Frank.Li@kernel.org, linux-i3c@lists.infradead.org, linux-pci@vger.kernel.org, "Alexandre Belloni" In-Reply-To: <20260804133810.184905-14-adrian.hunter@intel.com> References: <20260804133810.184905-1-adrian.hunter@intel.com> <20260804133810.184905-14-adrian.hunter@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 04 Aug 2026 14:40:58 +0000 Message-Id: <20260804144059.474C71F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > The MIPI I3C HCI driver needs to identify the underlying system device > used for DMA mapping and PM operations. The logic for determining that > device is currently embedded in the DMA implementation. >=20 > Factor this code out into i3c_hci_sysdev() so it can be shared by other > parts of the driver and keep the device-selection logic in one place. >=20 > Signed-off-by: Adrian Hunter Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260804133810.1849= 05-1-adrian.hunter@intel.com?part=3D13