From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EA62C55822 for ; Tue, 4 Aug 2026 15:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4C3Ukjt0cgTvxnlZ4L6U7G++8/GlejC4Ax3NNd8YxV0=; b=Vzurqx2nNARjPf ClUOpN0iHoxuP4jUBIm8cX9N7wbHQztwGOv4MZW3+oLxyrC50fUdL6ta6s5zoVzUY4X08eRNmuILH ZUkrQ/6CVNj38Olj4AwJeXps/CT8M612/FQsTZuLb3mWfiekFThguAR94YsZUIgABA7Xv50vgM/a+ dFwDeY+/VrgbOhcpsjx/f/dSQAeOB6C40hACeR4sDNMT24X48W7Bcl95uJWBUYKuDqTXfqd0l92eH FLYw7qK0abgsNeJVB78KWqJ6hkqxtgzAG794gZ6t4XRFear8p4gfBg7JQVBej6kk3Hjhu3OSWKNI+ rqx2+ZSN4JWLGKClH+Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrGnN-00000002B6X-2i7j; Tue, 04 Aug 2026 15:11:09 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrGnM-00000002B6E-1OzH for linux-i3c@lists.infradead.org; Tue, 04 Aug 2026 15:11:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 967F9408BA; Tue, 4 Aug 2026 15:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 333DF1F000E9; Tue, 4 Aug 2026 15:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785856267; bh=0BfEsiuGtJ1q8aQ1OAIg3K8HEz5qNqgcILIY4mnu/HI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Xcsy5jWhPQtKnrt396hoz8FyJfEe13tylAhDvkthxgh1sUZxqvDJG2mAcsfBOD9hT I0BOV4KbGxRBq3HyuA7Nq9isVMO9yuqxfxpUOoB41PBEROHveE7RXmD7hVSPosIWkP VspZzJ8JFHBQiKIhZTQx//58yCVN/ZOR+v5S7TQU9RD0yn0eTAm+cZyB5sj+VS8T0U dBEPLm9YhrOb7lz8BneogJQiNPbQDmMQx9EAv8+SFnx2WPctqz6wVTmfybaA0MnhUu tKRuzwQF3kphCHDHnQccVnyTYvx2z4Dfb9bu4bn7R1GsGXZcLRv9UV8Pwr/VIjw24d hHZ1ouwTmqrbA== From: sashiko-bot@kernel.org Subject: Re: [PATCH V3 07/14] i3c: master: Fix potential UAF in i3c_device_match() To: "Adrian Hunter" Cc: linux-pci@vger.kernel.org, Frank.Li@kernel.org, "Alexandre Belloni" , linux-i3c@lists.infradead.org In-Reply-To: <20260804133810.184905-8-adrian.hunter@intel.com> References: <20260804133810.184905-1-adrian.hunter@intel.com> <20260804133810.184905-8-adrian.hunter@intel.com> Date: Tue, 04 Aug 2026 15:11:06 +0000 Message-Id: <20260804151107.333DF1F000E9@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtIaWdoXSBS ZW1vdmFsIG9mIHRoZSBOVUxMIGNoZWNrIGZvciBgaTNjZGV2LT5kZXNjYCBpbnRyb2R1Y2VzIGEg Z3VhcmFudGVlZCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UgaW4gY29uY3VycmVudCB1bnJlZ2lz dHJhdGlvbiBwYXRocy4KLSBbSGlnaF0gVW5jb25kaXRpb25hbCBhY2Nlc3MgdG8gYGkzY2Rldi0+ YnVzYCBpbiBgaTNjX2RldmljZV9tYXRjaCgpYCBjYXVzZXMgYSBVc2UtQWZ0ZXItRnJlZSBpZiB0 aGUgcGFyZW50IG1hc3RlciBjb250cm9sbGVyIGhhcyBiZWVuIGZyZWVkLgoKUHJlLWV4aXN0aW5n IGlzc3VlczoKLSBbSGlnaF0gUHJlZXhpc3RpbmcgdXNlLWFmdGVyLWZyZWUgcmFjZSBjb25kaXRp b24gaW4gQU1EIFNCUk1JIChgc2JybWlfaTNjX3Byb2JlYCkgYWNjZXNzaW5nIGBpM2NkZXYtPmRl c2NgIHdpdGhvdXQgaG9sZGluZyB0aGUgYnVzIGxvY2suCi0tCgotLS0gUGF0Y2ggWzddOiBbUEFU Q0ggVjMgMDcvMTRdIGkzYzogbWFzdGVyOiBGaXggcG90ZW50aWFsIFVBRiBpbiBpM2NfZGV2aWNl X21hdGNoKCkgLS0tCmNvbW1pdCBkMDg4MzU5YzBjY2NiNTYwNjdkNDI2ZTkyZDBhNDlmMjQzNzZk ZTUzCkF1dGhvcjogQWRyaWFuIEh1bnRlciA8YWRyaWFuLmh1bnRlckBpbnRlbC5jb20+CgppM2M6 IG1hc3RlcjogRml4IHBvdGVudGlhbCBVQUYgaW4gaTNjX2RldmljZV9tYXRjaCgpCgpUaGlzIGNv bW1pdCBwcm90ZWN0cyBhY2Nlc3MgdG8gaTNjZGV2LT5kZXNjIHdpdGggdGhlIGJ1cyBub3JtYWwt dXNlIGxvY2sKaW4gaTNjX2RldmljZV9tYXRjaCgpIHRvIHByZXZlbnQgYSB1c2UtYWZ0ZXItZnJl ZSBkdXJpbmcgY29uY3VycmVudApkZXNjcmlwdG9yIHJlcGxhY2VtZW50LiBJdCBhbHNvIHJlbW92 ZXMgdGhlIE5VTEwgY2hlY2sgZm9yIGkzY2Rldi0+ZGVzYywKYXNzdW1pbmcgdGhlIGxvY2sgZ3Vh cmFudGVlcyB2YWxpZGl0eS4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaTNjL21hc3Rlci5jIGIv ZHJpdmVycy9pM2MvbWFzdGVyLmMKPiBpbmRleCA5NDdhYjNjNjgxZDVlLi5lN2VhNDEwMDc4ODkx IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaTNjL21hc3Rlci5jCj4gKysrIGIvZHJpdmVycy9pM2Mv bWFzdGVyLmMKPiBAQCAtMzQ3LDggKzM0NywxMCBAQCBzdGF0aWMgaW50IGkzY19kZXZpY2VfbWF0 Y2goc3RydWN0IGRldmljZSAqZGV2LCBjb25zdCBzdHJ1Y3QgZGV2aWNlX2RyaXZlciAqZHJ2KQo+ ICAJaTNjZGV2ID0gZGV2X3RvX2kzY2RldihkZXYpOwo+ICAJaTNjZHJ2ID0gZHJ2X3RvX2kzY2Ry dihkcnYpOwo+ICAKPiAtCWlmIChpM2NkZXYtPmRlc2MgJiYgaTNjZGV2LT5kZXNjLT5ib2FyZGlu Zm8pCj4gKwlpM2NfYnVzX25vcm1hbHVzZV9sb2NrKGkzY2Rldi0+YnVzKTsKCltTZXZlcml0eTog SGlnaF0KRG9lcyBhY2Nlc3NpbmcgaTNjZGV2LT5idXMgaGVyZSByaXNrIGEgdXNlLWFmdGVyLWZy ZWUgaWYgdGhlIHBhcmVudCBtYXN0ZXIKY29udHJvbGxlciBoYXMgYmVlbiBmcmVlZD8KCkR1cmlu ZyB1bnJlZ2lzdHJhdGlvbiwgaTNjX21hc3Rlcl91bnJlZ2lzdGVyKCkgdW5yZWdpc3RlcnMgY2hp bGQgZGV2aWNlcywKYW5kIGRldmljZV9kZWwoKSBkcm9wcyB0aGUgY2hpbGQncyByZWZlcmVuY2Ug dG8gdGhlIHBhcmVudCBieSBjYWxsaW5nCnB1dF9kZXZpY2UocGFyZW50KS4gT25jZSB1bnJlZ2lz dHJhdGlvbiBmaW5pc2hlcywgdGhlIHBhcmVudCBwbGF0Zm9ybSBkZXZpY2UKdW5iaW5kcyBhbmQg aXRzIGRldnJlcyBmcmVlcyB0aGUgSTNDIG1hc3RlciBzdHJ1Y3QuIAoKSWYgYSBjb25jdXJyZW50 IGJ1c19mb3JfZWFjaF9kZXYoKSBpdGVyYXRvciAoc3VjaCBhcyBmcm9tIGRyaXZlciByZWdpc3Ry YXRpb24pCmhvbGRzIGEgcmVmZXJlbmNlIHRvIHRoZSBjaGlsZCBkZXZpY2UsIHRoZSBjaGlsZCBv dXRsaXZlcyB0aGUgcGFyZW50LiBUaGUKY2hpbGQncyBpM2NkZXYtPmJ1cyBwb2ludGVyIHdvdWxk IHRoZW4gcmVtYWluIHBvaW50aW5nIHRvIHRoZSBmcmVlZCBtYXN0ZXIKbWVtb3J5LCBsZWFkaW5n IHRvIGEgdXNlLWFmdGVyLWZyZWUgd2hlbiBhY3F1aXJpbmcgdGhlIGxvY2suCgo+ICsJaWYgKGkz Y2Rldi0+ZGVzYy0+Ym9hcmRpbmZvKQoKW1NldmVyaXR5OiBIaWdoXQpDb3VsZCByZW1vdmluZyB0 aGUgTlVMTCBjaGVjayBmb3IgaTNjZGV2LT5kZXNjIGxlYWQgdG8gYSBOVUxMIHBvaW50ZXIKZGVy ZWZlcmVuY2UgZHVyaW5nIGNvbmN1cnJlbnQgdW5yZWdpc3RyYXRpb24/CgpJbiBpM2NfbWFzdGVy X3VucmVnaXN0ZXJfaTNjX2RldnMoKSwgaTNjZGV2LT5kZXYtPmRlc2MgPSBOVUxMOyBpcyBzZXQg d2l0aG91dApob2xkaW5nIGFueSBidXMgbG9ja3MuIAoKSWYgYSBjb25jdXJyZW50IGRyaXZlciBt YXRjaGluZyB0aHJlYWQgaW52b2tlcyBpM2NfZGV2aWNlX21hdGNoKCksIGl0IGNhbgpwcm9jZWVk IGluIHBhcmFsbGVsIGJlY2F1c2UgZHJpdmVyX21hdGNoX2RldmljZSgpIG9wZXJhdGVzIG91dHNp ZGUKZGV2aWNlX2xvY2soKS4gVGhlIHRocmVhZCBhY3F1aXJlcyB0aGUgYnVzIGxvY2ssIGJ1dCBz aW5jZSB1bnJlZ2lzdHJhdGlvbgpkb2Vzbid0IGhvbGQgaXQsIGl0IGNvdWxkIHJlYWQgZGVzYyBh cyBOVUxMIGFuZCBjcmFzaCB3aGVuIGFjY2Vzc2luZwppM2NkZXYtPmRlc2MtPmJvYXJkaW5mby4K Cj4gIAkJc3RhdGljX2FkZHJfbWV0aG9kID0gaTNjZGV2LT5kZXNjLT5ib2FyZGluZm8tPnN0YXRp Y19hZGRyX21ldGhvZDsKPiArCWkzY19idXNfbm9ybWFsdXNlX3VubG9jayhpM2NkZXYtPmJ1cyk7 Cj4gIAo+ICAJLyoKPiAgCSAqIFNFVEFBU0EtYmFzZWQgZGV2aWNlcyBuZWVkIG5vdCBhbHdheXMg aGF2ZSBhIG1hdGNoaW5nIElEIHNpbmNlCgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUt ZXhpc3RpbmcgaXNzdWUsIGJ1dCBJIG5vdGljZWQgYSBzaW1pbGFyIGxvY2tpbmcgcHJvYmxlbSBp bgp0aGUgQU1EIFNCUk1JIGRyaXZlci4KCkluIGRyaXZlcnMvbWlzYy9hbWQtc2JpL3JtaS1pMmMu YzpzYnJtaV9pM2NfcHJvYmUoKToKCiAgICBpZiAoSTNDX1BJRF9JTlNUQU5DRV9JRChpM2NkZXYt PmRlc2MtPmluZm8ucGlkKSAhPSAxKQoKVGhpcyBkZXJlZmVyZW5jZXMgaTNjZGV2LT5kZXNjIHdp dGhvdXQgYWNxdWlyaW5nIGkzY19idXNfbm9ybWFsdXNlX2xvY2soKQpvciB1c2luZyB0aGUgc2Fm ZSBpM2NfZGV2aWNlX2dldF9pbmZvKCkgQVBJLgoKU2luY2UgcHJvYmUgcnVucyBob2xkaW5nIGRl dmljZV9sb2NrKCksIGl0IGlzIG5vdCBtdXR1YWxseSBleGNsdXNpdmUgd2l0aAp0aGUgYnVzIG1h aW50ZW5hbmNlIHdyaXRlLWxvY2sgdXNlZCBmb3IgZGVzY3JpcHRvciByZXBsYWNlbWVudCBpbgpf X2kzY19tYXN0ZXJfYWRkX2kzY19kZXZfbG9ja2VkKCkuIElmIGEgZGV2aWNlJ3MgYWRkcmVzcyBp cyBjb25jdXJyZW50bHkKcmUtYXNzaWduZWQgZHVyaW5nIERBQSBob3Qtam9pbiwgY291bGQgcHJv YmUgZGVyZWZlcmVuY2UgYSBmcmVlZCBkZXNjcmlwdG9yCndoZW4gaXQgcmVzdW1lcz8KCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4 MDQxMzM4MTAuMTg0OTA1LTEtYWRyaWFuLmh1bnRlckBpbnRlbC5jb20/cGFydD03CgotLSAKbGlu dXgtaTNjIG1haWxpbmcgbGlzdApsaW51eC1pM2NAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWkzYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F277E3921E0 for ; Tue, 4 Aug 2026 15:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785856273; cv=none; b=SUwt6xFM7x1DxUNyO2kUh66L+kU+wo97tyrOzf5SrMXfCU6ID+29fTJZq7Ph8EGu3DqG1gytskbpF2JQeBs/HlUP9UlMaScHZiWNB2K0P3fw5q+Z3CsH6Il84+DAbXgKAuMJFCH374fhjgu0fm96EgMVp15oLz0eLZT1IZy8Fgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785856273; c=relaxed/simple; bh=ZVSoRw0A3XxKjePxP3T6mIHi/kG5JI+mL5D/pTQTNTY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=cHIPfHnJfqJKUwDinEabEdS6UhfcAkeYQkO5nVbj0F8/nynzMV6nZh2gjzwkokUpACWxIu5eIwmGE2rQO/Kvkl2DX1FlBgVVUKk29wtfVNqtBFmLeq30Acx32Hx4OkoHb7HZkhbgXLu/Qx+fUhB2QlsuWrmRZ2734F2Gf7AC1pU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xcsy5jWh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xcsy5jWh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 333DF1F000E9; Tue, 4 Aug 2026 15:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785856267; bh=0BfEsiuGtJ1q8aQ1OAIg3K8HEz5qNqgcILIY4mnu/HI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Xcsy5jWhPQtKnrt396hoz8FyJfEe13tylAhDvkthxgh1sUZxqvDJG2mAcsfBOD9hT I0BOV4KbGxRBq3HyuA7Nq9isVMO9yuqxfxpUOoB41PBEROHveE7RXmD7hVSPosIWkP VspZzJ8JFHBQiKIhZTQx//58yCVN/ZOR+v5S7TQU9RD0yn0eTAm+cZyB5sj+VS8T0U dBEPLm9YhrOb7lz8BneogJQiNPbQDmMQx9EAv8+SFnx2WPctqz6wVTmfybaA0MnhUu tKRuzwQF3kphCHDHnQccVnyTYvx2z4Dfb9bu4bn7R1GsGXZcLRv9UV8Pwr/VIjw24d hHZ1ouwTmqrbA== From: sashiko-bot@kernel.org Subject: Re: [PATCH V3 07/14] i3c: master: Fix potential UAF in i3c_device_match() Reply-To: sashiko-reviews@lists.linux.dev To: "Adrian Hunter" Cc: linux-pci@vger.kernel.org, Frank.Li@kernel.org, "Alexandre Belloni" , linux-i3c@lists.infradead.org In-Reply-To: <20260804133810.184905-8-adrian.hunter@intel.com> References: <20260804133810.184905-1-adrian.hunter@intel.com> <20260804133810.184905-8-adrian.hunter@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 04 Aug 2026 15:11:06 +0000 Message-Id: <20260804151107.333DF1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: New issues: - [High] Removal of the NULL check for `i3cdev->desc` introduces a guarante= ed NULL pointer dereference in concurrent unregistration paths. - [High] Unconditional access to `i3cdev->bus` in `i3c_device_match()` caus= es a Use-After-Free if the parent master controller has been freed. Pre-existing issues: - [High] Preexisting use-after-free race condition in AMD SBRMI (`sbrmi_i3c= _probe`) accessing `i3cdev->desc` without holding the bus lock. -- --- Patch [7]: [PATCH V3 07/14] i3c: master: Fix potential UAF in i3c_devic= e_match() --- commit d088359c0cccb56067d426e92d0a49f24376de53 Author: Adrian Hunter i3c: master: Fix potential UAF in i3c_device_match() This commit protects access to i3cdev->desc with the bus normal-use lock in i3c_device_match() to prevent a use-after-free during concurrent descriptor replacement. It also removes the NULL check for i3cdev->desc, assuming the lock guarantees validity. > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 947ab3c681d5e..e7ea410078891 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -347,8 +347,10 @@ static int i3c_device_match(struct device *dev, cons= t struct device_driver *drv) > i3cdev =3D dev_to_i3cdev(dev); > i3cdrv =3D drv_to_i3cdrv(drv); > =20 > - if (i3cdev->desc && i3cdev->desc->boardinfo) > + i3c_bus_normaluse_lock(i3cdev->bus); [Severity: High] Does accessing i3cdev->bus here risk a use-after-free if the parent master controller has been freed? During unregistration, i3c_master_unregister() unregisters child devices, and device_del() drops the child's reference to the parent by calling put_device(parent). Once unregistration finishes, the parent platform device unbinds and its devres frees the I3C master struct.=20 If a concurrent bus_for_each_dev() iterator (such as from driver registrati= on) holds a reference to the child device, the child outlives the parent. The child's i3cdev->bus pointer would then remain pointing to the freed master memory, leading to a use-after-free when acquiring the lock. > + if (i3cdev->desc->boardinfo) [Severity: High] Could removing the NULL check for i3cdev->desc lead to a NULL pointer dereference during concurrent unregistration? In i3c_master_unregister_i3c_devs(), i3cdev->dev->desc =3D NULL; is set wit= hout holding any bus locks.=20 If a concurrent driver matching thread invokes i3c_device_match(), it can proceed in parallel because driver_match_device() operates outside device_lock(). The thread acquires the bus lock, but since unregistration doesn't hold it, it could read desc as NULL and crash when accessing i3cdev->desc->boardinfo. > static_addr_method =3D i3cdev->desc->boardinfo->static_addr_method; > + i3c_bus_normaluse_unlock(i3cdev->bus); > =20 > /* > * SETAASA-based devices need not always have a matching ID since [Severity: High] This is a pre-existing issue, but I noticed a similar locking problem in the AMD SBRMI driver. In drivers/misc/amd-sbi/rmi-i2c.c:sbrmi_i3c_probe(): if (I3C_PID_INSTANCE_ID(i3cdev->desc->info.pid) !=3D 1) This dereferences i3cdev->desc without acquiring i3c_bus_normaluse_lock() or using the safe i3c_device_get_info() API. Since probe runs holding device_lock(), it is not mutually exclusive with the bus maintenance write-lock used for descriptor replacement in __i3c_master_add_i3c_dev_locked(). If a device's address is concurrently re-assigned during DAA hot-join, could probe dereference a freed descriptor when it resumes? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260804133810.1849= 05-1-adrian.hunter@intel.com?part=3D7