All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: atomlin@atomlin.com
Cc: akpm@linux-foundation.org, mhiramat@kernel.org, pmladek@suse.com,
	linux-kernel@vger.kernel.org, david.laight.linux@gmail.com,
	neelx@suse.com, sean@ashe.io, chjohnst@gmail.com, steve@abita.co,
	mproche@gmail.com, nick.lange@gmail.com,
	Lance Yang <lance.yang@linux.dev>
Subject: Re: [PATCH v7 1/2] hung_task: Reset warning budget when problem gets resolved
Date: Wed,  5 Aug 2026 00:40:10 +0800	[thread overview]
Message-ID: <20260804164010.79596-1-lance.yang@linux.dev> (raw)
In-Reply-To: <20260804155406.254810-2-atomlin@atomlin.com>


On Tue, Aug 04, 2026 at 11:54:05AM -0400, Aaron Tomlin wrote:
>From: Petr Mladek <pmladek@suse.com>
>
>sysctl_hung_task_warnings counts how many hung tasks are reported.
>The watchdog does not report anything once the limit is reached.
>Currently, this budget is decremented permanently, meaning the kernel is
>left blind to subsequent hung tasks even after the original issue resolves.
>
>Keep the global sysctl_hung_task_warnings intact, and instead decrement
>a copy (hung_task_warnings_printed) when warnings are printed. Reset
>the copy back to the configured sysctl_hung_task_warnings limit once the
>problem on the system gets resolved and check_hung_uninterruptible_tasks()
>detects no hung tasks in a check interval.
>
>Also keep the copy updated when the global sysctl_hung_task_warnings
>value is updated via sysctl, and update documentation to reflect
>the new behavior.

I'd go with something like:

"
hung_task: separate warning limit from runtime budget

sysctl_hung_task_warnings currently holds both the configured warning
limit and the remaining budget. Each detailed report decrements the
sysctl, so once it reaches zero, the configured limit is lost and cannot
be restored automatically.

Keep sysctl_hung_task_warnings unchanged and track the remaining budget
in hung_task_warnings_printed. Reset the runtime budget when a watchdog
check sees no hung tasks or when userspace writes a new sysctl value.
"

[...]

Cheers, Lance

  reply	other threads:[~2026-08-04 16:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 15:54 [PATCH v7 0/2] hung_task: Improve warning budget handling and task reporting Aaron Tomlin
2026-08-04 15:54 ` [PATCH v7 1/2] hung_task: Reset warning budget when problem gets resolved Aaron Tomlin
2026-08-04 16:40   ` Lance Yang [this message]
2026-08-04 17:35     ` Aaron Tomlin
2026-08-04 15:54 ` [PATCH v7 2/2] hung_task: Always print basic hung task info header Aaron Tomlin
2026-08-04 16:42   ` Lance Yang
2026-08-04 17:36     ` Aaron Tomlin
2026-08-04 16:30 ` [PATCH v7 0/2] hung_task: Improve warning budget handling and task reporting Lance Yang
2026-08-04 17:32   ` Aaron Tomlin
2026-08-05  1:48     ` Lance Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804164010.79596-1-lance.yang@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=chjohnst@gmail.com \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mproche@gmail.com \
    --cc=neelx@suse.com \
    --cc=nick.lange@gmail.com \
    --cc=pmladek@suse.com \
    --cc=sean@ashe.io \
    --cc=steve@abita.co \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.